Re: [OpenJDK 2D-Dev] [8] Request for review: 7190349 and 8013569.

2013-07-22 Thread Sergey Bylokhov
Hi, Phil. Can I push the fix? Because nobody have an additional comments. Deep testing of these changes is required, and I would like to start it earlier, than later. On 03.07.2013 3:29, Phil Race wrote: On 7/1/2013 7:57 AM, Sergey Bylokhov wrote: Hello. Can you take a look to the fix for:

Re: [OpenJDK 2D-Dev] [8] Request for review: 7190349 and 8013569.

2013-07-22 Thread Phil Race
OK. -phil. On 7/22/13 10:27 AM, Sergey Bylokhov wrote: Hi, Phil. Can I push the fix? Because nobody have an additional comments. Deep testing of these changes is required, and I would like to start it earlier, than later. On 03.07.2013 3:29, Phil Race wrote: On 7/1/2013 7:57 AM, Sergey

Re: [OpenJDK 2D-Dev] [8] Request for review: 7190349 and 8013569.

2013-07-03 Thread Sergey Bylokhov
Hi, Phil. On 03.07.2013 3:29, Phil Race wrote: This is fine with me, although we have an odd mixture of JRS and non JRS functions here and as you and others have asked or implied, I am not sure why we need any JRS functions in this part of the code. What do they do that we can't find from

Re: [OpenJDK 2D-Dev] [8] Request for review: 7190349 and 8013569.

2013-07-02 Thread Phil Race
On 7/1/2013 7:57 AM, Sergey Bylokhov wrote: Hello. Can you take a look to the fix for: 7190349 : [macosx] Text (Label) is incorrectly drawn with a rotated g2d 8013569 : [macosx] JLabel preferred size incorrect on retina displays with non-default font size 1 JRS function from Java Runtime

Re: [OpenJDK 2D-Dev] [8] Request for review: 7190349 and 8013569.

2013-07-02 Thread Mike Swingler
On Jul 2, 2013, at 4:29 PM, Phil Race philip.r...@oracle.com wrote: On 7/1/2013 7:57 AM, Sergey Bylokhov wrote: Hello. Can you take a look to the fix for: 7190349 : [macosx] Text (Label) is incorrectly drawn with a rotated g2d 8013569 : [macosx] JLabel preferred size incorrect on retina