Re: [OpenJDK 2D-Dev] [8u Backport] Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

2016-09-29 Thread Jim Graham
+1 ...jim On 9/28/16 10:17 AM, Philip Race wrote: +1 -phil On 9/14/16, 2:52 AM, Ajit Ghaisas wrote: Hi Jim, I agree upon aborting the operation in case the non-finite slope is not due to divide by 0 case. As this is the 8u backport of the fix done in 9, I will

Re: [OpenJDK 2D-Dev] [8u Backport] Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

2016-09-28 Thread Philip Race
+1 -phil On 9/14/16, 2:52 AM, Ajit Ghaisas wrote: Hi Jim, I agree upon aborting the operation in case the non-finite slope is not due to divide by 0 case. As this is the 8u backport of the fix done in 9, I will address the review comment in JDK-8166009. The original backport

Re: [OpenJDK 2D-Dev] [8u Backport] Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

2016-09-14 Thread Ajit Ghaisas
Hi Jim, I agree upon aborting the operation in case the non-finite slope is not due to divide by 0 case. As this is the 8u backport of the fix done in 9, I will address the review comment in JDK-8166009. The original backport webrev is still the same.

Re: [OpenJDK 2D-Dev] [8u Backport] Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

2016-09-01 Thread Jim Graham
Hi Ajit, In the cases where you "continue" on a non-finite slope, doesn't that mean that the edges will be mismatched? If you can't determine the bounding polygon, perhaps the entire operation should be aborted instead...? It's different from the case of dy1==dy2 which also results in a

[OpenJDK 2D-Dev] [8u Backport] Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

2016-09-01 Thread Ajit Ghaisas
Hi, This is a review request for 8u back-port of the fix done in JDK-9. Bug : https://bugs.openjdk.java.net/browse/JDK-8158356 Root cause : The root cause of the crash is - NaN is converted to an integer and used as array index in mlib_ImageScanPoly.c. Fix : The