Re: [OpenJDK 2D-Dev] [9] Review Request: 8039418 [macosx] Calling JNI functions in the scope of Get/ReleasePrimitiveArrayCritical

2014-04-09 Thread Phil Race
Looks OK to me .. -phil. On 4/8/2014 2:21 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. The method [1] is called between Get/ReleasePrimitiveArrayCritical. In the fix it was moved above GetPrimitiveArrayCritical call. [1]: JNIEXPORT void JNICALL Transform_GetInfo(JNIEnv

Re: [OpenJDK 2D-Dev] [9] Review Request: 8039418 [macosx] Calling JNI functions in the scope of Get/ReleasePrimitiveArrayCritical

2014-04-09 Thread Andrew Brygin
Hello Sergey, the fix looks fine to me. Thanks, Andrew On 4/9/2014 1:21 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. The method [1] is called between Get/ReleasePrimitiveArrayCritical. In the fix it was moved above GetPrimitiveArrayCritical call. [1]: JNIEXPORT void

[OpenJDK 2D-Dev] [9] Review Request: 8039418 [macosx] Calling JNI functions in the scope of Get/ReleasePrimitiveArrayCritical

2014-04-08 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 9. The method [1] is called between Get/ReleasePrimitiveArrayCritical. In the fix it was moved above GetPrimitiveArrayCritical call. [1]: JNIEXPORT void JNICALL Transform_GetInfo(JNIEnv *env, jobject txform, TransformInfo *pTxInfo) { pTxInfo-dxdx =