On 12.09.16 22:36, Vadim Pakhnushev wrote:
Looks good to me (have you submitted JPRT job just in case?)
+1, I also suggest before the push to check jprt for safety, the change
are in native + in java on different platforms.
Vadim
On 12/09/16 22:31, Semyon Sadetsky wrote:
I missed this
On 12/09/16 23:06, Semyon Sadetsky wrote:
On 9/12/2016 10:36 PM, Vadim Pakhnushev wrote:
Looks good to me (have you submitted JPRT job just in case?)
Is JPRT really necessary? The native part is only changed for Windows
on which the build is deterministic.
As you wish
--Semyon
Vadim
Looks good to me (have you submitted JPRT job just in case?)
Vadim
On 12/09/16 22:31, Semyon Sadetsky wrote:
I missed this file in the list of changes.
http://cr.openjdk.java.net/~ssadetsky/8155753/webrev.02/
--Semyon
On 9/12/2016 9:33 PM, Vadim Pakhnushev wrote:
Have you forgotten
I missed this file in the list of changes.
http://cr.openjdk.java.net/~ssadetsky/8155753/webrev.02/
--Semyon
On 9/12/2016 9:33 PM, Vadim Pakhnushev wrote:
Have you forgotten adding changes in AccelGraphicsConfig?
Have you forgotten adding changes in AccelGraphicsConfig?
c:\Vadim\jdk9-client\jdk\src\java.desktop\windows\classes\sun\java2d\d3d\D3DGraphicsConfig.java:52:
error: D3DGraphicsConfig is not abstract and does not override abstract
method removeDeviceEventListener(AccelDeviceEventListener) in
http://cr.openjdk.java.net/~ssadetsky/8155753/webrev.01/
AccelDeviceEventNotifier is removed.
--Semyon
On 9/12/2016 6:56 PM, Semyon Sadetsky wrote:
Okay. I will remove AccelDeviceEventNotifier and all related code.
--Semyon
On 9/12/2016 6:43 PM, Vadim Pakhnushev wrote:
Hi Semyon,
Okay. I will remove AccelDeviceEventNotifier and all related code.
--Semyon
On 9/12/2016 6:43 PM, Vadim Pakhnushev wrote:
Hi Semyon,
Generally seems reasonable, it seems that you should use screen
instead of gdiScreen in the JNU_CallStaticMethodByName, otherwise the
code won't compile.
Not
Hi Semyon,
Generally seems reasonable, it seems that you should use screen instead
of gdiScreen in the JNU_CallStaticMethodByName, otherwise the code won't
compile.
Not sure how the rest of the code handles monitor removal, seems to me
that there are no usages of this notifications anywhere,
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8155753
webrev: http://cr.openjdk.java.net/~ssadetsky/8155753/webrev.00/
The issue take place on Windows platform if Direct3d is on. The
notification routine about the monitor removal tries to get screen
number
