Re: [OpenJDK 2D-Dev] [PATCH] Re: JDK-8012351

2014-02-11 Thread Andrew Brygin
Hello Phil, the fix looks fine to me. Thanks, Andrew On 2/11/2014 2:48 AM, Phil Race wrote: On 2/10/2014 2:14 PM, Sergey Bylokhov wrote: Hi, Phil. - Should we catch situations, when the getParentFile will return null, and change 'return newDir.equals(existDir)' to 'return Objects.equals(n

Re: [OpenJDK 2D-Dev] [PATCH] Re: JDK-8012351

2014-02-10 Thread Sergey Bylokhov
Hi, Phil. The fix looks good. On 11.02.2014 2:48, Phil Race wrote: On 2/10/2014 2:14 PM, Sergey Bylokhov wrote: Hi, Phil. - Should we catch situations, when the getParentFile will return null, and change 'return newDir.equals(existDir)' to 'return Objects.equals(newDir, existDir)'? I can .

Re: [OpenJDK 2D-Dev] [PATCH] Re: JDK-8012351

2014-02-10 Thread Phil Race
On 2/10/2014 2:14 PM, Sergey Bylokhov wrote: Hi, Phil. - Should we catch situations, when the getParentFile will return null, and change 'return newDir.equals(existDir)' to 'return Objects.equals(newDir, existDir)'? I can .. http://cr.openjdk.java.net/~prr/8012351.1/ although for this to be

Re: [OpenJDK 2D-Dev] [PATCH] Re: JDK-8012351

2014-02-10 Thread Sergey Bylokhov
Hi, Phil. - Should we catch situations, when the getParentFile will return null, and change 'return newDir.equals(existDir)' to 'return Objects.equals(newDir, existDir)'? - I suppose it was a typo ">=" in SunFontManager? Otherwise the fix looks good, but note that I'm not an expert in this

Re: [OpenJDK 2D-Dev] [PATCH] Re: JDK-8012351

2014-02-05 Thread Phil Race
So that patch wasn't the right thing but as a result of off-list discussion its become clearer how the problem might occur I've updated https://bugs.openjdk.java.net/browse/JDK-8012351 with the evaluation. And I think this is the right fix for it: http://cr.openjdk.java.net/~prr/8012351/ Pleas

[OpenJDK 2D-Dev] [PATCH] Re: JDK-8012351

2014-01-21 Thread Ryan Tandy
Dear JDK team, Further to my earlier message, please find attached the patch that I think solves JDK-8012351. I applied this change to the Ubuntu JDK7 package and made it available at the Launchpad bug for testing; so far one other user commented that it works for them. Can JDK-8012351 be re-open