Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-06 Thread Lindenmaier, Goetz
m> > Cc: Sergey Bylokhov <sergey.bylok...@oracle.com>; awt- > d...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net> > Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor > issues in awt coding > > I didn't eyeball what you changed but JPRT is now happy. &

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-05 Thread Philip Race
.@sap.com>; Sergey Bylokhov <sergey.bylok...@oracle.com> Cc: awt-...@openjdk.java.net; 2d-dev<2d-dev@openjdk.java.net> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding I tried it .. and just as well I did. It fails in the crypto code on Mac. jdk/src/jd

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-05 Thread Lindenmaier, Goetz
02, 2016 8:46 PM > >> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Sergey Bylokhov > >> <sergey.bylok...@oracle.com> > >> Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net> > >> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: F

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-05 Thread Phil Race
] Sent: Friday, December 02, 2016 8:46 PM To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Sergey Bylokhov <sergey.bylok...@oracle.com> Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt codi

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-03 Thread Lindenmaier, Goetz
;; Sergey Bylokhov > <sergey.bylok...@oracle.com> > Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net> > Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor > issues in awt coding > > I had no other comments, except that it would be good to be sure >

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-02 Thread Phil Race
-dev@openjdk.java.net>; security- d...@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding Sorry. it is ops->GetRasInfo(env, ops, lockInfo); that initialises it .. That is still before the dereference Anyway, what was the reaso

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
t.x.r...@oracle.com> > Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>; security- > d...@openjdk.java.net > Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues > in awt coding > > Sorry. it is > ops->GetRasInfo(env, ops, lockInfo); > t

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Phil Race
ava.net>; security- d...@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding Hi Goetz, DataBufferNative.c Using uninitialized value lockInfo.rasBase when calling DBN_GetPixelPointer. 75 lockInfo.resBase = NULL; Did you actually compi

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
ta Sadhukhan' <prasanta.sadhuk...@oracle.com>; Phil Race > <philip.r...@oracle.com>; Sergey Bylokhov <sergey.bylok...@oracle.com>; > Vincent Ryan <vincent.x.r...@oracle.com> > Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>; security- > d...@openjdk.java.net

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
rgey.bylok...@oracle.com>; Lindenmaier, Goetz > <goetz.lindenma...@sap.com>; Vincent Ryan <vincent.x.r...@oracle.com> > Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>; security- > d...@openjdk.java.net > Subject: Re: [OpenJDK 2D-Dev] RF

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
et; 2d-dev <2d-dev@openjdk.java.net>; security- > d...@openjdk.java.net > Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues > in awt coding > > Hi Goetz, > > > DataBufferNative.c > > Using uninitialized value lockInfo.rasBase when calling DBN

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
Hi Christoph, I changed the code in fontpath.c to use snprintf, that seems much better as the concatenated string is a literal anyways. Also, I fixed the spaces. I'll post a new webrev once I'm through all the reviews. Best regards, Goetz. > -Original Message- > From: Langer,

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-11-30 Thread Semyon Sadetsky
yes, this is a potential issue. But actually cases MID,FOCUS,BLACK,WHITE are never used. But the fix is wrong. It should be color.alpha = 1; --Semyon On 01.12.2016 08:05, Prasanta Sadhukhan wrote: Also, in gtk3_interface.c, there is this change for color.alpha 2219 color.alpha = 0; in

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-11-30 Thread Prasanta Sadhukhan
Also, in gtk3_interface.c, there is this change for color.alpha 2219 color.alpha = 0; in gtk3_get_color_for_flags() but it is used in gtk3_get_color_for_state() where it is not initialized 2268 GdkRGBA color; Regards Prasanta On 12/1/2016 1:28 AM, Phil Race wrote: Hi Goetz,

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-11-30 Thread Langer, Christoph
Hi Goetz, I have some small remarks. src/java.desktop/unix/native/common/awt/fontpath.c: 247 fontDirPath[sizeof(fontDirPath)-1] = '\0'; -> you should add spaces left and right of '-' 248 strncat(fontDirPath, "/fonts.dir", sizeof(fontDirPath) - strlen(fontDirPath)); -> I

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-11-30 Thread Sergey Bylokhov
cc 2d-dev. On 30.11.16 18:41, Lindenmaier, Goetz wrote: Hi Vincent, thanks for the quit review! Good catch that I lost the change to p11_mutex.c ... I had to change it and it fell out of my patches. I edited the Last Modified Date, and also updated the copyright messages. New webrev: