Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-20 Thread Phil Race
Thanks, I may just go with the flow on the Mac platorm detection but separately from online and offline discussions the Mac platform os.name setup code maybe should be changed to ensure it does always return Mac*. Anything else is likely to be a compatibility issue for a lot more than this code.

Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-20 Thread Igor Nekrestyanov
i am fine with the fix regardless of a way to detect Mac platform. -igor On 6/19/12 9:13 AM, Phil Race wrote: 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null http://cr.openjdk.java.net/~prr/7124536.7u6/ -phil.

Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-19 Thread Mike Swingler
On Jun 19, 2012, at 4:45 PM, Phil Race wrote: > Mike, > > On 6/19/2012 3:37 PM, Mike Swingler wrote: >> Currently, JDK 7 uses JRSCopyOSName() so that the difference between "Mac OS >> X" and "Mac OS X Server" can be distinguished. > Is there a better (standard) way? If it matters at all to disti

Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-19 Thread Phil Race
Mike, On 6/19/2012 3:37 PM, Mike Swingler wrote: Currently, JDK 7 uses JRSCopyOSName() so that the difference between "Mac OS X" and "Mac OS X Server" can be distinguished. Is there a better (standard) way? If it matters at all to distinguish server vs. client ? On Windows we care about server

Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-19 Thread Mike Swingler
Currently, JDK 7 uses JRSCopyOSName() so that the difference between "Mac OS X" and "Mac OS X Server" can be distinguished. I am recommending the use of .contains("OS X") to more robustly determine if you are on the OS X platform, and still retain the ability to distinguish between client and s

Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-19 Thread Phil Race
On 6/19/2012 11:33 AM, Artem Ananiev wrote: On 6/19/2012 8:49 PM, Phil Race wrote: startsWith("Mac") is what we use in FX and I don't see a problem with it and its surely more reliable to type and efficient than contains("OS X"); If its meant to be targeted to a specific version that could br

Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-19 Thread Artem Ananiev
On 6/19/2012 8:49 PM, Phil Race wrote: startsWith("Mac") is what we use in FX and I don't see a problem with it and its surely more reliable to type and efficient than contains("OS X"); If its meant to be targeted to a specific version that could break if there's an OS XI .. And startsWith("Win"

Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-19 Thread Phil Race
Its not going to change as a system property in JDK 7 no matter what marketing name Apple use for their OS so I see no issue here. -phil. On 6/19/2012 11:00 AM, Sergey Bylokhov wrote: Hi, Phil. But some time ago in the jdk all .startsWith("Mac OS X") or .startsWith("Mac") were replaced by ".c

Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-19 Thread Sergey Bylokhov
Hi, Phil. But some time ago in the jdk all .startsWith("Mac OS X") or .startsWith("Mac") were replaced by ".contains("OS X")" http://hg.openjdk.java.net/jdk8/awt/jdk/rev/77b35c5c4b95 In print area also, see changes in UnixPrintServiceLookup.isBSD(). As far as I know Apple officially drops Mac f

Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-19 Thread Phil Race
startsWith("Mac") is what we use in FX and I don't see a problem with it and its surely more reliable to type and efficient than contains("OS X"); If its meant to be targeted to a specific version that could break if there's an OS XI .. And startsWith("Win") is a common pattern. So I don't agree

Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-19 Thread Sergey Bylokhov
Hi,Phil. According to these CR macosx check should be: .contains("OS X"). http://monaco.sfbay.sun.com/detail.jsf?cr=7147461 http://monaco.sfbay.sun.com/detail.jsf?cr=7130404 On 19.06.2012 20:13, Phil Race wrote: 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null http:

Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-19 Thread Andrew Brygin
The fix looks fine, approved. Thanks, Andrew On 19.06.2012 20:13, Phil Race wrote: 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null http://cr.openjdk.java.net/~prr/7124536.7u6/ -phil.

[OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-19 Thread Phil Race
7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null http://cr.openjdk.java.net/~prr/7124536.7u6/ -phil.