Hi Phil,
sorry I didn't wanted to overrule you but after I didn't heard back
from you for almost a week (an out of office mail could have been
helpful) and after I got 5 other reviews I decided to finally fix the
build error on AIX.
On Mon, Nov 26, 2018 at 9:35 PM Phil Race wrote:
>
> Well .. I
Side note, I wondered whether IBM does anything original in their
openj9 (the jdk parts they forked off OpenJDK) since they are
targetting AIX too and must be having the same build error. But I
cannot find anything they did:
---
thomas@t450:/shared/projects/openjdk/j9/openj9-openjdk-jdk$ git log
Well .. I see this was pushed whilst I was on vacation.
I would not have voted for the fix in its current form. The
"HAVE_XRANDR" would
have been less bad. If (say) HPUX has the same issue you
haven't really helped them with an AIX specific change in the source file.
It would have been better
On 2018-11-20 19:13, Volker Simonis wrote:
Thanks everybody for the reviews.
If nobody raises a "Veto" (Phil?) I plan to push this fix tomorrow in
its current form.
I think this sounds reasonable.
I've also run it through the submit repo and got an error on Windows
for the test
Thanks everybody for the reviews.
If nobody raises a "Veto" (Phil?) I plan to push this fix tomorrow in
its current form.
I've also run it through the submit repo and got an error on Windows
for the test "runtime/modules/JVMDefineModule.java" which seems
completely unrelated to my change which
On 2018-11-19 18:56, Volker Simonis wrote:
Hi Phil,
I'd like to kindly ask you to suggest how we can proceed with this issue.
As I wrote before, Xrandr is not officially supported on AIX and there
are no official packages available for it. There are some OpenSource
sites for AIX which
Hi Volker,
I had a look at your change. It looks good.
I appreciate a lot you added a check in configure.
Maybe it would be better to pass a WITHOUT_XRANDR
or the like to the build, and check for such a define
in the code.
But I think we should push this change for now to fix the build.
A
FWIW I am very much in favor of (1) and if aesthetics are a problem in
awt_GraphicsEnv.c, a "HAVE_XRANDR" define would make things a bit
prettier...
just my 2c.
On Mon, Nov 19, 2018 at 6:58 PM Volker Simonis wrote:
>
> Hi Phil,
>
> I'd like to kindly ask you to suggest how we can proceed with
Hi Phil,
I'd like to kindly ask you to suggest how we can proceed with this issue.
As I wrote before, Xrandr is not officially supported on AIX and there
are no official packages available for it. There are some OpenSource
sites for AIX which provide Xrandr, but they are all not compatible
with
On 11/15/2018 05:06 PM, Volker Simonis wrote:
> can I please have a review for the following small change:
>
> http://cr.openjdk.java.net/~simonis/webrevs/2018/8213944/
*) I tested it on platform without libxrandr-dev installed, and configure
reported the failure
appopriately.
*) Indent looks
On Thu, Nov 15, 2018 at 6:01 PM Philip Race wrote:
>
> PS I am not sure why xrandr headers would not be available for AIX.
> They are a standard part of the xdistribution.
>
I'm not an X11 guru, but as far as I understand, xrandr is an
extension and as such it doesn't have to be supported by
On Thu, Nov 15, 2018 at 5:31 PM Aleksey Shipilev wrote:
>
> On 11/15/2018 05:06 PM, Volker Simonis wrote:
> > can I please have a review for the following small change:
> >
> > http://cr.openjdk.java.net/~simonis/webrevs/2018/8213944/
>
> *) I tested it on platform without libxrandr-dev
On Thu, Nov 15, 2018 at 5:55 PM Philip Race wrote:
>
> Hmm. I don't like the ifdefs.
>
Mee too, but what else can we do, if there are no Xrandr headers
available on a platform?
Please see my answer to your other mail...
> Xrandr is a requirement for the build. If its not there at runtime
>
Looks ok to me. Thanks for handling the configure changes!
/Erik
On 2018-11-15 08:06, Volker Simonis wrote:
Hi,
can I please have a review for the following small change:
http://cr.openjdk.java.net/~simonis/webrevs/2018/8213944/
https://bugs.openjdk.java.net/browse/JDK-8213944
Change
PS I am not sure why xrandr headers would not be available for AIX.
They are a standard part of the xdistribution.
If true, think what you are going to have to do is add a
--with-xrandr-include option
and provide it that way.
-phil.
On 11/15/18, 8:55 AM, Philip Race wrote:
Hmm. I don't like
Hmm. I don't like the ifdefs.
Xrandr is a requirement for the build. If its not there at runtime
that's OK.
-phil.
On 11/15/18, 8:06 AM, Volker Simonis wrote:
Hi,
can I please have a review for the following small change:
http://cr.openjdk.java.net/~simonis/webrevs/2018/8213944/
Hi,
can I please have a review for the following small change:
http://cr.openjdk.java.net/~simonis/webrevs/2018/8213944/
https://bugs.openjdk.java.net/browse/JDK-8213944
Change JDK-8210863 removed the Xrandr.h/randr.h headers from the
OpenJDK sources but forgot to add a configure check for the
17 matches
Mail list logo
