Re: [OpenJDK 2D-Dev] RFR: 8024343: Change different color with the The XOR alternation color combobox, the color of the image can not shown immediately.

2013-10-01 Thread Andrew Brygin
Hi Vadim, the fix looks fine to me. I am not sure about the test, which will fail on windows. Probably it would be fine too, if you will submit a new bug against D3D immediately after the push. Thanks, Andrew On 10/1/2013 2:06 PM, Vadim Pakhnushev wrote: Hi, Please review a fix for this

Re: [OpenJDK 2D-Dev] RFR: 8024343: Change different color with the The XOR alternation color combobox, the color of the image can not shown immediately.

2013-10-01 Thread Clemens Eisserer
Hi Vadim, The fix itself looks fine to me - thanks for taking care about this. - Clemens PS: what is the reason for this bug is confidential? Please review a fix for this bug: https://bugs.openjdk.java.net/browse/JDK-8024343

Re: [OpenJDK 2D-Dev] RFR: 8024343: Change different color with the The XOR alternation color combobox, the color of the image can not shown immediately.

2013-10-01 Thread Vadim Pakhnushev
Clemens, This bug is filed against JCK test, and there were a lot of internal urls in descriptions, hence it's confidential. So I have created open automatic regression test for that. Thanks, Vadim On 01.10.2013 20:43, Clemens Eisserer wrote: Hi Vadim, The fix itself looks fine to me -

Re: [OpenJDK 2D-Dev] RFR: 8024343: Change different color with the The XOR alternation color combobox, the color of the image can not shown immediately.

2013-10-01 Thread Phil Race
That sounds fine to me too .. -phil. On 10/1/2013 6:57 AM, Andrew Brygin wrote: Hi Vadim, the fix looks fine to me. I am not sure about the test, which will fail on windows. Probably it would be fine too, if you will submit a new bug against D3D immediately after the push. Thanks,