On 03/21/2016 01:15 PM, Vadim Pakhnushev wrote:
Phil,
Now the javadoc for both java.awt.Font.createFonts methods is incorrect:
* The explicit purpose of this overloading of the
* {@code createFont(int, InputStream)} method
It's not an overload anymore.
That is true. I'll just change
Phil,
Now the javadoc for both java.awt.Font.createFonts methods is incorrect:
* The explicit purpose of this overloading of the
* {@code createFont(int, InputStream)} method
It's not an overload anymore.
Other than that, looks good.
Vadim
On 21.03.2016 20:52, Phil Race wrote:
After some CCC
After some CCC discussion the method name was changed from createFont to
createFonts
since it is expected to suport returning > 1. No other changes.
http://cr.openjdk.java.net/~prr/8055463.2
I am still looking for a 2nd reviewer !
-phil.
On 03/12/2016 08:22 AM, Sergey Bylokhov wrote:
Looks
Looks fine.
ps: for the record - long time ago the OSX code was different:
http://hg.openjdk.java.net/macosx-port/macosx-port/jdk/rev/e910dde2c36c
On 11.03.16 23:34, Phil Race wrote:
Oops. Fixed : http://cr.openjdk.java.net/~prr/8055463.1/
-phil.
On 03/11/2016 12:22 PM, Sergey Bylokhov wrote:
Oops. Fixed : http://cr.openjdk.java.net/~prr/8055463.1/
-phil.
On 03/11/2016 12:22 PM, Sergey Bylokhov wrote:
Hi, Phil.
The FileFont.java contains debug code:
System.out.println("COUNT="+count);
System.out.println("FILE="+fontFile);
On 11.03.16 2:02, Phil Race wrote:
PS there are a couple
Hi, Phil.
The FileFont.java contains debug code:
System.out.println("COUNT="+count);
System.out.println("FILE="+fontFile);
On 11.03.16 2:02, Phil Race wrote:
PS there are a couple of other test files updated here
BigFont is one of the tests I ran whilst checking I didn't create
regressions
