Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

2016-08-23 Thread Vadim Pakhnushev
+1 Vadim On 21.08.2016 21:31, Philip Race wrote: Thanks Sergey .. I am still waiting for a 2nd +1 from someone else. -phil. On 8/12/16, 12:28 PM, Sergey Bylokhov wrote: Looks fine. On 12.08.16 20:15, Philip Race wrote: Updated test : http://cr.openjdk.java.net/~prr/8139176.1/ -phil. On

Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

2016-08-21 Thread Philip Race
Thanks Sergey .. I am still waiting for a 2nd +1 from someone else. -phil. On 8/12/16, 12:28 PM, Sergey Bylokhov wrote: Looks fine. On 12.08.16 20:15, Philip Race wrote: Updated test : http://cr.openjdk.java.net/~prr/8139176.1/ -phil. On 8/12/16, 10:11 AM, Philip Race wrote: On 8/12/16,

Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

2016-08-12 Thread Sergey Bylokhov
Looks fine. On 12.08.16 20:15, Philip Race wrote: Updated test : http://cr.openjdk.java.net/~prr/8139176.1/ -phil. On 8/12/16, 10:11 AM, Philip Race wrote: On 8/12/16, 5:48 AM, Sergey Bylokhov wrote: Hi, Phil. A few comments about the test: - jtreg can stop the test at the end of the

Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

2016-08-12 Thread Phil Race
On 08/12/2016 10:20 AM, Sergey Bylokhov wrote: On 12.08.16 20:11, Philip Race wrote: I assume the added code will be removed after follow-on fix? It does not have to be .. it is harmless and perhaps useful. I was thinking of leaving it. Then probably it can be added to the PhysicalFont

Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

2016-08-12 Thread Sergey Bylokhov
On 12.08.16 20:11, Philip Race wrote: I assume the added code will be removed after follow-on fix? It does not have to be .. it is harmless and perhaps useful. I was thinking of leaving it. Then probably it can be added to the PhysicalFont itself? -- Best regards, Sergey.

Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

2016-08-12 Thread Philip Race
On 8/12/16, 5:48 AM, Sergey Bylokhov wrote: Hi, Phil. A few comments about the test: - jtreg can stop the test at the end of the main, before invokeLater will start/complete.(on my system it always pass because of that) hmm. The only reason this test shows a window is to be helpful to

Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

2016-08-12 Thread Sergey Bylokhov
On 12.08.16 15:48, Sergey Bylokhov wrote: Hi, Phil. A few comments about the test: - jtreg can stop the test at the end of the main, before invokeLater will start/complete.(on my system it always pass because of that) - The frame should be disposed at the end of the test. - Probably the

Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

2016-08-12 Thread Sergey Bylokhov
Hi, Phil. A few comments about the test: - jtreg can stop the test at the end of the main, before invokeLater will start/complete.(on my system it always pass because of that) - The frame should be disposed at the end of the test. - Probably the correct location of the test is