IIRC, Windows doesn't install the Japanese fonts by default .. at least not
in non-Asian locales, so I think we need to add
Font msMincho = new Font("MS Mincho", Font.PLAIN, 16);
String family = msMincho.getFamily(java.util.Locale.ENGLISH);
if
Hello Phil.
Test case is available.
Could you review the fix again ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8214002
Change: https://cr.openjdk.java.net/~itakiguchi/8214002/webrev.02/
Thanks,
Ichiroh Takiguchi
On 2018-11-28 10:13, Philip Race wrote:
Oh .. there's no regression test.
Oh .. there's no regression test. If you can't find one then I think you
can write one relatively easily by selecting the known font - MS Mincho,
making sure we are on Windows (don't try it on Mac even if the font
exists), draw the text to a BufferedImage in plain / regular style.
Repeat to a
Hello Phil.
Do you need me to push this ?
Yes, if possible.
Currently, no sponsor is assigned for this issue.
Ichiroh Takiguchi
On 2018-11-28 05:43, Phil Race wrote:
On 11/27/18 9:36 AM, Ichiroh Takiguchi wrote:
Hello Phil.
I don't have any concern about this fix.
I'm thinking why initial
On 11/27/18 9:36 AM, Ichiroh Takiguchi wrote:
Hello Phil.
I don't have any concern about this fix.
I'm thinking why initial programmer used FT_LOAD_RENDER instead of
FT_LOAD_DEFAULT.
Probably that this was what we wanted to do in almost all cases and it has
now turned out to be untrue ..
Hello Phil.
I don't have any concern about this fix.
I'm thinking why initial programmer used FT_LOAD_RENDER instead of
FT_LOAD_DEFAULT.
On my testing, this fix was fine for me.
Ichiroh Takiguchi
On 2018-11-27 03:59, Philip Race wrote:
It seems fine to me. What is your concern when you say
It seems fine to me. What is your concern when you say :
> But it may change font rendering behavior...
-phil
On 11/18/18, 9:35 PM, Ichiroh Takiguchi wrote:
Hello Phill.
I tested and checked your suggested code. [1]
It worked fine.
But it may change font rendering behavior...
Please review
Hello Phill.
I tested and checked your suggested code. [1]
It worked fine.
But it may change font rendering behavior...
Please review the fix ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8214002
Change: https://cr.openjdk.java.net/~itakiguchi/8214002/webrev.01/
Thanks,
Ichiroh Takiguchi
Hi,
Thanks for spotting this. But I'm not sure the conditions are right.
Don't we need to unconditionally remove FT_LOAD_RENDER if synthetic styles
are requested, regardless of the value of that flag ?
Perhaps we should not set FT_LOAD_RENDER upfront in which case we'll just call
it once
we
Hello.
Could you review the fix ?
Issue:
Cannot use italic font style if the font has embeded bitmap.
Bug:https://bugs.openjdk.java.net/browse/JDK-8214002
Change: https://cr.openjdk.java.net/~itakiguchi/8214002/webrev.00/
It seems it's side-effect for:
8204929: Fonts with embedded bitmaps
10 matches
Mail list logo
