On 12.11.2013 23:43, Jim Graham wrote:
Hi Alexander,
Some minor issues with this fix:
- It looks like the transform is used in SG2D to decide if the hiDPI
image should be used. I'm not familiar with the Mac's native use of
@2x, but I thought that they hinged the decision off of the retina
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8011059/webrev.07/
- The default sun hint is added.
However, it looks the same as the resolution variant ON hint right
now. It would better to leave the behavior on the non HiDPI displays the
same as it was
On Nov 12, 2013, at 7:10 PM, Jim Graham james.gra...@oracle.com wrote:
So, then, it sounds like on the Mac the default heuristic should be to take
the transform into account and choose @2x based on that. We don't yet know
if that matches the default Windows 8 heuristics, but we only have 1
On 11/13/13 4:33 AM, Sergey Bylokhov wrote:
On 12.11.2013 23:43, Jim Graham wrote:
- The logic in using the transform is also a bit murky. I think if
you set the scale on a retina display to exactly 1/2 it would use the
HiDPI version even though the scale was 1:1. Since I support not
Hi Phil, Guys ,
This one is stuck waiting for review for quite long time.
Please review so we can push this change.
Thanks,
-Dmitry
08.11.2013 12:40, Dmitry Ginzburg wrote:
Colleagues,
friendly reminder.
Back in early October I did all proposed changes; could you please
review this third
Hi Alexander,
Please read my followup message on the wording for the SunHint
descriptions. The version you used in this webrev contains multiple
conflicting uses of the word default.
The default value for the hint should be DEFAULT. Note that Mike has
already stated that NSImage uses @2x
On 11/13/13 9:21 AM, Mike Swingler wrote:
- Hopefully the answers to the above 2 questions for Mike won't be surprising...
...jim
I hope I haven't surprised anyone. :-)
Regards,
Mike Swingler
Apple Inc.
Only that if the images are used on non-retina Macs then we
On 13.11.2013 22:49, Jim Graham wrote:
On 11/13/13 4:33 AM, Sergey Bylokhov wrote:
On 12.11.2013 23:43, Jim Graham wrote:
- The logic in using the transform is also a bit murky. I think if
you set the scale on a retina display to exactly 1/2 it would use the
HiDPI version even though the
On 13.11.2013 23:25, Sergey Bylokhov wrote:
- The logic in using the transform is also a bit murky. I think if
you set the scale on a retina display to exactly 1/2 it would use the
HiDPI version even though the scale was 1:1. Since I support not
examining the transform there, I'm going to
Changeset: f2ae86dba4bc
Author:prr
Date: 2013-11-13 11:59 -0800
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f2ae86dba4bc
8028206: sun/java2d/cmm/ProfileOp/SetDataTest.java fails
Reviewed-by: bae, jchen
! src/share/native/sun/java2d/cmm/lcms/cmsio0.c
!
Hi Sergey,
On 11/13/13 11:25 AM, Sergey Bylokhov wrote:
On 13.11.2013 22:49, Jim Graham wrote:
On 11/13/13 4:33 AM, Sergey Bylokhov wrote:
On 12.11.2013 23:43, Jim Graham wrote:
- The logic in using the transform is also a bit murky. I think if
you set the scale on a retina display to
On 11/13/13 11:44 AM, Sergey Bylokhov wrote:
On 13.11.2013 23:25, Sergey Bylokhov wrote:
- The logic in using the transform is also a bit murky. I think if
you set the scale on a retina display to exactly 1/2 it would use the
HiDPI version even though the scale was 1:1. Since I support not
Hello, Jim.
On 13.11.2013 22:49, Jim Graham wrote:
That's could be a problem. Is it possible to wrap imageObserver, which
was passed to the drawImage, and replace one image to another in the
WrapperImageObserver.imageUpdate()?
It's possible - the things to watch out for:
- they could hand
13 matches
Mail list logo
