[OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-6574555 Webrev : http://cr.openjdk.java.net/~jdv/6574555/webrev.00/ Issue: PNGImageWriter. write_bKGD() function sets incorrect R, G, B value when IHDR colortype and bKGD colortype

[OpenJDK 2D-Dev] [11] RFR for JDK-8201240: Improve releasing native resources of BufImgSurfaceData.ICMColorData

Hi, Please review the fix for jdk11: bug: https://bugs.openjdk.java.net/browse/JDK-8201240 webrev: http://cr.openjdk.java.net/~aivanov/8201240/jdk11/webrev.00/ BufImgSurfaceData.ICMColorData uses finalize() to dispose of native resources. 2D components usually use Java 2D Disposer. It can

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

http://cr.openjdk.java.net/~jdv/6788458/webrev.07/src/java.desktop/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java.udiff.html There's an extra line added at the end which you can remove. Why do the tests needs to create temp disk files ? Can't we do this all with

Re: [OpenJDK 2D-Dev] Proposal: Unicode Variation Selector

I recommend you ask Steven Loomis to sponsor this - and probably the input method support, but particularly this one. -phil. On 04/08/2018 11:46 PM, Toshio 5 Nakamura wrote: Hello IBM would like to propose Unicode Variation Selector[1] capability to AWT and Swing components. (This proposal

Re: [OpenJDK 2D-Dev] RFR: JDK-8200793: Fix new compilation errors with Xcode 9.2 and deployment target 10.9

Correct, I will be removing t2k soon so there is no need to address it in 11. Just disabling the warning will suffice. -phil. On 04/05/2018 01:25 AM, Magnus Ihse Bursie wrote: On 2018-04-05 02:01, Erik Joelsson wrote: After bumping the deployment target to 10.9, a few more compilation

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8201240: Improve releasing native resources of BufImgSurfaceData.ICMColorData

+1 -phil. On 04/11/2018 07:05 AM, Alexey Ivanov wrote: Hi, Please review the fix for jdk11: bug: https://bugs.openjdk.java.net/browse/JDK-8201240 webrev: http://cr.openjdk.java.net/~aivanov/8201240/jdk11/webrev.00/ BufImgSurfaceData.ICMColorData uses finalize() to dispose of native

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

The fix seems fine but like the other review I wonder if the test can use a bytearrayoutputstream instead of writing to a file. -phil. On 04/11/2018 03:51 AM, Jayathirth D V wrote: Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-6574555

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8201240: Improve releasing native resources of BufImgSurfaceData.ICMColorData

Looks fine. On 11/04/2018 07:05, Alexey Ivanov wrote: Hi, Please review the fix for jdk11: bug: https://bugs.openjdk.java.net/browse/JDK-8201240 webrev: http://cr.openjdk.java.net/~aivanov/8201240/jdk11/webrev.00/ BufImgSurfaceData.ICMColorData uses finalize() to dispose of native