Hi All,
Please review a fix for an issue where it is seen that if we do not have
any printer installed and we try to save the printjob to a file
via "Save as PDF" option in mac, it was throwing PrinterExcetion:no
printer service found.
This is a regression of JDK-8132988 where a check was
Hello,
Could you please review the following fix which adds two blocks of
source code comments to two files.
Bug: https://bugs.openjdk.java.net/browse/JDK-8211165
Webrev: http://cr.openjdk.java.net/~alitvinov/8211165/jdk12/webrev.00
Thank you,
Anton
Interesting and I assume that it was somewhat less in JD8u ?
Off the top of my head that is one thing that didn't change in any big
way since JDK 8u.
Perhaps something has changed so that it is now [considered] needed
whereas before
it was not? So did it go from zero percent to 29% or from
This is all MacOS specific changes - and functionality - but the test seems
to be cross-platform. Shouldn't it at least have an @requires macos tag ?
And I think the test should verify there are no printers and say it can't
be run if you have any ... and exit ...
Can we set & retrieve the file
Hello Phil,
Thank you very much for approval of this fix. I will push the fix
immediately. I think that for this particular case it is better to
include also "2018,", because we add the header itself in 2018 and it
will not look good, if we introduce the header and change the file now
and
Looks good to me.
Not sure if including 2018 is strictly needed since the only change in
2018 is to add
the legal notice itself :-)
-phill
On 09/26/2018 09:40 AM, Anton Litvinov wrote:
Hello,
Could you please review the following fix which adds two blocks of
source code comments to two
Hi, Anton.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8211165
> Webrev: http://cr.openjdk.java.net/~alitvinov/8211165/jdk12/webrev.00
Your change looks good. I've verified that you have the correct copyright
format, copyright year range, and license.
Thank you for taking care of this!
Multiple pieces are changing across these releases.
Is it the JPEG writing ? Is it freetype vs t2k (font performance)
is it harfbuzz vs icu (text layout), is it marlin vs ductus
(rasterization) ?
So it is very hard to say with any certainty what the cause of the
difference is .. or
why 10
Hi Phil
What the PDFBox team told me it could have something to do with color
mapping.
And my quick profiling shows that the code spends 29% of the time inside of
java.awt.image.ColorConvertOp.filter on java 11
But I'll open a issue.
Best regards
Daniel
On Wed, Sep 26, 2018, 19:33 Phil Race
