+1
Thanks,
Krishna
-Original Message-
From: Jayathirth D V
Sent: Tuesday, November 20, 2018 1:59 PM
To: 2d-dev <2d-dev@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795:
ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458
Thanks Sergey for the review.
Hi Jay,
While the exception is suppressed with your fix, I think it makes sense to add
some logging of this fact, so that it could aid in debugging.
Thanks,
Krishna
-Original Message-
From: Jayathirth D V
Sent: Friday, November 16, 2018 12:30 PM
To: 2d-dev@openjdk.java.net
Subject:
Hi,
As OpenJDK12 RDP1 is coming soon, I propose this plan:
- integrate this basic fix in ShapeSpanIterator.c code to use stdlib sort
(mergesort on linux)
- integrate a very simple patch in Marlin renderer to disable insertion
sort for large arrays: 0.5s to 0.25s, few LOC
- postpone my changes to
Thanks Sergey for the review.
I need one more review.
Please review the latest webrev:
http://cr.openjdk.java.net/~jdv/8211795/webrev.01/
Thanks,
Jay
-Original Message-
From: Sergey Bylokhov
Sent: Saturday, November 17, 2018 3:35 AM
To: Jayathirth D V; 2d-dev
Subject: Re: [OpenJDK
On 2018-11-19 18:56, Volker Simonis wrote:
Hi Phil,
I'd like to kindly ask you to suggest how we can proceed with this issue.
As I wrote before, Xrandr is not officially supported on AIX and there
are no official packages available for it. There are some OpenSource
sites for AIX which
Thanks for the clarification Jay.
The changes look fine.
Krishna
-Original Message-
From: Jayathirth D V
Sent: Tuesday, November 20, 2018 3:37 PM
To: Krishna Addepalli ; 2d-dev@openjdk.java.net
Subject: RE: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt
CRC for IEND
Hi Volker,
I had a look at your change. It looks good.
I appreciate a lot you added a check in configure.
Maybe it would be better to pass a WITHOUT_XRANDR
or the like to the build, and check for such a define
in the code.
But I think we should push this change for now to fix the build.
A
On Tue, Nov 20, 2018 at 8:28 AM Laurent Bourgès
wrote:
> Will you have time to review 2 small patchs on time ?
If it would help for me to have a look, I am happy to do so.
Pete
Hi Krishna,
Thanks for the review.
I have added detail comment mentioning why we don’t read CRC data for IEND
chunk.
We can add debug/warning info mentioning that CRC data is not present/ corrupt,
but after IEND chunk type there can be any length of stream data. In the stream
present for this
I have removed awt-dev and replaced it with the CORRECT 2d-dev list.
Please reply to this one .. to get awt-dev out of the loop.
I already have an open bug to upgrade harfbuzz I will be handling soon.
If the necessary changes are there we are all good.
We do not much like at all locally modifying
d to my change which only touches the X11
implementation on Unix. Can somebody please confirm that?
[Mach5] mach5-one-simonis-JDK-8213944-20181120-1629-11082: FAILED,
Failed tests: 1
runtime/modules/JVMDefineModule.java tier1 windows-x64-debug othervm
driver ExitCode: -1073741819
Mach5 T
11 matches
Mail list logo
