Looks good.
Push to client. jdk-submit is just a way to get test builds on all
platforms.
This one is basic C that should build everywhere if it builds anywhere ..
-phil.
On 11/29/18 10:52 PM, Andrew Brygin wrote:
Hello Phil,
On Nov 30, 2018, at 6:27 AM, Philip Race wrote:
Hi,
I'd like
Hi Prasanta,
Adding style="text-align: center" attribute to element is
cleaner and achieves the same result as it applies to all (as well
which are center-aligned by default anyway). If the content of the
table is modified in the future, there will be no need to add style
attributes to
Hi Alexey,
I have modified to keep the "X" centred. Please find the modified webrev:
http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.1/
Regards
Prasanta
On 30-Nov-18 4:50 PM, Alexey Ivanov wrote:
Hi Prasanta,
Would the presentation benefit from
to keep X centred and thus to preserve
Hi Alexey,
Ok. Modified webrev:
http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.2/
Regards
Prasanta
On 30-Nov-18 10:12 PM, Alexey Ivanov wrote:
Hi Prasanta,
Adding style="text-align: center" attribute to element is
cleaner and achieves the same result as it applies to all (as
well
Hi Prasanta,
Looks good to me.
Regards,
Alexey
On 30/11/2018 17:23, Prasanta Sadhukhan wrote:
Hi Alexey,
Ok. Modified webrev:
http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.2/
Regards
Prasanta
On 30-Nov-18 10:12 PM, Alexey Ivanov wrote:
Hi Prasanta,
Adding style="text-align:
Bug : https://bugs.openjdk.java.net/browse/JDK-8214558
As noted in the bug this test has a bad @run line and the fix is to
remove it
diff inline below :
diff --git
a/test/jdk/java/awt/print/PrinterJob/CheckPrinterJobSystemProperty.java
Hello.
Please review the fix for jdk 12.
Bug: https://bugs.openjdk.java.net/browse/JDK-8214076
Webrev: http://cr.openjdk.java.net/~serb/8214076/webrev.01
While I am working on the:
https://bugs.openjdk.java.net/browse/JDK-8076313
I have started to unify the code between the platforms, and found
Looks fine.
On 30/11/2018 14:50, Phil Race wrote:
Bug : https://bugs.openjdk.java.net/browse/JDK-8214558
As noted in the bug this test has a bad @run line and the fix is to remove it
diff inline below :
diff --git
a/test/jdk/java/awt/print/PrinterJob/CheckPrinterJobSystemProperty.java
Looks good to me.
Krishna
> On 01-Dec-2018, at 7:33 AM, Sergey Bylokhov
> wrote:
>
> Hello.
> Please review the fix for jdk 12.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214461
> Webrev: http://cr.openjdk.java.net/~serb/8214461/webrev.00
>
> We have a few internal
+1
On 30/11/2018 13:16, Alexey Ivanov wrote:
Hi Prasanta,
Looks good to me.
Regards,
Alexey
On 30/11/2018 17:23, Prasanta Sadhukhan wrote:
Hi Alexey,
Ok. Modified webrev:
http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.2/
Regards
Prasanta
On 30-Nov-18 10:12 PM, Alexey Ivanov wrote:
Hello.
Please review the fix for jdk 12.
Bug: https://bugs.openjdk.java.net/browse/JDK-8214461
Webrev: http://cr.openjdk.java.net/~serb/8214461/webrev.00
We have a few internal classes/interfaces which currently unused and may be
removed:
- sun.awt.image.BadDepthException.java: looks like it
Hi Prasanta,
Would the presentation benefit from
to keep X centred and thus to preserve the visual appearance?
Do you mind updating the copyright?
Otherwise, the change looks good to me.
Regards,
Alexey
On 30/11/2018 07:41, Prasanta Sadhukhan wrote:
Hi All,
Please review a doc-fix to
12 matches
Mail list logo
