Re: [OpenJDK 2D-Dev] Remove redundant package name in src/java.desktop/share/classes/sun/java2d/Disposer.java

2015-04-23 Thread Roger Riggs
Hi NingHua, This topic might be most appropriate for the 2d-dev@openjdk.java.net alias This email strips attachments so an inline patch might be the easiest way to propose the change. Roger On 4/23/2015 1:19 AM, ning...@linux.vnet.ibm.com wrote: A. The problem to be resolve or feature to

Re: [OpenJDK 2D-Dev] Cleaner usage in java2 / awt

2016-01-15 Thread Roger Riggs
s modules.xml is modified or you should do it for me ? Regards, Laurent 2016-01-13 17:56 GMT+01:00 Roger Riggs <roger.ri...@oracle.com <mailto:roger.ri...@oracle.com>>: Hi Laurent, Nice use. You don't need to use the local_array in this case. Since th

Re: [OpenJDK 2D-Dev] Cleaner usage in java2 / awt

2016-01-13 Thread Roger Riggs
Hi Laurent, Nice use. You don't need to use the local_array in this case. Since the reference being cleaned is a the parent object it is ok that the closure captures 'this'. The modules.xml qualified export is fine. Roger On 1/13/16 11:48 AM, Laurent Bourgès wrote: Phil & Roger, Please

Re: [OpenJDK 2D-Dev] RFR: 8147443: Use Common Cleaner in Marlin OffHeapArray

2016-01-19 Thread Roger Riggs
Hi, This change looks ok to me (from the Cleaner perspective). (Phil, I'm assuming its just a typo that cleanerRef and cleanerObj should be the same.) Roger On 1/15/16 6:55 PM, Phil Race wrote: This looks fine to me. One comment that I am not sure applies here is that when using the

Re: [OpenJDK 2D-Dev] java.awt.* properties initialization?

2018-10-18 Thread Roger Riggs
On 10/18/2018 07:22 AM, Roger Riggs wrote: Hi, There are a few java.awt.* properties that have support in the system.c native code based on the operating system.   Most do not need to be in native code and decoupling the code would be a good cleanup. I'd like to look at the properties and

Re: [OpenJDK 2D-Dev] RFR: 8130264 : change the mechanism by which JDK loads the platform-specific PrinterJob implementation

2018-11-16 Thread Roger Riggs
Hi Phil, Looks fine from the core-libs perspective. Thanks, thanks for removing this cross module dependency. Roger On 11/15/2018 04:41 PM, Phil Race wrote: bug: http://cr.openjdk.java.net/~prr/8130264/ webrev: http://cr.openjdk.java.net/~prr/8130264/ Currently java launcher code embeds

Re: [OpenJDK 2D-Dev] RFR 8214014 : Remove vestiges of gopher: protocol proxy support

2018-11-28 Thread Roger Riggs
int/attribute/standard/ReferenceUriSchemesSupported.html#GOPHER -phil. On 11/28/18 8:34 AM, Roger Riggs wrote: Please review the removal of some left over references to the gopher protocol related to proxies. Most are related to properties or setting up proxies (for gopher). Please check in javax.pr

Re: [OpenJDK 2D-Dev] RFR 8214014 : Remove vestiges of gopher: protocol proxy support

2018-11-28 Thread Roger Riggs
re lost in the mists of time but GOPHER is no worse than NEWS, NNTP and WAIS in the same class. Why not remove those too ... the argument is no different , but an important point is the one I made above. This does NOT in any way suggest the scheme is supported by the JDK. -phil. On 11/28/18 1

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

2019-07-12 Thread Roger Riggs
Hi Brian, Would it be appropriate to add @Override to the new method (and perhaps existing overridden methods). Previously, calling FilterOutputStream.write(byte[]) would delegate to write(byte[], 0, length). The proposed change duplicates the code and changes the ways that overridden

[OpenJDK 2D-Dev] [jdk17] Withdrawn: 8271489: (doc) Clarify Filter Factory example

2021-07-29 Thread Roger Riggs
On Thu, 29 Jul 2021 16:36:21 GMT, Roger Riggs wrote: > Improve the clarity of comments in the ObjectInputFilter FilterInThread > example. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk17/pull/292

[OpenJDK 2D-Dev] [jdk17] RFR: 8271489: (doc) Clarify Filter Factory example

2021-07-29 Thread Roger Riggs
Improve the clarity of comments in the ObjectInputFilter FilterInThread example. - Commit messages: - 8271489: (doc) Clarify Filter Factory example - 8270398: Enhance canonicalization - 8270404: Better canonicalization - Merge - Merge - 8263531: Remove unused buffer int -