Re: [OpenJDK 2D-Dev] [8u] RFR: 8182461: IndexOutOfBoundsException when reading indexed color BMP

2018-08-12 Thread Fairoz Matte 
Thank you Phil and Sergey for the reviews.

Thanks,
Fairoz

> -Original Message-
> From: Sergey Bylokhov
> Sent: Saturday, August 11, 2018 12:29 AM
> To: Fairoz Matte ; 2d-dev@openjdk.java.net
> Subject: Re: [OpenJDK 2D-Dev] [8u] RFR: 8182461:
> IndexOutOfBoundsException when reading indexed color BMP
> 
> Looks fine.
> 
> On 10/08/2018 06:44, Fairoz Matte wrote:
> > Hi,
> >
> > Kindly review a small fix for 8u
> >
> > Background:
> > Issue exist only in 8 and it got fixed in 9 as part of "JDK-8033716 : Fix 
> > raw and
> unchecked lint warnings in com.sun.imageio"
> > This is big changeset and not feasible to backport on 8.
> >
> > Patch contains only the fix for 8182461
> >
> > JBS bug - https://bugs.openjdk.java.net/browse/JDK-8182461
> > Webrev - http://cr.openjdk.java.net/~fmatte/8182461/webrev.00/
> >
> > Thanks,
> > Fairoz
> >
> 
> 
> --
> Best regards, Sergey.

Re: [OpenJDK 2D-Dev] [8u] RFR: 8182461: IndexOutOfBoundsException when reading indexed color BMP

2018-08-10 Thread Sergey Bylokhov 

Looks fine.

On 10/08/2018 06:44, Fairoz Matte wrote:

Hi,

Kindly review a small fix for 8u

Background:
Issue exist only in 8 and it got fixed in 9 as part of "JDK-8033716 : Fix raw and 
unchecked lint warnings in com.sun.imageio"
This is big changeset and not feasible to backport on 8.

Patch contains only the fix for 8182461

JBS bug - https://bugs.openjdk.java.net/browse/JDK-8182461
Webrev - http://cr.openjdk.java.net/~fmatte/8182461/webrev.00/

Thanks,
Fairoz




--
Best regards, Sergey.

Re: [OpenJDK 2D-Dev] [8u] RFR: 8182461: IndexOutOfBoundsException when reading indexed color BMP

2018-08-10 Thread Phil Race 

+1

-phil.

On 08/10/2018 06:44 AM, Fairoz Matte wrote:

Hi,

Kindly review a small fix for 8u

Background:
Issue exist only in 8 and it got fixed in 9 as part of "JDK-8033716 : Fix raw and 
unchecked lint warnings in com.sun.imageio"
This is big changeset and not feasible to backport on 8.

Patch contains only the fix for 8182461

JBS bug - https://bugs.openjdk.java.net/browse/JDK-8182461
Webrev - http://cr.openjdk.java.net/~fmatte/8182461/webrev.00/

Thanks,
Fairoz

[OpenJDK 2D-Dev] [8u] RFR: 8182461: IndexOutOfBoundsException when reading indexed color BMP

2018-08-10 Thread Fairoz Matte 
Hi,

Kindly review a small fix for 8u 

Background:
Issue exist only in 8 and it got fixed in 9 as part of "JDK-8033716 : Fix raw 
and unchecked lint warnings in com.sun.imageio"
This is big changeset and not feasible to backport on 8.

Patch contains only the fix for 8182461

JBS bug - https://bugs.openjdk.java.net/browse/JDK-8182461  
Webrev - http://cr.openjdk.java.net/~fmatte/8182461/webrev.00/ 

Thanks,
Fairoz