Re: [OpenJDK 2D-Dev] [9] RFR: 8167291:[TEST_BUG] javax/print/attribute/Services_getDocFl.java

2016-10-12 Thread Phil Race

+1

-phil.

On 10/12/2016 10:04 AM, Prasanta Sadhukhan wrote:

Hi All,

Please review a small test bug fix to make sure postscript support 
variable is reset before new flavor postscript support is tested, so 
that if one service supports PS but a next one doesn't, it would not 
fail.


Bug: https://bugs.openjdk.java.net/browse/JDK-8167291

hg diff test/javax/print/attribute/Services_getDocFl.java
diff -r 58224e71ea72 test/javax/print/attribute/Services_getDocFl.java
--- a/test/javax/print/attribute/Services_getDocFl.javaThu Sep 01 
12:22:59 2016 -0700
+++ b/test/javax/print/attribute/Services_getDocFl.javaWed Oct 12 
22:30:06 2016 +0530

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2015, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2015, 2016, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -28,7 +28,7 @@

 /*
  * @test
- * @bug 4901243 8040139
+ * @bug 4901243 8040139 8167291
  * @summary JPG, GIF, and PNG DocFlavors (URL) should be supported if 
Postscript is supported.

  * @run main Services_getDocFl
 */
@@ -58,6 +58,7 @@
 pngImagesSupported = false;
 gifImagesSupported = false;
 jpgImagesSupported = false;
+psSupported = false;
 for (int j=0; j

[OpenJDK 2D-Dev] [9] RFR: 8167291:[TEST_BUG] javax/print/attribute/Services_getDocFl.java

2016-10-12 Thread Prasanta Sadhukhan

Hi All,

Please review a small test bug fix to make sure postscript support 
variable is reset before new flavor postscript support is tested, so 
that if one service supports PS but a next one doesn't, it would not fail.


Bug: https://bugs.openjdk.java.net/browse/JDK-8167291

hg diff test/javax/print/attribute/Services_getDocFl.java
diff -r 58224e71ea72 test/javax/print/attribute/Services_getDocFl.java
--- a/test/javax/print/attribute/Services_getDocFl.javaThu Sep 01 
12:22:59 2016 -0700
+++ b/test/javax/print/attribute/Services_getDocFl.javaWed Oct 12 
22:30:06 2016 +0530

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2015, 2016, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -28,7 +28,7 @@

 /*
  * @test
- * @bug 4901243 8040139
+ * @bug 4901243 8040139 8167291
  * @summary JPG, GIF, and PNG DocFlavors (URL) should be supported if 
Postscript is supported.

  * @run main Services_getDocFl
 */
@@ -58,6 +58,7 @@
 pngImagesSupported = false;
 gifImagesSupported = false;
 jpgImagesSupported = false;
+psSupported = false;
 for (int j=0; j