Sorry .. I forgot one thing I meant to mention.
Please remove all those commented out frprintf debugging statements.
298 //fprintf(stderr, "gradientInfo->start.x %f, gradientInfo->start.y
%f\n",
299 // gradientInfo->start.x, gradientInfo->start.y);
300 //fprintf(stderr, "gradientInfo->end.x %f
Hi Prasanta,
Changes are working fine.
Thanks,
Jay
-Original Message-
From: Philip Race
Sent: Wednesday, October 26, 2016 9:14 PM
To: Prasanta Sadhukhan
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162796: [macosx] LinearGradientPaint
and RadialGradientPaint are not printed
+1
-phil.
On 10/25/16, 11:01 PM, Prasanta Sadhukhan wrote:
Please find the webrev with modified testcase
http://cr.openjdk.java.net/~psadhukhan/8162796/webrev.03/
Regards
Prasanta
On 10/26/2016 2:45 AM, Philip Race wrote:
Hi,
This looks to work properly although I have a couple of nits and
Please find the webrev with modified testcase
http://cr.openjdk.java.net/~psadhukhan/8162796/webrev.03/
Regards
Prasanta
On 10/26/2016 2:45 AM, Philip Race wrote:
Hi,
This looks to work properly although I have a couple of nits and a
concern that perhaps we just need to live with.
* @requir
Hi,
This looks to work properly although I have a couple of nits and a
concern that perhaps we just need to live with.
* @requires (os.family == "mac")
Why ? This test should be valid across OSes .. and SFAIK Mac is the only
place it would fail without this fix.
Both tests have this issue.
Please find modified webrev with Linear/Radial Gradient NO_CYCLE option
catered through quartz api and REPEAT/REFLECT option catered via raster
path.
http://cr.openjdk.java.net/~psadhukhan/8162796/webrev.02/
Regards
Prasanta
On 10/22/2016 9:28 PM, Prasanta Sadhukhan wrote:
On 10/22/2016 4:50
On 10/22/2016 4:50 AM, Philip Race wrote:
Well it is confusing since in particular this exact change is in both
webrevs :-
http://cr.openjdk.java.net/~psadhukhan/8162796/webrev.01/src/java.desktop/macosx/native/libawt_lwawt/awt/QuartzSurfaceData.m.sdiff.html
Yes. This is same and I had to a
Well it is confusing since in particular this exact change is in both
webrevs :-
http://cr.openjdk.java.net/~psadhukhan/8162796/webrev.01/src/java.desktop/macosx/native/libawt_lwawt/awt/QuartzSurfaceData.m.sdiff.html
One thing that I think seems less ideal about this fix, at least for
the Gradie
No, this webrev supports LinearGradient/RadialGradient for all 3
options. The fix seems to be almost same as in TexturePaint but in a
different else block in OSXSurfaceData.java.
Regards
Prasanta
On 10/20/2016 9:31 PM, Phil Race wrote:
Leaving aside the tests, the webrev here looks to be the o
Leaving aside the tests, the webrev here looks to be the one proposed
for the TexturePaint bug. Did you get things mixed up ?
-phil.
On 10/20/2016 02:22 AM, Prasanta Sadhukhan wrote:
Hi Phil,
I have modified the webrev to support REFLECT and REPEAT albeit via
raster path and not via Quartz ap
Hi Phil,
I have modified the webrev to support REFLECT and REPEAT albeit via
raster path and not via Quartz api, as Quartz cannot handle REPEAT/REFLECT.
http://cr.openjdk.java.net/~psadhukhan/8162796/webrev.01/
Have tested with different fractions, stops, color.
Regards
Prasanta
On 9/28/2016
Hi,
LinearGradientPaint has three options as to how it is extended beyond
the end point
https://docs.oracle.com/javase/8/docs/api/java/awt/MultipleGradientPaint.CycleMethod.html
So far as I can see this code (and perhaps quartz) can only handle
NO_CYCLE ..
If REFLECT or REPEAT are specifie
Hi All,
Please review a fix for jdk9 where it is seen that LinearGradientPaint
is not getting printed on osx.
The below webrev is only for LinearGradientPaint
and RadialGradientPaint will be handled separately.
Bug: https://bugs.openjdk.java.net/browse/JDK-8162796
webrev: http://cr.openjdk.jav
13 matches
Mail list logo
