Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8201433: Fix potential crash in BufImg_SetupICM

2018-04-13 Thread Sergey Bylokhov
Looks fine. On 12/04/2018 15:15, Alexey Ivanov wrote: Hi Sergey, Thank you for your review. Please take a look at the updated webrev: http://cr.openjdk.java.net/~aivanov/8201433/jdk11/webrev.01/ On 12/04/2018 22:33, Sergey Bylokhov wrote: Hi, Alexey. Since the test requires 1g of memory,

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8201433: Fix potential crash in BufImg_SetupICM

2018-04-12 Thread Alexey Ivanov
Hi Sergey, Thank you for your review. Please take a look at the updated webrev: http://cr.openjdk.java.net/~aivanov/8201433/jdk11/webrev.01/ On 12/04/2018 22:33, Sergey Bylokhov wrote: Hi, Alexey. Since the test requires 1g of memory, should we use this tag?:  * @requires os.maxMemory >= 1g

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8201433: Fix potential crash in BufImg_SetupICM

2018-04-12 Thread Sergey Bylokhov
Hi, Alexey. Since the test requires 1g of memory, should we use this tag?: * @requires os.maxMemory >= 1g Otherwise the test may fail on start if amount of memory is not sufficient. On 12/04/2018 08:25, Alexey Ivanov wrote: Hi, Please review the fix for jdk11: bug:

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8201433: Fix potential crash in BufImg_SetupICM

2018-04-12 Thread Phil Race
+1 -phil. On 04/12/2018 08:25 AM, Alexey Ivanov wrote: Hi, Please review the fix for jdk11: bug: https://bugs.openjdk.java.net/browse/JDK-8201433 webrev: http://cr.openjdk.java.net/~aivanov/8201433/jdk11/webrev.00/ When the JVM is run with limited amount of memory, initCubemap function