Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213051:Invalid use of HTML5 in javax.print files

2018-11-30 Thread Sergey Bylokhov
+1 On 30/11/2018 13:16, Alexey Ivanov wrote: Hi Prasanta, Looks good to me. Regards, Alexey On 30/11/2018 17:23, Prasanta Sadhukhan wrote: Hi Alexey, Ok. Modified webrev: http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.2/ Regards Prasanta On 30-Nov-18 10:12 PM, Alexey Ivanov wrote:

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213051:Invalid use of HTML5 in javax.print files

2018-11-30 Thread Alexey Ivanov
Hi Prasanta, Looks good to me. Regards, Alexey On 30/11/2018 17:23, Prasanta Sadhukhan wrote: Hi Alexey, Ok. Modified webrev: http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.2/ Regards Prasanta On 30-Nov-18 10:12 PM, Alexey Ivanov wrote: Hi Prasanta, Adding style="text-align:

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213051:Invalid use of HTML5 in javax.print files

2018-11-30 Thread Prasanta Sadhukhan
Hi Alexey, Ok. Modified webrev: http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.2/ Regards Prasanta On 30-Nov-18 10:12 PM, Alexey Ivanov wrote: Hi Prasanta, Adding style="text-align: center" attribute to element is cleaner and achieves the same result as it applies to all (as well

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213051:Invalid use of HTML5 in javax.print files

2018-11-30 Thread Alexey Ivanov
Hi Prasanta, Adding style="text-align: center" attribute to element is cleaner and achieves the same result as it applies to all (as well which are center-aligned by default anyway). If the content of the table is modified in the future, there will be no need to add style attributes to

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213051:Invalid use of HTML5 in javax.print files

2018-11-30 Thread Prasanta Sadhukhan
Hi Alexey, I have modified to keep the "X" centred. Please find the modified webrev: http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.1/ Regards Prasanta On 30-Nov-18 4:50 PM, Alexey Ivanov wrote: Hi Prasanta, Would the presentation benefit from to keep X centred and thus to preserve

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213051:Invalid use of HTML5 in javax.print files

2018-11-30 Thread Alexey Ivanov
Hi Prasanta, Would the presentation benefit from to keep X centred and thus to preserve the visual appearance? Do you mind updating the copyright? Otherwise, the change looks good to me. Regards, Alexey On 30/11/2018 07:41, Prasanta Sadhukhan wrote: Hi All, Please review a doc-fix to