Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails

2018-10-30 Thread Fairoz Matte
anges are fine. > > Thanks, > Jay > > -Original Message- > From: Fairoz Matte > Sent: Tuesday, October 30, 2018 1:33 PM > To: Prasanta Sadhukhan; 2d-dev@openjdk.java.net > Subject: Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test > javax/imageio/plug

Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails

2018-10-30 Thread Jayathirth D V
tte Sent: Tuesday, October 30, 2018 1:33 PM To: Prasanta Sadhukhan; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails Thanks Prasanta, I will update that, need one more review on this? Thanks, Fairoz > -Origi

Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails

2018-10-30 Thread Fairoz Matte
> > >> -Original Message- > >> From: Prasanta Sadhukhan > >> Sent: Monday, October 29, 2018 12:18 PM > >> To: Fairoz Matte ; 2d-dev@openjdk.java.net > >> Subject: Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test > >>

Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails

2018-10-30 Thread Prasanta Sadhukhan
; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails Hi Fairoz, I do not see ImageIO.read and ImageIO.createImageInputStream throwing IOB exception in the spec, it throws IOException so I guess there's no point catching

Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails

2018-10-29 Thread Fairoz Matte
Hi Prasanta, > -Original Message- > From: Prasanta Sadhukhan > Sent: Monday, October 29, 2018 12:18 PM > To: Fairoz Matte ; 2d-dev@openjdk.java.net > Subject: Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test > javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails > &

Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails

2018-10-29 Thread Prasanta Sadhukhan
] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails Hi Fairoz, Do you know if the bmp image file has Oracle copyright? If not, you cannot check it in. I was not aware of it. Yes image file is not Oracle copyright compliant. Alternatively, you may get a hexdump of the bmp

Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails

2018-10-26 Thread Fairoz Matte
Hi Prasanta, Thanks for looking into it. > -Original Message- > From: Prasanta Sadhukhan > Sent: Friday, October 26, 2018 8:56 AM > To: Fairoz Matte ; 2d-dev@openjdk.java.net > Subject: Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test > javax/imageio/plugins/bmp/BMP8BPPL

Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails

2018-10-25 Thread Prasanta Sadhukhan
Hi Fairoz, Do you know if the bmp image file has Oracle copyright? If not, you cannot check it in. Alternatively, you may get a hexdump of the bmp file and create a byte[] array with that hex data and create ByteArrayInputStream with that and use that for ImageIO as an ImageInputStream.