Re: [OpenJDK 2D-Dev] [9] RFR JDK-6294607: GIFWriter returns the same compression type twice

2016-10-12 Thread Brian Burkhalter
+2 Brian On Oct 12, 2016, at 9:59 AM, Phil Race wrote: > +1 > > -phil. > > On 10/12/2016 08:04 AM, Sergey Bylokhov wrote: >> Looks fine.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6294607: GIFWriter returns the same compression type twice

2016-10-12 Thread Phil Race
convenience : http://cr.openjdk.java.net/~jdv/6294607/webrev.01/ Thanks, Jay *From:*Jayathirth D V *Sent:* Wednesday, October 05, 2016 12:23 PM *To:* Philip Race; 2d-dev *Subject:* RE: [OpenJDK 2D-Dev] [9] RFR JDK-6294607: GIFWriter returns the same compression type twice Hi Phil, I

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6294607: GIFWriter returns the same compression type twice

2016-10-12 Thread Sergey Bylokhov
/webrev.01/ Thanks, Jay *From:*Jayathirth D V *Sent:* Wednesday, October 05, 2016 12:23 PM *To:* Philip Race; 2d-dev *Subject:* RE: [OpenJDK 2D-Dev] [9] RFR JDK-6294607: GIFWriter returns the same compression type twice Hi Phil, I have verified all plugins only GIF has this duplication

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6294607: GIFWriter returns the same compression type twice

2016-10-06 Thread Jayathirth D V
Sent: Wednesday, October 05, 2016 12:23 PM To: Philip Race; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [9] RFR JDK-6294607: GIFWriter returns the same compression type twice Hi Phil, I have verified all plugins only GIF has this duplication problem. Thanks, Jay From: Phil Race Sent

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6294607: GIFWriter returns the same compression type twice

2016-10-05 Thread Jayathirth D V
Hi Phil, I have verified all plugins only GIF has this duplication problem. Thanks, Jay From: Phil Race Sent: Tuesday, October 04, 2016 9:54 PM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-6294607: GIFWriter returns the same compression type twice

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6294607: GIFWriter returns the same compression type twice

2016-10-04 Thread Phil Race
This seems fine to me. Perhaps the test could be reworked to look for any plugin that reports a duplicate compression type ? That may be more useful as a test .. Is this the only plugin that exhibits such duplication ? -phil. On 10/04/2016 04:39 AM, Jayathirth D V wrote: Hi, Please review