Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-23 Thread Sergey Bylokhov
Looks fine. On 18/09/2018 00:22, Laurent Bourgès wrote: Hi, Please could a second reviewer have a look ? Phil approved 2 weeks ago. I would like this bug done asap. I will propose for review the javafx patch (almost the same fix) in a moment. Cheers, Laurent Le mar. 11 sept. 2018 à 08:55,

Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-11 Thread Laurent Bourgès
Hi, Can I have a second review, please ? I would like to make a jdk11 updates fix request asap... Laurent Le jeu. 6 sept. 2018 à 09:31, Laurent Bourgès a écrit : > Phil, > Thanks for your review. > > Le jeu. 6 sept. 2018 à 01:39, Philip Race a > écrit : > >> This looks good to me. >> I've

Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-06 Thread Laurent Bourgès
Another reviewer, please ? Le jeu. 6 sept. 2018 à 18:59, Phil Race a écrit : > > > On 09/06/2018 12:31 AM, Laurent Bourgès wrote: > > Phil, > Thanks for your review. > > Le jeu. 6 sept. 2018 à 01:39, Philip Race a > écrit : > >> This looks good to me. >> I've run all our automated tests + done

Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-06 Thread Phil Race
On 09/06/2018 12:31 AM, Laurent Bourgès wrote: Phil, Thanks for your review. Le jeu. 6 sept. 2018 à 01:39, Philip Race > a écrit : This looks good to me. I've run all our automated tests + done some manual testing as well as building on all

Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-06 Thread Laurent Bourgès
Phil, Thanks for your review. Le jeu. 6 sept. 2018 à 01:39, Philip Race a écrit : > This looks good to me. > I've run all our automated tests + done some manual testing > as well as building on all platforms and reviewing the source changes. > Do you have more closed-source tests that could be

Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-05 Thread Philip Race
This looks good to me. I've run all our automated tests + done some manual testing as well as building on all platforms and reviewing the source changes. > PS: What is the process to ask for backport to JDK11 updates ? If you think this important enough to backport, then this is the process :