Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-23 Thread Sergey Bylokhov 

Looks fine.

On 18/09/2018 00:22, Laurent Bourgès wrote:

Hi,

Please could a second reviewer have a look ?
Phil approved 2 weeks ago.
I would like this bug done asap.

I will propose for review the javafx patch (almost the same fix) in a 
moment.


Cheers,
Laurent

Le mar. 11 sept. 2018 à 08:55, Laurent Bourgès 
mailto:bourges.laur...@gmail.com>> a écrit :


Hi,
Can I have a second review, please ?

I would like to make a jdk11 updates fix request asap...

Laurent

Le jeu. 6 sept. 2018 à 09:31, Laurent Bourgès
mailto:bourges.laur...@gmail.com>> a écrit :

Phil,
Thanks for your review.

Le jeu. 6 sept. 2018 à 01:39, Philip Race
mailto:philip.r...@oracle.com>> a écrit :

This looks good to me.
I've run all our automated tests + done some manual testing
as well as building on all platforms and reviewing the
source changes.


Do you have more closed-source tests that could be opened in
OpenJDK ?


  >  PS: What is the process to ask for backport to JDK11
updates ?

If you think this important enough to backport, then this is
the process :

http://openjdk.java.net/projects/jdk-updates/approval.html


I fixed these bugs as I was contacted on the Marlin mailing list
by an end user testing the migration of its Map viewer app from
jdk8 to OpenJDK11.

I made this patch as small as possible that is compatible with
OpenJDK 11/12 and is well tested: low risk.
For 12, I will propose a more important patch later to upgrade
to Marlin 0.9.3

As JDK11 is LTS and this bug is a regression (P3 ?) since 10, I
think it is worth fixing it in 11 too.

Any other opinion ?

PS: I will fix OpenJFX 11/12 soon

Cheers,
Laurent




--
Best regards, Sergey.

Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-11 Thread Laurent Bourgès 
Hi,
Can I have a second review, please ?

I would like to make a jdk11 updates fix request asap...

Laurent

Le jeu. 6 sept. 2018 à 09:31, Laurent Bourgès  a
écrit :

> Phil,
> Thanks for your review.
>
> Le jeu. 6 sept. 2018 à 01:39, Philip Race  a
> écrit :
>
>> This looks good to me.
>> I've run all our automated tests + done some manual testing
>> as well as building on all platforms and reviewing the source changes.
>>
>
> Do you have more closed-source tests that could be opened in OpenJDK ?
>
>>
>>  >  PS: What is the process to ask for backport to JDK11 updates ?
>>
>> If you think this important enough to backport, then this is the process :
>>
>> http://openjdk.java.net/projects/jdk-updates/approval.html
>
>
> I fixed these bugs as I was contacted on the Marlin mailing list by an end
> user testing the migration of its Map viewer app from jdk8 to OpenJDK11.
>
> I made this patch as small as possible that is compatible with OpenJDK
> 11/12 and is well tested: low risk.
> For 12, I will propose a more important patch later to upgrade to Marlin
> 0.9.3
>
> As JDK11 is LTS and this bug is a regression (P3 ?) since 10, I think it
> is worth fixing it in 11 too.
>
> Any other opinion ?
>
> PS: I will fix OpenJFX 11/12 soon
>
> Cheers,
> Laurent
>

Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-06 Thread Laurent Bourgès 
Another reviewer, please ?

Le jeu. 6 sept. 2018 à 18:59, Phil Race  a écrit :

>
>
> On 09/06/2018 12:31 AM, Laurent Bourgès wrote:
>
> Phil,
> Thanks for your review.
>
> Le jeu. 6 sept. 2018 à 01:39, Philip Race  a
> écrit :
>
>> This looks good to me.
>> I've run all our automated tests + done some manual testing
>> as well as building on all platforms and reviewing the source changes.
>>
>
> Do you have more closed-source tests that could be opened in OpenJDK ?
>
>
>
> I ran the closed source tests not because there were critical tests there
> so much
> as it would be stupid not to when it is easier than not running them :-)
>
> There are still many client closed source test that could be open sourced
> although
> only a tiny fraction might be applicable here. We open source these as we
> find time ..
>
>
>
>>  >  PS: What is the process to ask for backport to JDK11 updates ?
>>
>> If you think this important enough to backport, then this is the process :
>>
>> http://openjdk.java.net/projects/jdk-updates/approval.html
>
>
> I fixed these bugs as I was contacted on the Marlin mailing list by an end
> user testing the migration of its Map viewer app from jdk8 to OpenJDK11.
>
> I made this patch as small as possible that is compatible with OpenJDK
> 11/12 and is well tested: low risk.
> For 12, I will propose a more important patch later to upgrade to Marlin
> 0.9.3
>
> As JDK11 is LTS and this bug is a regression (P3 ?) since 10, I think it
> is worth fixing it in 11 too.
>
> Any other opinion ?
>
>
> I am fine with it. But it is the 11 updates maintainers who need to
> approve.
>
> -phil.
>
>
> PS: I will fix OpenJFX 11/12 soon
>
> Cheers,
> Laurent
>
>
>

Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-06 Thread Phil Race 



On 09/06/2018 12:31 AM, Laurent Bourgès wrote:

Phil,
Thanks for your review.

Le jeu. 6 sept. 2018 à 01:39, Philip Race > a écrit :


This looks good to me.
I've run all our automated tests + done some manual testing
as well as building on all platforms and reviewing the source changes.


Do you have more closed-source tests that could be opened in OpenJDK ?



I ran the closed source tests not because there were critical tests 
there so much

as it would be stupid not to when it is easier than not running them :-)

There are still many client closed source test that could be open 
sourced although
only a tiny fraction might be applicable here. We open source these as 
we find time ..





 >  PS: What is the process to ask for backport to JDK11 updates ?

If you think this important enough to backport, then this is the
process :

http://openjdk.java.net/projects/jdk-updates/approval.html


I fixed these bugs as I was contacted on the Marlin mailing list by an 
end user testing the migration of its Map viewer app from jdk8 to 
OpenJDK11.


I made this patch as small as possible that is compatible with OpenJDK 
11/12 and is well tested: low risk.
For 12, I will propose a more important patch later to upgrade to 
Marlin 0.9.3


As JDK11 is LTS and this bug is a regression (P3 ?) since 10, I think 
it is worth fixing it in 11 too.


Any other opinion ?


I am fine with it. But it is the 11 updates maintainers who need to approve.

-phil.



PS: I will fix OpenJFX 11/12 soon

Cheers,
Laurent

Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-06 Thread Laurent Bourgès 
Phil,
Thanks for your review.

Le jeu. 6 sept. 2018 à 01:39, Philip Race  a écrit :

> This looks good to me.
> I've run all our automated tests + done some manual testing
> as well as building on all platforms and reviewing the source changes.
>

Do you have more closed-source tests that could be opened in OpenJDK ?

>
>  >  PS: What is the process to ask for backport to JDK11 updates ?
>
> If you think this important enough to backport, then this is the process :
>
> http://openjdk.java.net/projects/jdk-updates/approval.html


I fixed these bugs as I was contacted on the Marlin mailing list by an end
user testing the migration of its Map viewer app from jdk8 to OpenJDK11.

I made this patch as small as possible that is compatible with OpenJDK
11/12 and is well tested: low risk.
For 12, I will propose a more important patch later to upgrade to Marlin
0.9.3

As JDK11 is LTS and this bug is a regression (P3 ?) since 10, I think it is
worth fixing it in 11 too.

Any other opinion ?

PS: I will fix OpenJFX 11/12 soon

Cheers,
Laurent

Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-05 Thread Philip Race 

This looks good to me.
I've run all our automated tests + done some manual testing
as well as building on all platforms and reviewing the source changes.

>  PS: What is the process to ask for backport to JDK11 updates ?

If you think this important enough to backport, then this is the process :

http://openjdk.java.net/projects/jdk-updates/approval.html


-phil.


On 9/4/18, 1:45 PM, Laurent Bourgès wrote:

Please review this bug fix for the Marlin renderer (introduced in 10):
JBS: https://bugs.openjdk.java.net/browse/JDK-8210335
webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8210335.0/ 



Changes:
- clipping rectangle is adjusted to take into account the inverse 
transform (scale/shear)
- MarlinRenderingEngine: prepare once the clip with small margin + 
renderer offset

- TransformingPathConsumer2D:
- missing min < max in adjustClipScale() if scale < 0
   - compute mean inverse scale factor to be used in CurveClipSplitter 
to perform proper length checks to avoid too many subdivision


PS: What is the process to ask for backport to JDK11 updates ?

Cheers,
Laurent