Re: [389-devel] Please Review: Managed Entries Plug-in

2010-03-31 Thread Nathan Kinder
On 03/30/2010 03:44 PM, Rich Megginson wrote: Nathan Kinder wrote: New patch attached. Nice! Thanks for the review! mep.c:491 - value is not freed if it is not a valid filter - also would be nice to have the error message print value to show what the bogus filter is

Re: [389-devel] Please Review: Managed Entries Plug-in

2010-03-31 Thread Rich Megginson
Nathan Kinder wrote: On 03/30/2010 03:44 PM, Rich Megginson wrote: Nathan Kinder wrote: New patch attached. Nice! Thanks for the review! mep.c:491 - value is not freed if it is not a valid filter - also would be nice to have the error message

Re: [389-devel] Please Review: Managed Entries Plug-in

2010-03-30 Thread Noriko Hosoi
(2010?03?30? 13:56), Nathan Kinder wrote: New patch attached. Ack. --noriko -NGK On 03/30/2010 01:24 PM, Nathan Kinder wrote: Please hold off on the review. I noticed one other thing that I need to address. A new patch will be sent out shortly. -NGK On 03/30/2010 01:18 PM, Nathan