Re: [389-devel] Please review: fix compiler warning
On 11/03/2015 10:42 AM, Martin Basti wrote: On 03.11.2015 19:30, Noriko Hosoi wrote: Thanks for your patch, Martin. Looks good to me. "ack". Which version is your patch supposed to be in? Just master is fine? --noriko Thank you, master is fine. Pushed to master: aff9705..0d1ce9d master -> master commit 0d1ce9de608d582ea2ca0f5e48fe2f2213f0b683 Author: Martin Basti Date: Tue Nov 3 17:32:53 2015 +0100 Add 'void' to function definition to avoid compiler warnings Thanks! --noriko Martin On 11/03/2015 10:24 AM, Martin Basti wrote: Hello all, the gcc compiler returns warning during compiling of the freeIPA project: slapi-plugin.h:6149, GNU C Compiler 4 (gcc), Priority: Normal function declaration isn't a prototype [-Wstrict-prototypes] 6149 int slapi_rwlock_get_size(); Attached patch should fix the issue. Thank you, Martin. -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel
Re: [389-devel] Please review: fix compiler warning
On 03.11.2015 19:30, Noriko Hosoi wrote: Thanks for your patch, Martin. Looks good to me. "ack". Which version is your patch supposed to be in? Just master is fine? --noriko Thank you, master is fine. Martin On 11/03/2015 10:24 AM, Martin Basti wrote: Hello all, the gcc compiler returns warning during compiling of the freeIPA project: slapi-plugin.h:6149, GNU C Compiler 4 (gcc), Priority: Normal function declaration isn't a prototype [-Wstrict-prototypes] 6149 int slapi_rwlock_get_size(); Attached patch should fix the issue. Thank you, Martin. -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel
Re: [389-devel] Please review: fix compiler warning
Thanks for your patch, Martin. Looks good to me. "ack". Which version is your patch supposed to be in? Just master is fine? --noriko On 11/03/2015 10:24 AM, Martin Basti wrote: Hello all, the gcc compiler returns warning during compiling of the freeIPA project: slapi-plugin.h:6149, GNU C Compiler 4 (gcc), Priority: Normal function declaration isn't a prototype [-Wstrict-prototypes] 6149 int slapi_rwlock_get_size(); Attached patch should fix the issue. Thank you, Martin. -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel
[389-devel] Please review: fix compiler warning
Hello all,
the gcc compiler returns warning during compiling of the freeIPA project:
slapi-plugin.h:6149, GNU C Compiler 4 (gcc), Priority: Normal
function declaration isn't a prototype [-Wstrict-prototypes]
6149 int slapi_rwlock_get_size();
Attached patch should fix the issue.
Thank you, Martin.
From edcf41f111270ff4655b4b771c9fedc0a315cfed Mon Sep 17 00:00:00 2001
From: Martin Basti
Date: Tue, 3 Nov 2015 17:32:53 +0100
Subject: [PATCH] Add 'void' to function definition to avoid compiler warnings
During compiling of FreeIPA we are receiving compiler error:
slapi-plugin.h:6149, GNU C Compiler 4 (gcc), Priority: Normal
function declaration isn't a prototype [-Wstrict-prototypes]
This patch should fix the compiler warning.
---
ldap/servers/slapd/slapi-plugin.h | 2 +-
ldap/servers/slapd/slapi2nspr.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ldap/servers/slapd/slapi-plugin.h b/ldap/servers/slapd/slapi-plugin.h
index 72f3920fb10979e1670e8fd354364def8c281646..d2b076b45c2a2d7d9dff4696c6fb7821fbc42175 100644
--- a/ldap/servers/slapd/slapi-plugin.h
+++ b/ldap/servers/slapd/slapi-plugin.h
@@ -6146,7 +6146,7 @@ int slapi_rwlock_unlock( Slapi_RWLock *rwlock );
*
* \return the size of Slapi_RWLock
*/
-int slapi_rwlock_get_size();
+int slapi_rwlock_get_size( void );
/*
* thread-safe LDAP connections
diff --git a/ldap/servers/slapd/slapi2nspr.c b/ldap/servers/slapd/slapi2nspr.c
index 4bd88fef6163b6351d2d336c7d9df8c8be007481..1bfb3069b47f9534194e502054862a266edd2e83 100644
--- a/ldap/servers/slapd/slapi2nspr.c
+++ b/ldap/servers/slapd/slapi2nspr.c
@@ -261,7 +261,7 @@ slapi_rwlock_unlock( Slapi_RWLock *rwlock )
}
int
-slapi_rwlock_get_size()
+slapi_rwlock_get_size( void )
{
#ifdef USE_POSIX_RWLOCKS
return sizeof(pthread_rwlock_t);
--
2.4.3
--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel
Re: [389-devel] Please review ticket 47976: deadlock in mep delete post op
Hi Thierry, we already had started to discuss on IRC, but here are my thoughts again. Is it necessary to explicitely set the txn in the plugin ? The txn will be found when ldbm_back_delete() does dblayer_txn_begin(9 and it checks the per thread stack of txns. In my opinion the real problem is not to set the txn in id2entry, which will then try to read a locked page. Ludwig On 11/03/2015 05:40 PM, thierry bordaz wrote: ticket https://fedorahosted.org/389/ticket/47976 fix https://fedorahosted.org/389/attachment/ticket/47976/0001-Ticket-47976-deadlock-in-mep-delete-post-op.patch test case: https://fedorahosted.org/389/attachment/ticket/47976/0002-Ticket-47976-test-case.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel
[389-devel] Please review ticket 47976: deadlock in mep delete post op
ticket https://fedorahosted.org/389/ticket/47976 fix https://fedorahosted.org/389/attachment/ticket/47976/0001-Ticket-47976-deadlock-in-mep-delete-post-op.patch test case: https://fedorahosted.org/389/attachment/ticket/47976/0002-Ticket-47976-test-case.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel
