[389-devel] Re: Prereview for ticket #48402 , required by ticket #48380 SynRepl does not handle database re-initialization properly
On 01/13/2016 02:34 PM, Mark Reynolds wrote: On 01/13/2016 10:01 AM, Ludwig Krispenz wrote: Ticket 48380 requires that sync repl handles database reinitializations properly, to be able to determine if cookies are presented are valid. To achieve this plugins need to be able to detcet if the database is imported or restored and this is tarcked in ticket 48402. Before implementing a fix, I would like to get feedback on the design: http://www.port389.org/docs/389ds/design/detect-startup-after-import-or-restore.html The design looks good to me. I really like the use of the "db event" file(like the guardian file). +1 I also think it's nicely designed. 2 questions... Who deletes the file and at what timing? If the file failed to be created or is deleted manually, what happens? Thanks! --noriko Thanks, Ludwig -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org
[389-devel] Re: Prereview for ticket #48402 , required by ticket #48380 SynRepl does not handle database re-initialization properly
On Wed, 2016-01-13 at 17:34 -0500, Mark Reynolds wrote: > > On 01/13/2016 10:01 AM, Ludwig Krispenz wrote: > > Ticket 48380 requires that sync repl handles database > > reinitializations properly, to be able to determine if cookies are > > presented are valid. > > To achieve this plugins need to be able to detcet if the database > > is > > imported or restored and this is tarcked in ticket 48402. > > > > Before implementing a fix, I would like to get feedback on the > > design: > > http://www.port389.org/docs/389ds/design/detect-startup-after-impor > > t-or-restore.html > The design looks good to me. I really like the use of the "db > event" > file(like the guardian file). I really like the simplicity of this. It's very elegant. With the startup check for restore and import, why not make both of them have the same flag setting mechanism in the backend? Rather than one setting a global variable and one setting a be flag? -- Sincerely, William Brown Software Engineer Red Hat, Brisbane signature.asc Description: This is a digitally signed message part -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org
[389-devel] Re: Prereview for ticket #48402 , required by ticket #48380 SynRepl does not handle database re-initialization properly
On 01/13/2016 10:01 AM, Ludwig Krispenz wrote: Ticket 48380 requires that sync repl handles database reinitializations properly, to be able to determine if cookies are presented are valid. To achieve this plugins need to be able to detcet if the database is imported or restored and this is tarcked in ticket 48402. Before implementing a fix, I would like to get feedback on the design: http://www.port389.org/docs/389ds/design/detect-startup-after-import-or-restore.html The design looks good to me. I really like the use of the "db event" file(like the guardian file). Thanks, Ludwig -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org
[389-devel] Prereview for ticket #48402 , required by ticket #48380 SynRepl does not handle database re-initialization properly
Ticket 48380 requires that sync repl handles database reinitializations properly, to be able to determine if cookies are presented are valid. To achieve this plugins need to be able to detcet if the database is imported or restored and this is tarcked in ticket 48402. Before implementing a fix, I would like to get feedback on the design: http://www.port389.org/docs/389ds/design/detect-startup-after-import-or-restore.html Thanks, Ludwig -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org
[389-devel] Please review: Ticket 48341
Hi, to have my suggestion discussed by a wider audience, please have a look: https://fedorahosted.org/389/ticket/48341 https://fedorahosted.org/389/attachment/ticket/48341/0001-Ticket-48341-deadlock-on-connection-mutex.patch Ludwig -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org