Re: [389-devel] Please Review: Managed Entries Plug-in

2010-03-31 Thread Nathan Kinder
On 03/30/2010 03:44 PM, Rich Megginson wrote: Nathan Kinder wrote: New patch attached. Nice! Thanks for the review! mep.c:491 - value is not freed if it is not a valid filter - also would be nice to have the error message print value to show what the bogus filter is

Re: [389-devel] Please Review: Managed Entries Plug-in

2010-03-31 Thread Rich Megginson
Nathan Kinder wrote: On 03/30/2010 03:44 PM, Rich Megginson wrote: Nathan Kinder wrote: New patch attached. Nice! Thanks for the review! mep.c:491 - value is not freed if it is not a valid filter - also would be nice to have the error message

Re: [389-devel] Please Review: Fix parsing of start-slapd scripts

2010-03-31 Thread Endi Sukma Dewata
- Nathan Kinder nkin...@redhat.com wrote: The admin server CGIs parse the start-slapd scripts to determine the DS instance names. A recent format change to start-slapd caused this parsing to break. These patches make the instance name easier to parse from the script. One patch is