[389-devel] please review: Ticket 47627 - changelog iteration should ignore cleaned rids when getting the minCSN

2013-12-11 Thread Mark Reynolds

https://fedorahosted.org/389/ticket/47627

https://fedorahosted.org/389/attachment/ticket/47627/0001-Ticket-47627-changelog-iteration-should-ignore-clean.patch

--
Mark Reynolds
389 Development Team
Red Hat, Inc
mreyno...@redhat.com

--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] please review: Ticket 47601 - Plugin library path validation prevents intentional loading of out-of-tree modules

2013-12-11 Thread Mark Reynolds

autogen.sh still needs to be run for this patch...

https://fedorahosted.org/389/ticket/47601

https://fedorahosted.org/389/attachment/ticket/47601/0001-Ticket-47601-Plugin-library-path-validation-prevents.patch

--
Mark Reynolds
389 Development Team
Red Hat, Inc
mreyno...@redhat.com

--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] please review: Ticket 47617 - allow configuring changelog trim interval

2013-12-11 Thread Mark Reynolds

https://fedorahosted.org/389/ticket/47617

https://fedorahosted.org/389/attachment/ticket/47617/0001-Ticket-47617-allow-configuring-changelog-trim-interv.patch

--
Mark Reynolds
389 Development Team
Red Hat, Inc
mreyno...@redhat.com

--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: [389 Project] #47606: replica init/bulk import errors should be more verbose

2013-12-11 Thread David Boreham

On 12/11/2013 7:08 PM, Noriko Hosoi wrote:

https://fedorahosted.org/389/ticket/47606

https://fedorahosted.org/389/attachment/ticket/47606/0001-Ticket-47606-replica-init-bulk-import-errors-should-.patch 



Looks good to me. Pitty about the struct definition accessibility -- 
presumably that's an openldap-devel limitation...


The only suggestion I'd have would be to put the length extraction code 
in a function, in another source file, to keep connection.c slightly 
cleaner.



--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel