[389-devel] Re: Please review 48992: Total init may fail if the pushed schema is rejected

2016-09-23 Thread Ludwig Krispenz
Hi Thierry, the description in the commit is now fine, but given that the choice of LDAP_CONSTRAINT_VIOLATION is a bit arbitrary it would be good to have a comment where it is set, explaining why this error code was used. About which error code to choose, if you have to pick one of the errors

[389-devel] Please review 48992: Total init may fail if the pushed schema is rejected

2016-09-23 Thread thierry bordaz
Thanks Noriko for your review. I updated the patch to give more explanation why the fix is in modify_schema_dse. I pick up LDAP_CONSTRAINT_VIOLATION in replacement of UNWILLING_TO_PERFORM but I have not strong opinion on appropriate value of that returned value. In the logic of that fix, it