[389-devel] Re: Optional rust support review

2017-11-09 Thread William Brown 
On Wed, 2017-11-08 at 09:53 +0100, thierry bordaz wrote:
> Hi William,
> 
> I see benefit to offer the support of modern language in 389-ds.
> Rust developer can be interested to improve 389-DS with missing
> functionality.
> Especially with the plugin-api we have the ability to support
> rust
> without change to the core server. If a rust plugin hit a bug, we
> have the ability to disable it until a rust expert can fix it.
> #49325 implements rust functionality into a crucial core server
> component (nunc stans). The consequence is that we do need to be
> able to fix it rapidly. Correct ?

This is an optional replacement of the threadsafe queue. We already
have a C version that's used in production. So if we hit a bug in the
rust version, we already have a tried-and-tested C version to revert
back to :) So we are not in a rush to "fix" it if we find an issue. 

As well, rust is not "enabled-by-default" in this patch - that's a
different decision.

This is to say "we can optionally include pieces" today. We can still
back out :) 

> 
> best regards
> thierry
> 
> 
> On 11/07/2017 03:51 AM, William Brown wrote:
> > Hi,
> > 
> > https://pagure.io/389-ds-base/issue/49325 has been in a ready to
> > merge
> > state for some time. This is still an optional integration (not a
> > commitment to production rust), but I still want to check that it's
> > okay to merge. It's been reviewed by an external Rust developer who
> > is
> > happy with it, and checked by Mark. I would like to merge this on
> > Friday, so I would love to hear comments about this before then.
> > 
> > A discussion on production commitment will happen in the near
> > future I
> > think as to whether we want to pursue this path,
> > 
> > Thanks!
> > 
> > 
> > 
> > ___
> > 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> > To unsubscribe send an email to 389-devel-leave@lists.fedoraproject
> > .org
> 
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-leave@lists.fedoraproject.o
> rg
-- 
Sincerely,

William Brown
Software Engineer
Red Hat, Australia/Brisbane


signature.asc
Description: This is a digitally signed message part
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: 3 paged results test

2017-11-09 Thread William Brown 
https://pagure.io/lib389/issue/3

https://pagure.io/lib389/issue/raw/files/7c318055f214209bbbc35698c0adfb
29feae2309ce5923510f88a9f468052aee-0001-Ticket-3-lib389-python-3-
compat-for-paged-results-te.patch

-- 
Sincerely,

William Brown
Software Engineer
Red Hat, Australia/Brisbane


signature.asc
Description: This is a digitally signed message part
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review 49445

2017-11-09 Thread William Brown 
https://pagure.io/389-ds-base/issue/49445


https://pagure.io/389-ds-base/issue/raw/files/36a318a31567a9bda1f61d6d8
09f0483f043266c1326831c867d7ddb61eb7ad2-0001-Ticket-49445-Memory-leak-
in-ldif2db.patch


-- 
Sincerely,

William Brown
Software Engineer
Red Hat, Australia/Brisbane


signature.asc
Description: This is a digitally signed message part
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review 49444 huaf in task.c

2017-11-09 Thread William Brown 
https://pagure.io/389-ds-base/issue/49444

https://pagure.io/389-ds-base/issue/raw/files/769d447097ac633ea0bcc7cd6
3ddc83f7ec3d2dcc0daba9f77ebaa45b80fc7de-0001-Ticket-49444-huaf-in-
task.c-during-high-load-import.patch



-- 
Sincerely,

William Brown
Software Engineer
Red Hat, Australia/Brisbane


signature.asc
Description: This is a digitally signed message part
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please Review: Issue 3 - Python 3 compatibility

2017-11-09 Thread Amita Sharma 
Hello,

Please review my patch for memberof_plugin tests

https://pagure.io/lib389/issue/3

https://pagure.io/lib389/issue/raw/files/1311ab7378f555a12fafb39acc2c507155d0ef65d7751ec2d47bd8f5871b0964-0001-Ticket-lib389-Python-3-support-for-memberof-plugin-t.patch


Thanks & Regards,
Amita
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Ticket 49443: scope one searches in 1.3.7 give incorrect results

2017-11-09 Thread Ludwig Krispenz 

https://pagure.io/389-ds-base/issue/49443
https://pagure.io/389-ds-base/issue/raw/files/cdc2c0bf853fbc119c61befc5496efe73845353f1b86365eb70f605d5fc214e5-0001-Ticket-49443-scope-one-searches-in-1.3.7-give-incorr.patch

Note: the testcase passes in master, but I think it is masked by another 
filter optimisation and this fix should be applied to master as well.


--
Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael Cunningham, Michael O'Neill, Eric 
Shander
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org