Re: [389-devel] please review: Ticket 48233 - Server crashes during shutdown if ACIs contain IP address restrictions

2015-08-18 Thread Simon Pichugin
Hi Mark, it is the pretty good written testcase. But there is one thing you can improve. (commit was pushed, so this is for the future) Instead of this: {{{ if not entries: log.fatal('Failed return an entries from search') assert False }}} You can write like this: {{{ assert entries,

[389-devel] revised: Ticket 48251 - Improve the basic test suite

2015-08-20 Thread Simon Pichugin
https://fedorahosted.org/389/attachment/ticket/48251/0001-Ticket-48251-Improve-the-basic-test-suite.2.patch https://fedorahosted.org/389/ticket/48251 -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket 48303 - Fix lib389 broken tests

2015-10-23 Thread Simon Pichugin
Hi team, I finished with fixing broken lib389 test suites. I united the rest of the patches, that wasn't commited, to the one patch. Please, review it. I am going to the PTO for a next week and after that I will deal with your review result. https://fedorahosted.org/389/ticket/48303

[389-devel] DSAdmin tests and basic functionality in the lib389

2015-10-19 Thread Simon Pichugin
Hi team, I am working now on the fixing lib389 broken tests: https://fedorahosted.org/389/ticket/48303 And it's time for dsadmin_* tests. Can anybody, please, tell me more about it? As I see, Mark and Thierry worked on it, but any other team members are welcomed too. :) I have a few questions:

Re: [389-devel] DSAdmin tests and basic functionality in the lib389

2015-10-19 Thread Simon Pichugin
, thierry bordaz wrote: > On 10/19/2015 04:18 PM, Mark Reynolds wrote: > > > > > >On 10/19/2015 10:02 AM, Simon Pichugin wrote: > >>Hi team, > >> > >>I am working now on the fixing lib389 broken tests: > >>https://fedorahosted.org/389/ticket/4830

[389-devel] Please review: Ticket 48303 - Fix lib389 broken tests - effective_rights_test

2015-10-19 Thread Simon Pichugin
Hi team, please review my new patch and new version of the old one. https://fedorahosted.org/389/ticket/48303 https://fedorahosted.org/389/attachment/ticket/48303/0001-Ticket-48303-Fix-lib389-broken-tests-dereference_tes.patch

[389-devel] Please review: Ticket 48303 - Fix lib389 broken tests - aci_parce and agreement

2015-10-08 Thread Simon Pichugin
Hi team, I've started to work on the fixing lib389 broken test suites task. Please, review my patches for aci_parce and agreement test suites. https://fedorahosted.org/389/ticket/48303

[389-devel] Please review: Ticket 48318 - Do not delete a changelog while disabling a replication by suffix

2015-10-21 Thread Simon Pichugin
https://fedorahosted.org/389/ticket/48318 https://fedorahosted.org/389/attachment/ticket/48318/0001-Ticket-48318-Do-not-delete-a-changelog-while-disabli.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Git rights for QE team

2015-10-09 Thread Simon Pichugin
through ssh protocol on our repository. Kind regards, Simon On Fri, Oct 09, 2015 at 12:04:50PM +0200, Simon Pichugin wrote: > Hi Nathan, > Hi team, > > Problem stays the same. Also I have the same error in the lib389 > repository, while pushing. > > May be I do

[389-devel] please review: Ticket #47761 - Added a few testcases to the basic testsuite

2015-08-31 Thread Simon Pichugin
https://fedorahosted.org/389/ticket/47761 https://fedorahosted.org/389/attachment/ticket/47761/0001-Ticket-47761-Added-a-few-testcases-to-the-basic-test.patch pgpVn35mvin4Z.pgp Description: PGP signature -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] please review: Ticket #47553 - Automated the verification procedure

2015-09-02 Thread Simon Pichugin
https://fedorahosted.org/389/ticket/47553 https://fedorahosted.org/389/attachment/ticket/47553/0001-Ticket-47553-Automated-the-verification-procedure.patch pgpP9S0Ua1jWm.pgp Description: PGP signature -- 389-devel mailing list 389-devel@lists.fedoraproject.org

Re: [389-devel] Please review: [389 Project] #48265: Complex filter in a search request doen't work as expected. (regression)

2015-09-04 Thread Simon Pichugin
Hi Noriko, On Thu, Sep 03, 2015 at 10:27:27AM -0700, Noriko Hosoi wrote: > https://fedorahosted.org/389/ticket/48265 > > https://fedorahosted.org/389/attachment/ticket/48265/0001-Ticket-48265-Complex-filter-in-a-search-request-doen.patch > git patch file (master) > >

Re: [389-devel] please review: Ticket #47761 - Added a few testcases to the basic testsuite

2015-09-14 Thread Simon Pichugin
Hi team, please, review my patch. :) On Mon, Aug 31, 2015 at 11:32:22AM +0200, Simon Pichugin wrote: > https://fedorahosted.org/389/ticket/47761 > > https://fedorahosted.org/389/attachment/ticket/47761/0001-Ticket-47761-Added-a-few-testcases-to-the-basic-test.patch > -- > 38

Re: [389-devel] please review (revised): Ticket #47761 - Added a few testcases to the basic testsuite

2015-09-15 Thread Simon Pichugin
Hi team, please, review my revised patch. https://fedorahosted.org/389/ticket/47761 https://fedorahosted.org/389/attachment/ticket/47761/0001-Ticket-47761-Added-a-few-testcases-to-the-basic-test.2.patch On Mon, Sep 14, 2015 at 02:28:29PM +0200, Simon Pichugin wrote: > Hi team, > &g

Re: [389-devel] please review (revised): Ticket #47553 - Automated the verification procedure

2015-09-15 Thread Simon Pichugin
Hi team, please, review my slightly revised patch. Python 2 > Python 3 fix. https://fedorahosted.org/389/ticket/47553 https://fedorahosted.org/389/attachment/ticket/47553/0001-Ticket-47553-Automated-the-verification-procedure.2.patch On Wed, Sep 02, 2015 at 05:50:50PM +0200, Simon Pichu

[389-devel] please review: Ticket 47957 - Add replication test suite for a wait async feature

2015-09-15 Thread Simon Pichugin
Hi team, please, review my patch that contains new test suite for the nsDS5ReplicaWaitForAsyncResults feature. https://fedorahosted.org/389/ticket/47957 https://fedorahosted.org/389/attachment/ticket/47957/0001-Ticket-47957-Add-replication-test-suite-for-a-wait-a.patch pgpzJTmzMDwn_.pgp

Re: [389-devel] Git rights for QE team

2015-09-23 Thread Simon Pichugin
Hi Nathan, On Wed, Sep 23, 2015 at 07:31:41AM -0700, Nathan Kinder wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > > > On 09/23/2015 01:38 AM, Simon Pichugin wrote: > > Hi Nathan, Hi Mark, Hi team, > > > > as I know, we've decide

[389-devel] Git rights for QE team

2015-09-23 Thread Simon Pichugin
Hi Nathan, Hi Mark, Hi team, as I know, we've decided to make me "gatekeeper" of QE team for managing lib389 and DS git repos. Can you please update the status of this situation? Also, there is two tickets with new reviewed testcases, that need to be pushed. Can you please help me with that? Or

[389-devel] please review: Ticket 48264 - Ticket 47553 tests refactoring

2015-09-18 Thread Simon Pichugin
Hi team, please review my refactoring patch. There is not much PEP8 refactor, mostly I just refactored it to the pytest structure. Some testcases were united into one, because they contained obvious big repetitions. https://fedorahosted.org/389/ticket/48264

[389-devel] Re: Please Review: Ticket 48360 - Refactor the delete agreement function

2015-11-27 Thread Simon Pichugin
Revision with new feature. https://fedorahosted.org/389/ticket/48360 https://fedorahosted.org/389/attachment/ticket/48360/0001-Ticket-48360-Refactor-the-delete-agreement-function-2.patch On Thu, Nov 26, 2015 at 05:16:59PM +0100, Simon Pichugin wrote: > Hi team, > > please, review

[389-devel] Please Review: Ticket 48364 - Fix test failures

2015-11-30 Thread Simon Pichugin
Hi team, I've prepared a patch for troubleshooting lib389 test failures. Please, review. https://fedorahosted.org/389/ticket/48364 https://fedorahosted.org/389/attachment/ticket/48364/0001-Ticket-48364-Fix-test-failures.patch -- 389-devel mailing list 389-devel@%(host_name)s

[389-devel] Re: Please Review: Ticket 48360 - Refactor the delete agreement function

2015-11-30 Thread Simon Pichugin
Fix the bug with bad indention. Added comment about missing test cases. https://fedorahosted.org/389/ticket/48360 https://fedorahosted.org/389/attachment/ticket/48360/0001-Ticket-48360-Refactor-the-delete-agreement-function-2.2.patch On Fri, Nov 27, 2015 at 04:42:27PM +0100, Simon Pichugin

[389-devel] Attention required: Ticket 48368 - Resolve the py.test conflicts with the create_test.py issue

2015-12-01 Thread Simon Pichugin
Hi team, your attention is required there. Please, take a look and help with a decision. https://fedorahosted.org/389/ticket/48368 Thanks, Simon -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Ticket 48798 - CI and lib389 tests fail

2016-06-08 Thread Simon Pichugin
Hi William, I troubleshoot failures at the tickets. And both tickets/ticket48798_test.py and lib389/tests/nss_ssl_test.py fail because of the same problem. As I understand this is because of class design issue (lib389/nss_ssl.py). Can you please take a look? May be you've already faced that

[389-devel] Ticket 48326 - Move CI test to config test suite and refactor

2016-06-08 Thread Simon Pichugin
Hi team, please review: https://fedorahosted.org/389/ticket/48326 https://fedorahosted.org/389/attachment/ticket/48326/0001-Ticket-48326-Move-CI-test-to-config-test-suite-and-r.patch Thanks, Simon signature.asc Description: PGP signature -- 389-devel mailing list

[389-devel] Re: Ticket 48798 - CI and lib389 tests fail

2016-06-10 Thread Simon Pichugin
200, Simon Pichugin wrote: > > Hi William, > > > > On Thu, Jun 09, 2016 at 10:12:29AM +1000, William Brown wrote: > > > > > > On Wed, 2016-06-08 at 17:52 +0200, Simon Pichugin wrote: > > > > > > > > Hi William, > > > >

[389-devel] Re: Ticket 48798 - CI and lib389 tests fail

2016-06-09 Thread Simon Pichugin
Hi William, On Thu, Jun 09, 2016 at 10:12:29AM +1000, William Brown wrote: > On Wed, 2016-06-08 at 17:52 +0200, Simon Pichugin wrote: > > Hi William, > > > > I troubleshoot failures at the tickets. > > And both tickets/ticket48798_test.py and lib389/tests/nss_s

[389-devel] Please review: Ticket 48832 - CI test - fix ticket failures

2016-06-13 Thread Simon Pichugin
Hi team, please, review my new patch: https://fedorahosted.org/389/ticket/48832 https://fedorahosted.org/389/attachment/ticket/48832/0001-Ticket-48832-CI-test-fix-ticket-failures.patch Thanks, Simon signature.asc Description: PGP signature -- 389-devel mailing list

[389-devel] SASL/EXTERNAL bind mech issue

2016-02-15 Thread Simon Pichugin
=Default City, O=example.com, CN=simon pichugin/emailAddress=spich...@redhat.com After that certificate was imported to "userCertificate" attr of our user (I've cut the attr output): # spichugin, People, example.com dn: uid=spichugin,ou=People,dc=example,dc=com mail: spich...@redhat.com uid:

[389-devel] Add test coverage module for lib389 repo

2016-02-15 Thread Simon Pichugin
Hi team, speaking about coverage module. Please, join the discussion. https://fedorahosted.org/389/ticket/48407#comment:3 Thanks, Simon -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Re: Add test coverage module for lib389 repo

2016-02-16 Thread Simon Pichugin
Hi team, please, review new comments: https://fedorahosted.org/389/ticket/48407 and patch: https://fedorahosted.org/389/attachment/ticket/48407/0001-Ticket-48407-Add-test-coverage-module-for-lib389-rep.patch Thanks, Simon On Mon, Feb 15, 2016 at 05:37:02PM +0100, Simon Pichugin wrote: >

[389-devel] Ticket 48661 - Agreement test suite fails at the test_changes case

2016-02-16 Thread Simon Pichugin
Hi team, please, review patch. https://fedorahosted.org/389/ticket/48661 https://fedorahosted.org/389/attachment/ticket/48661/0001-Ticket-48661-Agreement-test-suite-fails-at-the-test_.patch Thanks, Simon -- 389-devel mailing list 389-devel@%(host_name)s

[389-devel] Test coverage plugin for pytest

2016-02-18 Thread Simon Pichugin
Hi team, we need some module that will show us how much lines of code is covered by tests. We can use pytest-cov plugin for this. For starters, it works only on lib389 repo. But we need to figure out the way to measure a coverage for our 389-ds the C code base too. To get it work we need: 1)

[389-devel] Re: Please review 48751 lib389 improve ldapi support

2016-03-08 Thread Simon Pichugin
Hi team! Please, review the urgent patch. https://fedorahosted.org/389/ticket/48751 https://fedorahosted.org/389/attachment/ticket/48751/0001-Ticket-48751-Clean-up-_constants.py-after-previous-p.patch Thanks, Simon On Thu, Mar 03, 2016 at 10:43:45AM +1000, William Brown wrote: >

[389-devel] Please review: Ticket 48368 - Resolve the py.test conflicts with the create_test.py issue

2016-03-04 Thread Simon Pichugin
Hi team, please, review my restructuring change (dirsrvtests). https://fedorahosted.org/389/ticket/48368 https://fedorahosted.org/389/ticket/48368#comment:7 Thanks, Simon signature.asc Description: PGP signature -- 389-devel mailing list 389-devel@%(host_name)s

[389-devel] Re: Please review: Outstand reviews

2016-05-03 Thread Simon Pichugin
On Tue, May 03, 2016 at 02:47:27PM +1000, William Brown wrote: > > > Lib389: > > https://fedorahosted.org/389/ticket/48431 > > https://fedorahosted.org/389/attachment/ticket/48431/0001-Ticket-48431-lib389-integrate-ldclt.3.patch I've reviwed it some time ago and there is still an issue with:

[389-devel] Please review: Ticket 48943 - Add CI Test for the password test suite

2016-07-28 Thread Simon Pichugin
Hi team, I've possible found a regression. Please, review my test suite for the problem verification. https://fedorahosted.org/389/ticket/48943 https://fedorahosted.org/389/attachment/ticket/48943/0001-Ticket-48943-Add-CI-Test-for-the-password-test-suite.patch Thanks, Simon bin1_vT7Cmtcv.bin

[389-devel] Please review: Ticket 47976 - Add fixed CI test case

2016-08-02 Thread Simon Pichugin
Hi team, I am verifying the test case and I've found out that the patch with ticket47976_test.py wasn't commited. I've fixed it a bit (moved to test/tickets dir and set export.ldif to ldif_dir). Please, review. https://fedorahosted.org/389/ticket/47976

[389-devel] Please review: Ticket 47664 - Move CI test to suites and refactor

2016-07-15 Thread Simon Pichugin
Hi team, please review my patch: https://fedorahosted.org/389/ticket/47664 https://fedorahosted.org/389/attachment/ticket/47664/0001-Ticket-47664-Move-CI-test-to-the-pr-suite-and-refact.patch Thanks, Simon signature.asc Description: PGP signature -- 389-devel mailing list

[389-devel] Please review: Ticket 48085 - Add replica acceptance test suite

2017-02-07 Thread Simon Pichugin
Hi team, I've ported from TET main replica operations on four masters. Please, review. https://fedorahosted.org/389/ticket/48085 https://fedorahosted.org/389/attachment/ticket/48085/0001-Ticket-48085-Add-replica-acceptance-test-suite.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Ticket 48085 - Add single master replication test suite

2017-01-30 Thread Simon Pichugin
Hi team, I've ported TET smrepl test suite. Please, review. https://fedorahosted.org/389/ticket/48085 https://fedorahosted.org/389/attachment/ticket/48085/0001-Ticket-48085-Add-single-master-replication-test-suit.patch Thanks! signature.asc Description: PGP signature

[389-devel] Please review: Issue 49147 - Fix tests compatibility with older versions

2017-02-24 Thread Simon Pichugin
Hi team, please, review the patch with fixes related to older builds. Also, I think I dont havea permission to set reviewstatus. Please, advise. https://pagure.io/389-ds-base/issue/49147

[389-devel] Re: Trac -> Pagure migration is complete

2017-02-13 Thread Simon Pichugin
On Sat, Feb 11, 2017 at 05:23:24PM -0500, Mark Reynolds wrote: >Our migration to Pagure is complete. Please use this project for >filing Directory Server issues (aka Tickets): >[1]https://pagure.io/389-ds-base >Trac is now in read-only mode. If you need help with any of this just

[389-devel] Please review: Ticket 49085 - Make a short topology fixture alias

2017-01-16 Thread Simon Pichugin
Hi team, please, review a small patch. https://fedorahosted.org/389/ticket/49085 https://fedorahosted.org/389/attachment/ticket/49085/0001-Ticket-49085-Make-a-short-topology-fixture-alias.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Ticket 48967 - Add CI test and refactor test suite

2016-08-24 Thread Simon Pichugin
Hi team, please, review my test case and a small password test suite refactoring. https://fedorahosted.org/389/ticket/48967 https://fedorahosted.org/389/attachment/ticket/48967/0001-Ticket-48967-Add-CI-test-and-refactor-test-suite.patch Thanks, Simon signature.asc Description: PGP signature --

[389-devel] Please review: Ticket 49024 - Fix the rest of the CI failures

2016-11-09 Thread Simon Pichugin
Hi team, please review one more patch that fixes CI test failures. https://fedorahosted.org/389/ticket/49024 https://fedorahosted.org/389/attachment/ticket/49024/0001-Ticket-49024-Fix-the-rest-of-the-CI-failures.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Ticket 49024 - Fix dbdir paths and adjust test cases

2016-11-04 Thread Simon Pichugin
Hi team, please, review the new fixes. First patch is for ds.git and the second is for lib389.git. I'll finish the rest of the failures in the beginning of next week. https://fedorahosted.org/389/ticket/49024

[389-devel] Please review: Ticket 49055 - Add conftest.py for suites

2016-11-25 Thread Simon Pichugin
Hi team, please review the test suite improvement patch. Description: Add all topology fixtures in conftest.py for all suites and refactor them accordingly. Fix PEP8 and some logic issues. Set 2016 date in licenses. For now we have: - topology_st - with topology_st.standalone inst; -

[389-devel] Please review: Ticket 49024 - Fix CI test failures and defaults.inf

2016-11-01 Thread Simon Pichugin
Hi team, please review my first part of fixes: https://fedorahosted.org/389/ticket/49024 https://fedorahosted.org/389/attachment/ticket/49024/0001-Ticket-49024-Fix-CI-test-failures-and-defaults.inf.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Ticket 49018 - Fix runUpgrade compatibility with RHEL 6

2016-10-26 Thread Simon Pichugin
Hi team, please review my fix for lib389: https://fedorahosted.org/389/ticket/49018 https://fedorahosted.org/389/attachment/ticket/49018/0001-Fix-runUpgrade-tool-issues.patch Thanks, Simon signature.asc Description: PGP signature ___ 389-devel

[389-devel] Please review: Ticket 47858 - Add test case for nsTombstone

2016-12-14 Thread Simon Pichugin
Hi team, please review the test case that we need to verify bugzilla. https://fedorahosted.org/389/ticket/47858 https://fedorahosted.org/389/attachment/ticket/47858/0001-Ticket-47858-Add-test-case-for-nsTombstone.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Ticket 47747 - Add more topology fixtures

2016-12-14 Thread Simon Pichugin
Hi team, I've added more topology fixtures to lib389. They all are used in tickets. https://fedorahosted.org/389/ticket/47747 https://fedorahosted.org/389/attachment/ticket/47747/0001-Ticket-47747-Add-more-topology-fixtures.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Ticket 47747 - Add topology_i2 and topology_i3

2017-01-13 Thread Simon Pichugin
Hi team, please review the change requested by Ludwig Krispenz: https://fedorahosted.org/389/ticket/47747#comment:18 https://fedorahosted.org/389/attachment/ticket/47747/0001-Ticket-47747-Add-topology_i2-and-topology_i3.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Ticket 47747 - Add topology fixtures module

2016-11-29 Thread Simon Pichugin
Hi team, please, review: https://fedorahosted.org/389/ticket/47747 https://fedorahosted.org/389/attachment/ticket/47747/0001-Ticket-47747-Add-topology-fixtures-module.patch Thanks, Simon signature.asc Description: PGP signature ___ 389-devel mailing

[389-devel] Re: Please review: Ticket 47747 - Add topology fixtures module

2016-11-29 Thread Simon Pichugin
On Tue, Nov 29, 2016 at 04:28:59PM +0100, Simon Pichugin wrote: > Hi team, > please, review: > > https://fedorahosted.org/389/ticket/47747 > https://fedorahosted.org/389/attachment/ticket/47747/0001-Ticket-47747-Add-topology-fixtures-module.patch Also, please, take a look at th

[389-devel] Ticket 49055 - Fix debugging mode issue

2017-01-01 Thread Simon Pichugin
Hi team! Please, review my first patch in 2017 for lib389. https://fedorahosted.org/389/ticket/49055 https://fedorahosted.org/389/attachment/ticket/49055/0001-Ticket-49055-Fix-debugging-mode-issue.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Ticket 49055 - Clean up test tickets and suites

2017-01-04 Thread Simon Pichugin
Hi team, please, review my big clean up patch for dirsrvtests. https://fedorahosted.org/389/ticket/49055 https://fedorahosted.org/389/attachment/ticket/49055/0001-Ticket-49055-Clean-up-test-tickets-and-suites.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Ticket 49055 - Refactor create_test.py

2017-01-06 Thread Simon Pichugin
Hi team, please, review my new patch for ds. https://fedorahosted.org/389/ticket/49055 https://fedorahosted.org/389/attachment/ticket/49055/0001-Ticket-49055-Refactor-create_test.py.patch Thanks, Simon signature.asc Description: PGP signature ___

[389-devel] PROPOSAL: Ticket 49085 - Make a short topology fixture alias

2017-01-10 Thread Simon Pichugin
Hi team, please, share your thoughts on the topic here: https://fedorahosted.org/389/ticket/49085 Thanks, Simon signature.asc Description: PGP signature ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to

[389-devel] Please review: New test cases and lib389 fix

2017-04-04 Thread Simon Pichugin
Hi team, please, review my new test cases for replication acceptance test suite and a small fix for lib389. https://pagure.io/389-ds-base/issue/48085

[389-devel] Re: Please review: Issue 49156 - Add more IDs and fix docstrings

2017-03-09 Thread Simon Pichugin
On Thu, Mar 09, 2017 at 04:51:54PM +0100, Simon Pichugin wrote: > Hi team, > please, review my small patch that should fix the points I've missed. > > https://pagure.io/389-ds-base/issue/49156 > https://pagure.io/389-ds-base/

[389-devel] Re: Please review: Issue 79 - Fix replica.py and add tests

2017-07-31 Thread Simon Pichugin
/80825f0aee3bcb098b89d442af4526df8b13e2082496de83669dc4220199002e-0001-Issue-79-Fix-replica.py-and-add-tests.patch Thanks, Simon On Thu, Jul 27, 2017 at 03:14:59PM +0200, Simon Pichugin wrote: > Hi team, > please review a patch that fixes Replicas DSLdapObject. > > https://pagure.io/lib

[389-devel] Re: Please review: Issue 79 - Fix replica.py and add tests

2017-08-02 Thread Simon Pichugin
ps://pagure.io/lib389/issue/raw/files/80825f0aee3bcb098b89d442af4526df8b13e2082496de83669dc4220199002e-0001-Issue-79-Fix-replica.py-and-add-tests.patch > > Thanks, > Simon > > On Thu, Jul 27, 2017 at 03:14:59PM +0200, Simon Pichugin wrote: > > Hi team, > > please

[389-devel] Re: Please review: Draft of the big lib389 and pytest guide

2017-08-03 Thread Simon Pichugin
Hi team, a new version: https://pagure.io/lib389/issue/77#comment-451622 https://pagure.io/lib389/issue/raw/files/6047ac156e06192837271afc2770a83f7f3206400669537bb1d8f43ab7b9a434-Guidelines-for-using-pytest-and-lib389_47541162.html Thanks, Simon On Wed, Jul 19, 2017 at 04:31:50PM +0200, Simon

[389-devel] Please review: Issue 85 - Remove legacy replication attribute

2017-08-15 Thread Simon Pichugin
Hi team, please, review the patch for lib389. I've checked, it fixes tickets/ticket48325_test.py. https://pagure.io/lib389/issue/85 https://pagure.io/lib389/issue/raw/files/d5d0b94c97f8d341f4785e76c94c719d3902b80c3f339f047a9e95316ff28dcd-0001-Issue-85-Remove-legacy-replication-attribute.patch

[389-devel] Issue 83 - lib389 - Replace topology agmt objects

2017-08-09 Thread Simon Pichugin
Hi team, please review a patch for 389-ds-base tests: https://pagure.io/lib389/issue/83 https://pagure.io/lib389/issue/raw/files/9d807e6ff14eb4df440feea988db6f94794eba9d40b3204b8ed8286d9fce3dff-0001-Issue-83-lib389-Replace-topology-agmt-objects.patch Thanks, Simon signature.asc Description:

[389-devel] Issue 83, 79 - lib389 - Fix tests and create_test.py - Replica fix

2017-08-10 Thread Simon Pichugin
Hi team, some of the tests in 389-ds-base are broken. The following patches should fix them: For 389-ds-base: https://pagure.io/lib389/issue/83

[389-devel] Please review: Issue 91 - Fix replication m1h1c1 topology

2017-08-12 Thread Simon Pichugin
Hi team, https://pagure.io/lib389/issue/91 https://pagure.io/lib389/issue/raw/files/f9874b05dcab8b6e01517163218c9572b14373b8809cf93a1a38827c3db1873f-0001-Issue-91-Fix-replication-m1h1c1-topology.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Issue 79 - Fix replica.py and add tests

2017-07-27 Thread Simon Pichugin
Hi team, please review a patch that fixes Replicas DSLdapObject. https://pagure.io/lib389/issue/79 https://pagure.io/lib389/issue/raw/files/febe12b17a148405c527ed4938a9ef06c1d5046c9c3070ad32a0770526f33ee0-0001-Issue-79-Fix-replica.py-and-add-tests.patch Thanks, Simon signature.asc Description:

[389-devel] Please review: Draft of the big lib389 and pytest guide

2017-07-19 Thread Simon Pichugin
Hi team, https://pagure.io/lib389/issue/77#comment-449299 https://pagure.io/lib389/issue/raw/2aef109dbf0f23a359c15f209c6c523cebda4faf583125ff62e0a228f8c3b321-Guidelines-for-using-pytest-and-lib389_47541162.html Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Issue 83 - Add an util for generating instance parameters

2017-08-04 Thread Simon Pichugin
Hi team, please, review a new patch for big topology refactoring. I'll add a patch for 389-ds-base tests before the pushing it. https://pagure.io/lib389/issue/83

[389-devel] Please review: issue 77, issue 79, issue 83

2017-08-08 Thread Simon Pichugin
Hi team, please, check out the issues. They were updated recently (or just waiting for the review): https://pagure.io/lib389/issue/77 https://pagure.io/lib389/issue/raw/files/6047ac156e06192837271afc2770a83f7f3206400669537bb1d8f43ab7b9a434-Guidelines-for-using-pytest-and-lib389_47541162.html

[389-devel] Re: Please review: Issue 79 - Fix replica.py and add tests

2017-08-09 Thread Simon Pichugin
, Simon Pichugin wrote: > Add enum34 to requirements.txt for py2 compatibility > > https://pagure.io/lib389/issue/79 > https://pagure.io/lib389/issue/raw/files/7be353523a4a7ad8382a9a98ad778819f5e7557ab1812b9d1e595499ef821244-0001-Issue-79-Fix-replica.py-and-add-tests.patch > > On

[389-devel] Re: future of lib389 - seperate or merged?

2017-08-08 Thread Simon Pichugin
On Tue, Aug 01, 2017 at 04:00:23PM +1000, William Brown wrote: > My vote is to merge them. I came to this decision because I believe that > this will make development against multiple branches easier with regard > to testing and backport of patches. For example, we'll know that lib389 > that's

[389-devel] Please review: Add new DSEldif object

2017-05-15 Thread Simon Pichugin
Hi team, please, review small improvement for DSEldif API module: https://pagure.io/lib389/issue/27 https://pagure.io/lib389/issue/raw/files/bec12d1fa4aa1e66f2915c62c6a7bc61c7ffa53c06c225ca8f0d663b1f664131-0001-Add-new-DSEldif-object.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Issue 49301 - Add one logpipe test case

2017-06-27 Thread Simon Pichugin
Hi team, please, review the new patch for suites/ds-tools: https://pagure.io/389-ds-base/issue/49301 https://pagure.io/389-ds-base/issue/raw/704b8814bfbd0b13c6e04f3c696a633d3fb236bc927e41827f32e4a58768ce7e-0001-Issue-49301-Add-one-logpipe-test-case.patch Thanks, Simon signature.asc

[389-devel] Please review: Issue 49028 - Add autotuning test suite

2017-05-24 Thread Simon Pichugin
Hi team, please review my revised patch: https://pagure.io/389-ds-base/issue/49021 https://pagure.io/389-ds-base/issue/raw/2d03c0b6d91bf17bbf60021262c03401fd0af2d3f00466654b3aa24f7683b74f-0001-Issue-49028-Add-autotuning-test-suite.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Issue 623 - Add test case and refactor the cleanallruv suite

2017-06-19 Thread Simon Pichugin
Hi team, please, review a patch: https://pagure.io/389-ds-base/issue/623 https://pagure.io/389-ds-base/issue/raw/59ae3de25d0f7dccc880c062c640bf7ef2b3fd1c8b737f51e97bfc75bbcaa9a7-0001-Issue-623-Add-test-case-and-refactor-the-cleanallruv.patch Thanks, Simon signature.asc Description: PGP

[389-devel] Please review: Issue 49381 - Refactor numerous suite docstrings

2017-09-15 Thread Simon Pichugin
Hi team, please, review the patch for suite docs. https://pagure.io/389-ds-base/issue/49381 https://pagure.io/389-ds-base/issue/raw/files/5e909fe03f497ebad570a73364de1c2145f5c9b99d88c0543628ff5c0f0b038a-0001-Issue-49381-Refactor-numerous-suite-docstrings.patch Thanks, Simon signature.asc

[389-devel] Re: Please review: Issue 49381 - Refactor numerous suite docstrings

2017-09-19 Thread Simon Pichugin
New version: https://pagure.io/389-ds-base/issue/49381 https://pagure.io/389-ds-base/issue/raw/files/afa9b1a73b02e21633279b939d02deff33328cdc100b4c7c80645dd6b532f7ac-0001-Issue-49381-Refactor-numerous-suite-docstrings.patch On Fri, Sep 15, 2017 at 05:42:20PM +0200, Simon Pichugin wrote: > Hi t

[389-devel] Re: Please review: Issue 49381 - Refactor numerous suite docstrings

2017-09-19 Thread Simon Pichugin
New version: https://pagure.io/389-ds-base/issue/49381 https://pagure.io/389-ds-base/issue/raw/files/525619ec2b6d51ca4a78998e6b40c43d344e19d180e97ee67f1e09c82721f86f-0001-Issue-49381-Refactor-numerous-suite-docstrings.patch On Fri, Sep 15, 2017 at 05:42:20PM +0200, Simon Pichugin wrote: > Hi t

[389-devel] Re: Please review: Issue 49381 - Refactor numerous suite docstrings - Part 2

2017-10-16 Thread Simon Pichugin
Fixed the issues: https://pagure.io/389-ds-base/issue/49381 https://pagure.io/389-ds-base/issue/raw/files/b050293a47890b3527564aa336937830b0fc298a90037f972e46d49477134a24-0001-Issue-49381-Refactor-numerous-suite-docstrings-Part-.patch On Fri, Oct 06, 2017 at 03:27:36PM +0200, Simon Pichugin wrote

[389-devel] Please review: Issue #77 - Refactor docstrings in rST format - part 1

2017-09-06 Thread Simon Pichugin
Hi team, please, check out the new docs. https://fedorapeople.org/~spichugi/html/index.html https://pagure.io/lib389/issue/77 https://pagure.io/lib389/issue/raw/files/2e181d5321f194587899b1cbb37455d86d2754daeacb2d02c6de60aa9830b079-0001-Issue-77-Refactor-docstrings-in-rST-format-part-1.patch

[389-devel] Please review: Issue #77 - Fix changelogdb param issue

2017-09-12 Thread Simon Pichugin
Hi team, please, review: https://pagure.io/lib389/issue/77 https://pagure.io/lib389/issue/raw/files/486d6f41143e829fde00c722747e95d4ad03efafd0680b1e78f1c95ec693c3c0-0001-Issue-77-Fix-changelogdb-param-issue.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Issue 99 - Fix typo in create_topology

2017-09-25 Thread Simon Pichugin
Hi team, please review two line patch. https://pagure.io/lib389/issue/99 https://pagure.io/lib389/issue/raw/files/f3e504a5779b08eedf743645be3ab3af601213a5f35e9e44dd7f02254a43f72c-0001-Issue-99-Fix-typo-in-create_topology.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Issue #77 - Add sphinx documentation

2017-08-28 Thread Simon Pichugin
Hi team, Most of the comments were applied. Thanks! Now the layout is: - index.rst - welcoming word, Table of Contents and Contact Us. - guidelines.rst - is included into index.rst and contains basic test development workflow, pytest features overview, and basic lib389 and python-ldap

[389-devel] Please review: Issue 49374 - Add CI test case

2017-11-28 Thread Simon Pichugin
Hi team, please review a small test case: https://pagure.io/389-ds-base/issue/49374 https://pagure.io/389-ds-base/issue/raw/files/f23c2afa41b204756126c621b8a0c12678179048a725e587f775b0a4cfc19200-0001-Issue-49374-Add-CI-test-case.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Re: Please review: Issue 47536 - Add Python 3 support and move test case to suites

2017-11-24 Thread Simon Pichugin
I've fixed the issues: https://pagure.io/389-ds-base/issue/raw/files/e023d32821b13103e662b94b1348a0a3016b3ea15fd24b4e2bebfefbdae9e8e6-0001-Issue-47536-Add-Python-3-support-and-move-test-case-.patch On Thu, Nov 23, 2017 at 03:53:17PM +0100, Simon Pichugin wrote: > Hi team, > please,

[389-devel] Please review: Issue 47536 - Add Python 3 support and move test case to suites

2017-11-23 Thread Simon Pichugin
Hi team, please, review the Python 3 support patch. https://pagure.io/389-ds-base/issue/47536 https://pagure.io/389-ds-base/issue/raw/files/1cdbed5b2520a0f85c950305ee3f40e605f8d263129ff70996952ba8ac94d895-0001-Issue-47536-Add-Python-3-support-and-move-test-case-.patch Thanks, Simon

[389-devel] Please review: Issue 49408- Add a test case for nsds5ReplicaId checks

2017-11-20 Thread Simon Pichugin
Hi team, please, review a small test case I need to verify BZ: https://pagure.io/389-ds-base/issue/49408 https://pagure.io/389-ds-base/issue/raw/files/f5457f377c15dd5d35d153baa775a8be15f883c419d929fb41a4203be145a200-0001-Issue-49408-Add-a-test-case-for-nsds5ReplicaId-check.patch Thanks, Simon

[389-devel] Re: Please review: Issue #77 - Refactor docstrings in rST format - part 2

2017-11-15 Thread Simon Pichugin
https://pagure.io/lib389/issue/raw/files/a7f959f31cfd6f5b4f837dd715bf1d0beb96a182e30a0c1b13bfc4d3cdfbc905-0001-Issue-lib389-77-Refactor-docstrings-in-rST-format-pa.patch On Wed, Nov 15, 2017 at 04:44:07PM +0100, Simon Pichugin wrote: > A second part: > > https://pagure.io/lib389/issue/7

[389-devel] Re: Please review: Issue #77 - Refactor docstrings in rST format - part 2

2017-11-15 Thread Simon Pichugin
A second part: https://pagure.io/lib389/issue/77 https://pagure.io/lib389/issue/raw/files/b050293a47890b3527564aa336937830b0fc298a90037f972e46d49477134a24-0001-Issue-49381-Refactor-numerous-suite-docstrings-Part-.patch On Wed, Sep 06, 2017 at 07:33:24PM +0200, Simon Pichugin wrote: > Hi t

[389-devel] Re: Please review: Issue lib389 3 - Python 3 support for ACL test suite

2017-11-03 Thread Simon Pichugin
On Fri, Oct 20, 2017 at 12:14:12PM +0200, Simon Pichugin wrote: > Hi team, > please, review the Python 3 support patch for ACL. > > Also, please, check it if you are a developer. Because it contains > the indended way to use lib389 feature for Python 3 support. > > https://p

[389-devel] Please review: Issue 48393 - Add a test case for nsds5ReplicaId checks

2017-11-07 Thread Simon Pichugin
https://pagure.io/389-ds-base/issue/48393 https://pagure.io/389-ds-base/issue/raw/files/a900cbac9d8d6ed0bd14a424dd966cca4233a1376fb392c2129d5987d3073f90-0001-Issue-48393-Add-a-test-case-for-nsds5ReplicaId-check.patch signature.asc Description: PGP signature

[389-devel] Re: Please review: Issue 49581 - Fix dynamic plugins test suite

2018-05-14 Thread Simon Pichugin
Fixed the issues Viktor has reported. Please, review. On Mon, Apr 16, 2018 at 12:25:35PM +0200, Simon Pichugin wrote: > On Thu, Apr 12, 2018 at 12:17:06PM +0200, Simon Pichugin wrote: > > Hi team, > > please review a PR for dynamic plugins test suite fix. > > > > ht

[389-devel] lib389 usage cheatsheet

2018-05-09 Thread Simon Pichugin
Hi team, recently, we had a discussion on a scrum meeting about lib389 and its new API. If I understood right there was an opinion that lib389 DSLdapObjects API is not very intuitive and it is much easier stick to python-ldap style because it uses ldapmodify/ldapadd wording (or close enough to

[389-devel] Re: lib389 usage cheatsheet

2018-05-11 Thread Simon Pichugin
Hi Thierry, I agree with you, it was exactly my proposition :) Keeping main python-ldap elements is important because we don't want to implement or mask/wrap this basic functionality (like working with controls, etc) we just want to redirect them. Ideally, we should make our admin library very

[389-devel] Re: Please review: Issue 49657 - Fix cascading replication scenario in lib389 API

2018-05-11 Thread Simon Pichugin
The issues mentioned by Mark were fixed. On Thu, May 03, 2018 at 02:32:22PM +0200, Simon Pichugin wrote: > Hi team, > please, review: > > https://pagure.io/389-ds-base/pull-request/49659 > https://pagure.io/389-ds-base/issue/49657 >

[389-devel] Please review: Issue 49381 - Add docstrings to plugin test suites - Part 1

2018-05-23 Thread Simon Pichugin
Hi team, please, review a docstrings commit. https://pagure.io/389-ds-base/issue/49381 https://pagure.io/389-ds-base/pull-request/49708 Thanks, Simon ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to

[389-devel] Please review: Issue 49640 - Errors about PBKDF2 password storage plugin at server startup

2018-06-08 Thread Simon Pichugin
Hi team, https://pagure.io/389-ds-base/issue/49640 https://pagure.io/389-ds-base/pull-request/49771 Thanks, Simon signature.asc Description: PGP signature ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to

  1   2   >