Re: [389-devel] Git rights for QE team

2015-09-23 Thread Nathan Kinder
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 09/23/2015 01:38 AM, Simon Pichugin wrote: > Hi Nathan, Hi Mark, Hi team, > > as I know, we've decided to make me "gatekeeper" of QE team for > managing lib389 and DS git repos. > > Can you please update the status of this situation? > >

Re: [389-devel] Please review: Ticket #47892 coverity defects found in 1.3.3.1

2014-09-12 Thread Nathan Kinder
On 09/12/2014 12:59 PM, Rich Megginson wrote: https://fedorahosted.org/389/attachment/ticket/47892/0001-Ticket-47892-coverity-defects-found-in-1.3.3.1.patch ACK. -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel --

Re: [389-devel] Please review: Ticket #47492 - PassSync removes User must change password flag on the Windows side

2014-04-03 Thread Nathan Kinder
On 04/03/2014 08:13 PM, Rich Megginson wrote: https://fedorahosted.org/389/attachment/ticket/47492/0001-Ticket-47492-PassSync-removes-User-must-change-passw.3.patch Ack -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review: (47752) Don't add unhashed password mod if we don't have an unhashed value

2014-03-24 Thread Nathan Kinder
https://fedorahosted.org/389/ticket/47752 https://fedorahosted.org/389/attachment/ticket/47752/0001-Ticket-47752-Don-t-add-unhashed-password-mod-if-we-d.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] plugin problem using slapi_entry_attr_find

2014-01-16 Thread Nathan Kinder
On 01/16/2014 03:14 PM, Deas, Jim wrote: Rich, Thanks. I actually did have the address of operator on the code. Both the init and config are defining only a couple of specific functions (start_fn, pre_results_fn,pre_abandon_fn) one function defined for each. The one I am testing is

[389-devel] Please Review: (47525) Allow memberOf to use an alternate config area

2013-12-12 Thread Nathan Kinder
https://fedorahosted.org/389/ticket/47525 https://fedorahosted.org/389/attachment/ticket/47525/0001-Ticket-47525-Don-t-modify-preop-entry-in-memberOf-co.patch The previous fix for this issue was causing a crash in one of the in-tree tests. This patch addresses the crash. -- 389-devel mailing

Re: [389-devel] Please Review: (47525) Allow memberOf to use an alternate config area

2013-12-12 Thread Nathan Kinder
On 12/12/2013 04:08 PM, Nathan Kinder wrote: https://fedorahosted.org/389/ticket/47525 https://fedorahosted.org/389/attachment/ticket/47525/0001-Ticket-47525-Don-t-modify-preop-entry-in-memberOf-co.patch The previous fix for this issue was causing a crash in one of the in-tree tests

[389-devel] Please Review: (Ticket 47565) upgrade to 1.3.2.2 causes error with Content Sync plugin

2013-10-22 Thread Nathan Kinder
https://fedorahosted.org/389/ticket/47565 https://fedorahosted.org/389/attachment/ticket/47565/0001-Ticket-47565-Content-Sync-update-file-needs-extensib.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] 389-ds-base_Debian_Wheezy - Build # 90 - Failure!

2013-10-22 Thread Nathan Kinder
I just pushed the following patch under the trivial fix rule to address these warnings. This should make the Jenkins jobs green again. https://fedorahosted.org/389/attachment/ticket/47569/0001-Ticket-47569-Fix-build-warnings.patch On 10/22/2013 05:32 PM, nkin...@redhat.com wrote:

[389-devel] Please Review: (Ticket 47513) tmpfiles.d references /var/lock when they should reference /run/lock

2013-10-10 Thread Nathan Kinder
https://fedorahosted.org/389/ticket/47513 https://fedorahosted.org/389/attachment/ticket/47513/0001-Ticket-47513-tmpfiles.d-references-var-lock-when-the.2.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] switch to F19 for autogen?

2013-10-09 Thread Nathan Kinder
On 10/09/2013 01:21 PM, Rich Megginson wrote: In the interest of reducing the autotool file churn, is everyone ok with switching to using F19 to run autogen? Ack. If we want to enforce that for master, we could update the version checks in autogen.sh to require the F19 versions as a minimum.

[389-devel] Jenkins changes

2013-10-07 Thread Nathan Kinder
Hi, I made some modifications to our Jenkins jobs which affect the e-mails that are sent to this list when encountering a build failure. Last week, I had changed the e-mails to include the entire build logs for failed builds as a convenience (no need to go to the Jenkins URL to see why the

[389-devel] Please Review: (Ticket 47539) Disabling DNA plug-in throws error 53

2013-10-02 Thread Nathan Kinder
https://fedorahosted.org/389/ticket/47539 https://fedorahosted.org/389/attachment/ticket/47539/0001-Ticket-47539-Disabling-DNA-plug-in-throws-error-53.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: #47388: [RFE] Support 'Content Synchronization Operation' (SyncRepl)

2013-09-26 Thread Nathan Kinder
, sync_util.c:251, sync_util.c:544, sync_util.c:608, sync_util.c:682, and result.c:294. If you address the above issues, I'm OK with you pushing it to the repo. Thanks, -NGK Regards, Ludwig On 08/30/2013 05:00 PM, Nathan Kinder wrote: On 08/30/2013 05:06 AM, Ludwig Krispenz wrote: Hello, I

Re: [389-devel] 389-ds-base_Debian_Wheezy - Build # 46 - Fixed!

2013-09-25 Thread Nathan Kinder
FYI - Please ignore these failures, as I manually triggered them to fail in my Jenkins build environment. As you can see from these reports, we now have a Jenkins system set up to perform Continuous Integration builds of the main 389 DS code (389-ds-base) on Debian 7.1 (Wheezy). These builds

[389-devel] Please Review: (ticket 449) Possible to set invalid macros in Macro ACIs

2013-09-12 Thread Nathan Kinder
https://fedorahosted.org/389/ticket/449 https://fedorahosted.org/389/attachment/ticket/449/0001-Ticket-449-Allow-macro-aci-keywords-to-be-case-insen.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: another compiler warning for F20 admin

2013-08-16 Thread Nathan Kinder
ACK. On 08/16/2013 09:55 AM, Rich Megginson wrote: -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review: (Ticket 47467) Improve Add CRL/CKL dialog and errors

2013-08-14 Thread Nathan Kinder
https://fedorahosted.org/389/ticket/47467 These patches improve the Add CRL/CKL Console dialog. Changes were needed in Admin Server for the security CGI error messages, IDM Console Framework for the dialog improvements, and Admin Console for the online help page. I've included screenshots

[389-devel] Please Review: (Ticket 362) Directory Console generates insufficient key strength

2013-08-13 Thread Nathan Kinder
Hi, These patches add new UI to the certificate request wizard in Console that allows the key size and signing algorithms to be selected. It also improves the defaults if an older Console is used against an Admin Server with these changes. Changes were required to Admin Server for the CGI

[389-devel] Please Review: Add git commit hash to developer rpm build name

2013-04-22 Thread Nathan Kinder
From 52fb682ceb0b1f03de26b6f9d56a8ee2476d9422 Mon Sep 17 00:00:00 2001 From: Nathan Kinder nkin...@redhat.com Date: Mon, 22 Apr 2013 13:34:44 -0700 Subject: [PATCH] Add git commit hash to developer rpm build names We need to set the srcdir variable in order for the most recent git hash

Re: [389-devel] Please Review: Add make rpms build target

2013-04-19 Thread Nathan Kinder
On 04/19/2013 12:04 PM, Rich Megginson wrote: On 04/19/2013 12:54 PM, Nathan Kinder wrote: Hi, Please review the attached patch that adds the ability for convenient developer RPM builds. Details are in the patch description. Note that my patch does not include any changes that will be made

Re: [389-devel] Please Review: Add make rpms build target

2013-04-19 Thread Nathan Kinder
On 04/19/2013 12:51 PM, Rich Megginson wrote: On 04/19/2013 01:21 PM, Nathan Kinder wrote: On 04/19/2013 12:04 PM, Rich Megginson wrote: On 04/19/2013 12:54 PM, Nathan Kinder wrote: Hi, Please review the attached patch that adds the ability for convenient developer RPM builds. Details

[389-devel] Please Review: Allow RPM builds to be run without configure

2013-04-19 Thread Nathan Kinder
just to build the Makefile. More details are in the patch description. Thanks, -NGK From c996ae334e7a27843549318b3a970c995d58f5b6 Mon Sep 17 00:00:00 2001 From: Nathan Kinder nkin...@redhat.com Date: Fri, 19 Apr 2013 18:10:30 -0700 Subject: [PATCH] Allow rpm builds to be run without configure

[389-devel] Please Review: (ticket 47734) NSS unknown protocol errors when restarting Admin Server with SSL enabled

2013-04-18 Thread Nathan Kinder
https://fedorahosted.org/389/ticket/47334 https://fedorahosted.org/389/attachment/ticket/47334/0001-Ticket-47334-Avoid-quoting-all-settings-in-console.c.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Nightly 389 Directory Server development yum repositories

2013-02-13 Thread Nathan Kinder
Hi, I have set up a nightly development yum repository for 389 Directory Server builds from master. There are currently builds available for Fedora 18 (x86_64 and i686). I will work on adding builds for rawhide (F19) in the near future. New builds are made nightly from the master branch

Re: [389-devel] clarification on dn normalization

2012-11-29 Thread Nathan Kinder
On 11/29/2012 06:49 AM, Ludwig Krispenz wrote: Hi, On 11/29/2012 03:37 PM, John Dennis wrote: On 11/29/2012 08:47 AM, Ludwig Krispenz wrote: Hi, I found an older post by KurtZeilenga: http://www.openldap.org/lists/openldap-software/200501/msg00102.html and I think RFC4517, 4.2.15.

Re: [389-devel] winsync syncs deletions of AD entries that are out of scope

2012-05-04 Thread Nathan Kinder
On 05/04/2012 10:45 AM, Rich Megginson wrote: On 05/04/2012 11:25 AM, Rich Megginson wrote: This came up during extended testing for https://fedorahosted.org/389/ticket/355 steps: 1) make a ds user and an ad user that are in sync - verify ad changes go to ds and vice versa 2) move the ad

Re: [389-devel] Please review: coverity 12563 Read from pointer after free

2012-03-07 Thread Nathan Kinder
On 03/07/2012 07:41 AM, Rich Megginson wrote: On 03/07/2012 07:53 AM, Nathan Kinder wrote: An additional fix is needed for this issue. Your patch fixed the dna_pre_op() function, but the same issue exists in the dna_be_txn_pre_op() function. The attached patch takes care of this. ack

[389-devel] Please Review: (181) Allow PAM passthru plug-in to have multiple config entries

2012-02-27 Thread Nathan Kinder
https://fedorahosted.org/389/ticket/181 https://fedorahosted.org/389/attachment/ticket/181/0001-ticket-181-Allow-PAM-passthru-plug-in-to-have-multip.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: fix mozldap build issues

2012-01-21 Thread Nathan Kinder
On 01/20/2012 07:02 PM, Rich Megginson wrote: -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: reduce calls to csn_as_string and slapi_log_error

2011-11-16 Thread Nathan Kinder
On 11/16/2011 08:48 AM, Rich Megginson wrote: -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: csn_init_as_string should not use sscanf

2011-11-16 Thread Nathan Kinder
On 11/16/2011 06:38 PM, Rich Megginson wrote: -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: csn_as_string - use slapi_uN_to_hex instead of sprintf

2011-11-15 Thread Nathan Kinder
On 11/15/2011 10:29 AM, Rich Megginson wrote: -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: uniqueid formatting - use slapi_u8_to_hex instead of sprintf

2011-11-15 Thread Nathan Kinder
On 11/15/2011 01:12 PM, Rich Megginson wrote: -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack. -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: Reduce the number of DN normalization

2011-10-10 Thread Nathan Kinder
On 10/10/2011 10:08 AM, Noriko Hosoi wrote: Reduce the number of DN normalization . Replacing SLAPI_TARGET_DN with SLAPI_TARGET_SDN (also its macros, e.g., SLAPI_SEARCH_TARGET_SDN and SLAPI_ADD_TARGET_SDN). I haven't reviewed the entire patch yet, but I am concerned about changing the APIs

[389-devel] Please Review: (730387) Use POSIX RW locks instead of NSPR implementation

2011-08-16 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=730387 https://bugzilla.redhat.com/attachment.cgi?id=518567action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review: (729717) Windows sync logs errors when a delete is synced from AD

2011-08-10 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=729717 https://bugzilla.redhat.com/attachment.cgi?id=517697action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review: (728510) Run dirsync after sending updates to AD

2011-08-10 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=728510 https://bugzilla.redhat.com/attachment.cgi?id=517698action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: look for separate openldap ldif library

2011-06-28 Thread Nathan Kinder
ack On 06/27/2011 12:03 PM, Rich Megginson wrote: This is needed to build in Fedora rawhide -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-devel@lists.fedoraproject.org

Re: [389-devel] Please review: skip rebranding current brand

2011-06-21 Thread Nathan Kinder
ack On 06/20/2011 06:25 PM, Rich Megginson wrote: -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review: (710377) Segmentation fault (core dumped) while doing Import in a Replication Setup

2011-06-03 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=710377 https://bugzilla.redhat.com/attachment.cgi?id=502880action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review: (703530) Allow Managed Entry config to be relocated to main database

2011-05-10 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=703530 https://bugzilla.redhat.com/attachment.cgi?id=498086action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review: (702705) Fix Coverity NULL pointer dereferences

2011-05-06 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=702705 https://bugzilla.redhat.com/attachment.cgi?id=497407action=edit https://bugzilla.redhat.com/attachment.cgi?id=497416action=edit https://bugzilla.redhat.com/attachment.cgi?id=497429action=edit

[389-devel] Please Review: (700875) Cleanup ds_bring_up_server_install() in dsalib

2011-04-29 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=700875 https://bugzilla.redhat.com/attachment.cgi?id=495819action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review (697641) adminutil - Fix Coverity NULL pointer dereferences

2011-04-18 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=697641 https://bugzilla.redhat.com/attachment.cgi?id=492996action=edit https://bugzilla.redhat.com/attachment.cgi?id=493023action=edit https://bugzilla.redhat.com/attachment.cgi?id=493032action=edit

[389-devel] Please Review: (690649) Use of free'd pointer in indexing code

2011-03-24 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=690649 https://bugzilla.redhat.com/attachment.cgi?id=487435action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review: (689952) Incorrect bit check in replication connection code

2011-03-22 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=689952 https://bugzilla.redhat.com/attachment.cgi?id=486894action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review: (688341) Fix Coverity code maintainability issues

2011-03-17 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=688341 https://bugzilla.redhat.com/attachment.cgi?id=485829action=edit https://bugzilla.redhat.com/attachment.cgi?id=485851action=edit https://bugzilla.redhat.com/attachment.cgi?id=486043action=edit

[389-devel] Please review: (616707) Allow editing of attributes matching rules from console

2011-03-10 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=616707 https://bugzilla.redhat.com/attachment.cgi?id=483545action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review: (493424) remove unneeded modules for admin server apache config

2011-02-22 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=493424 https://bugzilla.redhat.com/attachment.cgi?id=480295action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review: (675853) dirsrv crash segfault in need_new_pw()

2011-02-08 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=675853 https://bugzilla.redhat.com/attachment.cgi?id=477699action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review: (670616) Allow SSF to be set for local (ldapi) connections

2011-02-01 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=670616 https://bugzilla.redhat.com/attachment.cgi?id=476468action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review: (527912) setup-ds.pl hangs at hostname prompt

2011-01-20 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=527912 https://bugzilla.redhat.com/attachment.cgi?id=474563action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please Review: (661102) Rename of managed entries not handled correctly

2011-01-07 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=661102 https://bugzilla.redhat.com/attachment.cgi?id=472276action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: [Bug 653007] db2ldif export of clear text passwords lacks storage scheme

2011-01-05 Thread Nathan Kinder
You might want to check if you can just use slapi_is_encoded() instead of parsing for the storage scheme yourself. -NGK On 01/05/2011 06:00 PM, Noriko Hosoi wrote: https://bugzilla.redhat.com/show_bug.cgi?id=653007 https://bugzilla.redhat.com/attachment.cgi?id=471975action=diff

[389-devel] Please Review: (578863) Password Modify Extended Operation ignoring referrals and writing information on dedicated consumer server

2010-04-08 Thread Nathan Kinder
https://bugzilla.redhat.com/show_bug.cgi?id=578863 https://bugzilla.redhat.com/attachment.cgi?id=405422action=diff https://bugzilla.redhat.com/attachment.cgi?id=405422action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

Re: [389-devel] Please Review: Managed Entries Plug-in

2010-03-31 Thread Nathan Kinder
On 03/30/2010 03:44 PM, Rich Megginson wrote: Nathan Kinder wrote: New patch attached. Nice! Thanks for the review! mep.c:491 - value is not freed if it is not a valid filter - also would be nice to have the error message print value to show what the bogus filter

[389-devel] Please Review: Make check for threaded httpd work with Apache 2.0

2010-02-11 Thread Nathan Kinder
From 07346383364e6a3e37d8b2f44b305a70db26ba3c Mon Sep 17 00:00:00 2001 From: Nathan Kinder nkin...@redhat.com Date: Thu, 11 Feb 2010 16:14:54 -0800 Subject: [PATCH] Make check for threaded httpd work with Apache 2.0 The check we use for a threaded httpd doesn't properly detect a threaded Apache