[389-devel] Re: Please review: ticket #48766 Replication changelog can incorrectly skip over updates

2016-09-09 Thread Ludwig Krispenz
Hi, here is the latest correction to the changelog fix, in fact it is Thierry's version of teh fix which simplified the logic a bit https://fedorahosted.org/389/attachment/ticket/48766/0001-PATCH-use-a-consumer-maxcsn-only-as-anchor-if-suppli.patch Ludwig On 05/23/2016 03:06 PM, Ludwig

[389-devel] Re: Please review: ticket #48766 Replication changelog can incorrectly skip over updates

2016-05-25 Thread thierry bordaz
On 05/25/2016 08:47 AM, Ludwig Krispenz wrote: On 05/24/2016 07:00 PM, thierry bordaz wrote: On 05/24/2016 05:24 PM, Ludwig Krispenz wrote: On 05/24/2016 04:20 PM, thierry bordaz wrote: Hi Ludwig, Thanks for your explanation. The design looks very good. I think it would be good to put

[389-devel] Re: Please review: ticket #48766 Replication changelog can incorrectly skip over updates

2016-05-25 Thread Ludwig Krispenz
On 05/24/2016 07:00 PM, thierry bordaz wrote: On 05/24/2016 05:24 PM, Ludwig Krispenz wrote: On 05/24/2016 04:20 PM, thierry bordaz wrote: Hi Ludwig, Thanks for your explanation. The design looks very good. I think it would be good to put into the code (especially

[389-devel] Re: Please review: ticket #48766 Replication changelog can incorrectly skip over updates

2016-05-24 Thread Ludwig Krispenz
On 05/24/2016 04:20 PM, thierry bordaz wrote: Hi Ludwig, Thanks for your explanation. The design looks very good. I think it would be good to put into the code (especially clcache_adjust_anchorcsn) the reference to the related design paragraph. There is something I do not understand in

[389-devel] Re: Please review: ticket #48766 Replication changelog can incorrectly skip over updates

2016-05-24 Thread Ludwig Krispenz
Hi, On 05/23/2016 06:29 PM, thierry bordaz wrote: On 05/23/2016 03:06 PM, Ludwig Krispenz wrote: This is the latest version of the "changelog buffer processing" fixes. https://fedorahosted.org/389/ticket/48766