[389-devel] Please review: Bug 516611 - 389 DS segfaults on libsyntax-plugin.so

2010-02-25 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=516611 There are three separate patches for this: https://bugzilla.redhat.com/attachment.cgi?id=396463action=diff https://bugzilla.redhat.com/attachment.cgi?id=396463action=edit https://bugzilla.redhat.com/attachment.cgi?id=396465action=diff

[389-devel] Please review: Bug 551198 - LDAPI: incorrect logging to access log

2010-03-01 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=551198 https://bugzilla.redhat.com/attachment.cgi?id=397221action=diff https://bugzilla.redhat.com/attachment.cgi?id=397221action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Add support for additional schema/matching rules included with 389

2010-03-08 Thread Rich Megginson
From 2ab747aeeb1ea0c049cf6eaf6b15ea38f8088cd3 Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Mon, 8 Mar 2010 20:53:49 -0700 Subject: [PATCH] Add support for additional schema/matching rules included with 389 1) The 60qmail.ldif schema we ship used integerMatch and IA5

[389-devel] Please review: Bug 572677 - Memory leak in searches including GER control

2010-03-11 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=572677 https://bugzilla.redhat.com/attachment.cgi?id=399548action=diff https://bugzilla.redhat.com/attachment.cgi?id=399548action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

Re: [389-devel] Please Review: Managed Entries Plug-in

2010-03-31 Thread Rich Megginson
Nathan Kinder wrote: On 03/30/2010 03:44 PM, Rich Megginson wrote: Nathan Kinder wrote: New patch attached. Nice! Thanks for the review! mep.c:491 - value is not freed if it is not a valid filter - also would be nice to have the error message

[389-devel] Please review: Repl Session API needs to check for NULL api before init

2010-05-21 Thread Rich Megginson
From d8234c6633eb1e371fd0590180cd247e87bb0784 Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Fri, 21 May 2010 11:27:51 -0600 Subject: [PATCH] Repl Session API needs to check for NULL api before init The new repl sesssion API will crash when adding a replication

[389-devel] The tree is open for commits

2010-07-01 Thread Rich Megginson
I've tagged 389-ds-base-1.2.6.rc3 - this will hopefully be the actual 1.2.6 release - if not, then I can always create a branch at the 389-ds-base-1.2.6.rc3 tag. The tree is now open -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Bug 610177 - fix coverity Defect Type: Uninitialized variables issues

2010-07-01 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=610177 https://bugzilla.redhat.com/attachment.cgi?id=428568action=diff https://bugzilla.redhat.com/attachment.cgi?id=428568action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Bug 610276 - fix coverity Defect Type: API usage errors issues

2010-07-01 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=610276 https://bugzilla.redhat.com/attachment.cgi?id=428569action=diff https://bugzilla.redhat.com/attachment.cgi?id=428569action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Bug 617629 - Missing aliases in new schema files

2010-08-02 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=617629 https://bugzilla.redhat.com/attachment.cgi?id=434078action=diff https://bugzilla.redhat.com/attachment.cgi?id=434078action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Bug 617862 - Replication: Unable to delete tombstone errors

2010-08-03 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=617862 https://bugzilla.redhat.com/attachment.cgi?id=436371action=diff https://bugzilla.redhat.com/attachment.cgi?id=436371action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Bug 624485 - setup dsktune check step should default to yes if no problems found

2011-01-21 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=624485 https://bugzilla.redhat.com/attachment.cgi?id=474704action=diff https://bugzilla.redhat.com/attachment.cgi?id=474704action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Bug 677774 - DS fails to start after reboot

2011-02-18 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=64 https://bugzilla.redhat.com/attachment.cgi?id=479564action=diff https://bugzilla.redhat.com/attachment.cgi?id=479564action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Bug 680284 - Don't create rundir in post installation script

2011-02-24 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=680284 https://bugzilla.redhat.com/attachment.cgi?id=480912action=diff https://bugzilla.redhat.com/attachment.cgi?id=480912action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Bug 676655 - winsync stops working after server restart

2011-02-28 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=676655 https://bugzilla.redhat.com/attachment.cgi?id=481466action=diff https://bugzilla.redhat.com/attachment.cgi?id=481466action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Bug 518890 - setup-ds-admin.pl - No fully qualified domain name in brackets + Error: failed to open an LDAP connection to host 'host.domain' port '389' as user 'cn=Directory

2011-03-02 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=518890 https://bugzilla.redhat.com/attachment.cgi?id=481957action=diff https://bugzilla.redhat.com/attachment.cgi?id=481957action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Bug 690584 - fix coverity resource leak issues

2011-03-25 Thread Rich Megginson
None of these are serious. https://bugzilla.redhat.com/show_bug.cgi?id=690584 -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Add systemd capability to 389-ds-base and 389-admin

2011-04-25 Thread Rich Megginson
https://fedoraproject.org/wiki/TomCallaway/Systemd_Revised_Draft These are the patches for ds-base: https://bugzilla.redhat.com/attachment.cgi?id=494777action=edit https://bugzilla.redhat.com/attachment.cgi?id=494779action=edit These are the patches for admin:

[389-devel] Please review: Bug 703990 - Support upgrade from Red Hat Directory Server

2011-05-19 Thread Rich Megginson
a couple more patches https://bugzilla.redhat.com/show_bug.cgi?id=703990 -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: skip rebranding current brand

2011-06-20 Thread Rich Megginson
From 331d60e55e68632a7403adfac1f37bd3202f839d Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Mon, 20 Jun 2011 19:24:37 -0600 Subject: [PATCH] skip rebranding current brand if the current brand is the same as the new brand, skip rebranding the branding information is now

[389-devel] Please review: add support for ldif files with changetype: add

2011-06-27 Thread Rich Megginson
From 7950cbb484f6b517cd00fec4cdde93fc305ca01c Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Mon, 27 Jun 2011 10:50:00 -0600 Subject: [PATCH 2/3] add support for ldif files with changetype: add IPA config files use changetype: add to add new files

[389-devel] Please review: Bug 725953 - Winsync: DS entries fail to sync to AD, if the User's CN entry contains a comma

2011-07-27 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=725953 https://bugzilla.redhat.com/attachment.cgi?id=515610action=diff https://bugzilla.redhat.com/attachment.cgi?id=515610action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Bug 723126 - Configure Admin Server - Connection Restriction -- Add Screen is flicking consistently.

2011-08-08 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=723126 https://bugzilla.redhat.com/attachment.cgi?id=517325action=diff https://bugzilla.redhat.com/attachment.cgi?id=517325action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Bug 723937 - replication failing on RUV errors

2011-08-10 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=723937 https://bugzilla.redhat.com/attachment.cgi?id=517662action=diff https://bugzilla.redhat.com/attachment.cgi?id=517662action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Bug 729369 - upgrade DB to upgrade from entrydn to entryrdn format is not working.

2011-08-10 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=729369 https://bugzilla.redhat.com/attachment.cgi?id=517678action=diff https://bugzilla.redhat.com/attachment.cgi?id=517678action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Bug 633803 - passwordisglobalpolicy attribute brakes TLS chaining

2011-08-22 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=633803 https://bugzilla.redhat.com/attachment.cgi?id=519337action=diff https://bugzilla.redhat.com/attachment.cgi?id=519337action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org

Re: [389-devel] about Bug 590826 - Reloading database from ldif causes changelog to emit data no longer matches errors

2011-09-07 Thread Rich Megginson
On 09/07/2011 05:06 PM, Noriko Hosoi wrote: Rich Megginson wrote: The problem comes from the method we use to check if the changelog does not match the database in replica_check_for_data_reload(). The RUV in the database contains obsolete elements from replicas that are no longer in use

[389-devel] Please review: Bug 590826 - Reloading database from ldif causes changelog to emit data no longer matches errors

2011-09-09 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=590826 https://bugzilla.redhat.com/attachment.cgi?id=522361action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Bug 736712 - Modifying ruv entry deadlocks server

2011-09-09 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=736712 https://bugzilla.redhat.com/attachment.cgi?id=522382action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review 2: Bug 590826 - Reloading database from ldif causes changelog to emit data no longer matches errors

2011-09-09 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=590826 https://bugzilla.redhat.com/attachment.cgi?id=522385action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Bug 741744 - MOD operations with chained delete/add get back error 53 on backend config

2011-09-29 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=741744 https://bugzilla.redhat.com/attachment.cgi?id=525605action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Bug 741744 - part2 - MOD operations with chained delete/add get back error 5, 3 on backend config

2011-09-29 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=741744 https://bugzilla.redhat.com/attachment.cgi?id=525654action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Bug 740942 - allow resource limits to be set for paged searches independently of limits for other searches/operations

2011-09-30 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=740942 https://bugzilla.redhat.com/attachment.cgi?id=525854action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: convert memberof to use transactions

2011-10-06 Thread Rich Megginson
0cc8c050795e575617fcb1f88ce9890a2358 Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Thu, 6 Oct 2011 08:12:21 -0600 Subject: [PATCH 1/3] set the ENTRY_POST_OP for modrdn betxnpostoperation plugins The ENTRY_POST_OP needs to be set before calling the betxnpostoperation plugins for the modrdn operation (e.g

[389-devel] Please review: Bug 740959 - 389-console put CA certificates into wrong database

2011-10-28 Thread Rich Megginson
https://bugzilla.redhat.com/show_bug.cgi?id=740959 https://bugzilla.redhat.com/attachment.cgi?id=530746action=edit -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: uniqueid formatting - use slapi_u8_to_hex instead of sprintf

2011-11-15 Thread Rich Megginson
From 17837f58fcf4f09c3df531f274bf8786b65e983a Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Tue, 15 Nov 2011 13:50:49 -0700 Subject: [PATCH] uniqueid formatting - use slapi_u8_to_hex instead of sprintf Use slapi_u8_to_hex for each part of the uuid to convert to string

[389-devel] Please review: reduce calls to csn_as_string and slapi_log_error

2011-11-16 Thread Rich Megginson
From d5312b2bd400695875c1fe68a6a54c612f09eec9 Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Tue, 15 Nov 2011 20:26:46 -0700 Subject: [PATCH] reduce calls to csn_as_string and slapi_log_error csn_as_string is an expensive operation - we should reduce calls to it many

[389-devel] Please review: csn_init_as_string should not use sscanf

2011-11-16 Thread Rich Megginson
From ce59c808793ff858bb0771830e000eb54982035c Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Wed, 16 Nov 2011 17:34:46 -0700 Subject: [PATCH] csn_init_as_string should not use sscanf Added new slapi functions to convert decimal/hex strings to their integral values. Use

[389-devel] Please review: use slapi_hexchar2int and slapi_str_to_u8 everywhere

2011-11-17 Thread Rich Megginson
From 1a0660f4fa2da22a6918078442afffba51c8c225 Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Thu, 17 Nov 2011 09:41:06 -0700 Subject: [PATCH] use slapi_hexchar2int and slapi_str_to_u8 everywhere uniqueid code was using local str2Byte - use slapi_str_to_u8 instead

[389-devel] Please review: bak2db gets stuck in infinite loop

2012-01-04 Thread Rich Megginson
https://fedorahosted.org/389/ticket/4 -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #162 - Infinite loop / spin inside strcmpi_fast, acl_read_access_allo, wed_on_attr, server DoS

2012-01-05 Thread Rich Megginson
https://fedorahosted.org/389/ticket/162 -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #256 - debug build assertion in ACL_EvalDestroy()

2012-01-11 Thread Rich Megginson
https://fedorahosted.org/389/ticket/256 https://fedorahosted.org/389/attachment/ticket/256/0001-Ticket-256-debug-build-assertion-in-ACL_EvalDestroy.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: fix mep sdn compiler warnings

2012-01-17 Thread Rich Megginson
From c17fc9b454c9757ab9f8b0fe3004ec1d1e75c0d3 Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Tue, 17 Jan 2012 14:46:15 -0700 Subject: [PATCH] fix mep sdn compiler warnings --- ldap/servers/plugins/mep/mep.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions

[389-devel] Please review: Ticket #257 repl-monitor doesn't work if leftmost hostnames are the same

2012-01-18 Thread Rich Megginson
https://fedorahosted.org/389/ticket/257 https://fedorahosted.org/389/attachment/ticket/257/0001-Ticket-257-repl-monitor-doesn-t-work-if-leftmost-hos.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: fix recent compiler warnings

2012-01-18 Thread Rich Megginson
From 8d4fa6d412b0bf911c063b371ad23d9257df312f Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Wed, 18 Jan 2012 13:23:30 -0700 Subject: [PATCH] fix recent compiler warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ../ds.git

[389-devel] Please review: fix new compiler warnings

2012-01-19 Thread Rich Megginson
From 01dd56d3e51180afef8158855ae0e747b43ba89a Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Thu, 19 Jan 2012 13:48:04 -0700 Subject: [PATCH] fix compiler warnings --- ldap/servers/plugins/linkedattrs/linked_attrs.h |1 + ldap/servers/plugins/memberof/memberof.c

[389-devel] Please review: Ticket #262 - pid file not removed with systemd

2012-01-20 Thread Rich Megginson
https://fedorahosted.org/389/ticket/262 https://fedorahosted.org/389/attachment/ticket/262/0001-Ticket-262-pid-file-not-removed-with-systemd.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: fix mozldap build issues

2012-01-20 Thread Rich Megginson
From 95cd59308ca30b46ed3eb5cf34f9d1642390f2f9 Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Fri, 20 Jan 2012 20:01:17 -0700 Subject: [PATCH] fix mozldap build issues ldap_start_tls_s needs ldap_ssl.h mozldap does not define LDAP_MAXINT --- .../servers/plugins

[389-devel] Please review: Ticket #263 - add systemd include directive

2012-01-23 Thread Rich Megginson
https://fedorahosted.org/389/ticket/263 https://fedorahosted.org/389/attachment/ticket/263/0001-Ticket-263-add-systemd-include-directive.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #272 - add tombstonenumsubordinates to schema

2012-01-24 Thread Rich Megginson
https://fedorahosted.org/389/ticket/272 https://fedorahosted.org/389/attachment/ticket/272/0001-Ticket-272-add-tombstonenumsubordinates-to-schema.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #29 - Samba3-schema is missing sambaTrustedDomainPassword

2012-01-27 Thread Rich Megginson
https://fedorahosted.org/389/ticket/29 https://fedorahosted.org/389/attachment/ticket/29/0001-Ticket-29-Samba3-schema-is-missing-sambaTrustedDomai.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #273: ruv tombstone searches don't work after reindex entryrdn

2012-01-30 Thread Rich Megginson
https://fedorahosted.org/389/ticket/273 https://fedorahosted.org/389/attachment/ticket/273/0001-Ticket-273-ruv-tombstone-searches-don-t-work-after-r.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #13 - slapd process exits when put the database on read only mode while updates are coming to the server

2012-02-01 Thread Rich Megginson
https://fedorahosted.org/389/ticket/13 https://fedorahosted.org/389/attachment/ticket/13/0001-Ticket-13-slapd-process-exits-when-put-the-database-.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] PAM plugin vs post op processing. New return code proposal...

2012-02-01 Thread Rich Megginson
On 02/01/2012 02:16 PM, Mark Reynolds wrote: Hi Everyone, There is an issue with the PAM plugin, that when it performs a successful bind we actually return error 1 to plugins_call_func(), which essentially causes the abort of the all plugin processing: the rest of pre-op, the backend call,

[389-devel] Please review: Ticket #277 - cannot set repl referrals or state

2012-02-02 Thread Rich Megginson
https://fedorahosted.org/389/ticket/277 https://fedorahosted.org/389/attachment/ticket/277/0001-Ticket-277-cannot-set-repl-referrals-or-state.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #278 - Schema replication update failed: Invalid syntax

2012-02-02 Thread Rich Megginson
https://fedorahosted.org/389/ticket/278 https://fedorahosted.org/389/attachment/ticket/278/0001-Ticket-278-Schema-replication-update-failed-Invalid-.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: coverity 12488 Resource leak In attr_index_config()

2012-02-03 Thread Rich Megginson
From 9970496be27d5707330e15a4fde0705b88e1e195 Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Fri, 3 Feb 2012 14:16:41 -0700 Subject: [PATCH] coverity 12488 Resource leak In attr_index_config(): Leak of memory or pointers to system resources need to free a in case

[389-devel] Please review: Ticket #313 - valgrind reported memleaks and mem errors

2012-03-02 Thread Rich Megginson
https://fedorahosted.org/389/ticket/313 -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #289 - allow betxn plugin config changes

2012-03-05 Thread Rich Megginson
https://fedorahosted.org/389/ticket/289 This is the git format-patch file - https://fedorahosted.org/389/attachment/ticket/289/0001-Ticket-289-allow-betxn-plugin-config-changes.patch The formatting of the dse code was terrible. So I reformatted it. Here is the diff with the whitespace-only

Re: [389-devel] Please review: coverity 12563 Read from pointer after free

2012-03-07 Thread Rich Megginson
On 03/07/2012 07:53 AM, Nathan Kinder wrote: An additional fix is needed for this issue. Your patch fixed the dna_pre_op() function, but the same issue exists in the dna_be_txn_pre_op() function. The attached patch takes care of this. ack On 03/06/2012 09:30 AM, Rich Megginson wrote

Re: [389-devel] please review replication code cleanup

2012-03-08 Thread Rich Megginson
On 03/08/2012 02:28 PM, Mark Reynolds wrote: While working on ticket 271, I found that the code was almost unreadable in repl5_inc_run(). The tabs and spacing were all over the place. So wanted to get this code cleanup checked in before I start working on a fix, etc. ack Thanks, Mark --

[389-devel] Please review: Ticket #324 - Sync with group attribute containing () fails

2012-03-23 Thread Rich Megginson
https://fedorahosted.org/389/ticket/324 https://fedorahosted.org/389/attachment/ticket/324/0001-Ticket-324-Sync-with-group-attribute-containing-fail.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: 389-admin: htmladmin

2012-03-23 Thread Rich Megginson
On 03/23/2012 02:20 PM, Noriko Hosoi wrote: If htmladmin fails to connect to the server, the cgi could crash. This patch checks the flag for the server status and avoids the unnecessary free. ack -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] requirements for replica removal robustness

2012-04-05 Thread Rich Megginson
389 doesn't seem to handle replica removal very well. The removed replica remains in the RUV element on all other servers. The http://port389.org/wiki/Howto:CLEANRUV task exists for this purpose, but you have to run it on all masters simultaneously, or the removed replica will show up

[389-devel] Please review: Ticket #348 - crash in ldap_initialize with multiple threads

2012-04-24 Thread Rich Megginson
https://fedorahosted.org/389/ticket/348 https://fedorahosted.org/389/attachment/ticket/348/0001-Ticket-348-crash-in-ldap_initialize-with-multiple-th.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #353 - coverity 12625-12629 - leaks, dead code, unchecked return

2012-05-02 Thread Rich Megginson
https://fedorahosted.org/389/ticket/353 https://fedorahosted.org/389/attachment/ticket/353/0001-Ticket-353-coverity-12625-12629-leaks-dead-code-unch.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] [ds.git] [PATCH 1/1]: Do not check port availability during forced setup

2012-05-02 Thread Rich Megginson
On 04/21/2012 07:18 AM, Jeroen van Meeuwen (Kolab Systems) wrote: Hi there, In a scenario where I'm trying to setup a 389 Directory Server automatically, I ran into an issue with checking ports - no ports nor any networking, are available when I execute the setup. FWIW, I'm bootstrapping the

[389-devel] 389-ds-base-1.2.11 is branched

2012-05-02 Thread Rich Megginson
I pushed the 389-ds-base-1.2.11 branch and released 389-ds-base-1.2.11.1 Unless you have fixes that are required to get into 1.2.11, just continue to use master -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #358 - managed entry doesn't delete linked entry

2012-05-04 Thread Rich Megginson
This patch passes entryusn, dna, managedentry, automember, memofenhancement, and linkedattrs tests. I'm running a full acceptance test now. Please let me know if you see any problems. https://fedorahosted.org/389/ticket/358

[389-devel] Please review: Ticket #382 - DS Shuts down intermittently

2012-05-22 Thread Rich Megginson
https://fedorahosted.org/389/ticket/382 https://fedorahosted.org/389/attachment/ticket/382/0001-Ticket-382-DS-Shuts-down-intermittently.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #383 - usn + mmr = deletions are not replicated

2012-05-24 Thread Rich Megginson
https://fedorahosted.org/389/ticket/383 https://fedorahosted.org/389/attachment/ticket/383/0003-Ticket-383-usn-mmr-deletions-are-not-replicated.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] please review Coverity Fixes

2012-06-13 Thread Rich Megginson
On 06/13/2012 03:46 PM, Mark Reynolds wrote: Attached... ack Thanks, Mark -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Ticket #360 ldapmodify returns Operations error

2012-06-15 Thread Rich Megginson
https://fedorahosted.org/389/ticket/360 https://fedorahosted.org/389/attachment/ticket/360/0005-Ticket-360-ldapmodify-returns-Operations-error-fix-d.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Redux: Please review: Ticket #387 - managed entry sometimes doesn't delete the managed entry

2012-06-18 Thread Rich Megginson
https://fedorahosted.org/389/ticket/387 https://fedorahosted.org/389/attachment/ticket/387/0001-Ticket-387-managed-entry-sometimes-doesn-t-delete-th.patch https://fedorahosted.org/389/attachment/ticket/387/0002-Ticket-387-managed-entry-sometimes-doesn-t-delete-th.3.patch -- 389-devel mailing

[389-devel] Please review: Ticket #405 - referint modrdn not working if case is different

2012-07-09 Thread Rich Megginson
https://fedorahosted.org/389/ticket/405 https://fedorahosted.org/389/attachment/ticket/405/0001-Ticket-405-referint-modrdn-not-working-if-case-is-di.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Setting up 389 DS without DNS

2012-07-23 Thread Rich Megginson
On 07/23/2012 02:46 PM, Chaudhari, Rohit K. wrote: Hey 389 community, I had a question. We want to set up 389-ds on a Red Hat VM without DNS. I read online that disabling SELinux would allow us to accomplish this. Is this true or false? False. AFAIK it has nothing to do with SELinux.

Re: [389-devel] Setting up 389 DS without DNS

2012-07-24 Thread Rich Megginson
. 192.168.122.2 myhost.mydomain.com myhost If there is anything simpler or something that I missed just let me know. No, that's it. That's what I use for doing TLS/SSL testing among virtual machines on the same host system. Thanks. -Original Message- From: Rich Megginson [mailto:rmegg

Re: [389-devel] Setting up 389 DS without DNS

2012-07-24 Thread Rich Megginson
is not required to get this to work. Thanks for your time and speedy responses this morning. -Original Message- From: Rich Megginson [mailto:rmegg...@redhat.com] Sent: Tuesday, July 24, 2012 10:55 AM To: Chaudhari, Rohit K. Cc: 389 Directory server developer discussion. Subject: Re: [389-devel

Re: [389-devel] Setting up 389 DS without DNS

2012-07-24 Thread Rich Megginson
or DNS or whatever doesn't matter. Thanks. -Original Message- From: Rich Megginson [mailto:rmegg...@redhat.com] Sent: Tuesday, July 24, 2012 11:00 AM To: Chaudhari, Rohit K. Cc: 389 Directory server developer discussion. Subject: Re: [389-devel] Setting up 389 DS without DNS On 07/24/2012 08

Re: [389-devel] Please Review : Decreasing MAX Replication Retry time

2012-11-19 Thread Rich Megginson
. The default 5 minutes is too long? Thanks, Divya.R *From:*Rich Megginson [mailto:rmegg...@redhat.com] *Sent:* Friday, November 16, 2012 8:11 PM *To:* 389 Directory server developer discussion. *Cc:* Divya Ravikumar *Subject:* Re: [389-devel] Please Review : Decreasing MAX Replication Retry time On 11

Re: [389-devel] Regarding changing instance specific scripts to be global/generic

2013-02-04 Thread Rich Megginson
On 02/04/2013 09:42 AM, Mark Reynolds wrote: There has been a request to remove instance specific scripts, and make them generic and placed in /usr/sbin/ https://fedorahosted.org/389/ticket/528 Should we remove all the scripts from /usr/lib64/dirsrv/slapd-INSTANCE: bak2db db2index

Re: [389-devel] Regarding changing instance specific scripts to be global/generic

2013-02-04 Thread Rich Megginson
On 02/04/2013 11:39 AM, Mark Reynolds wrote: On 02/04/2013 12:16 PM, Rich Megginson wrote: On 02/04/2013 09:42 AM, Mark Reynolds wrote: There has been a request to remove instance specific scripts, and make them generic and placed in /usr/sbin/ https://fedorahosted.org/389/ticket/528

[389-devel] Please review: Ticket #47303 - start/stop/restart dirsrv scripts should report and error if no instances

2013-03-22 Thread Rich Megginson
https://fedorahosted.org/389/ticket/47303 https://fedorahosted.org/389/attachment/ticket/47303/0003-Ticket-47303-start-stop-restart-dirsrv-scripts-shoul.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: take 2 - Ticket #47303 - start/stop/restart dirsrv scripts should report and error if no instances

2013-03-22 Thread Rich Megginson
Please see https://fedorahosted.org/389/ticket/47303#comment:4 https://fedorahosted.org/389/ticket/47303 https://fedorahosted.org/389/attachment/ticket/47303/0003-Ticket-47303-start-stop-restart-dirsrv-scripts-shoul.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Ticket #47302 - get rid of sbindir start/stop/restart slapd scripts

2013-03-25 Thread Rich Megginson
get rid of man pages too https://fedorahosted.org/389/ticket/47302 https://fedorahosted.org/389/attachment/ticket/47302/0001-Ticket-47302-get-rid-of-sbindir-start-stop-restart-s.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Ticket #613 - ldclt: add timestamp, interval, nozeropad, other improvements

2013-03-29 Thread Rich Megginson
Needed to fix value wrap around in incremental mode https://fedorahosted.org/389/ticket/613 https://fedorahosted.org/389/attachment/ticket/613/0001-Ticket-613-ldclt-add-timestamp-interval-nozeropad-ot.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: Ticket #47320 - put conn on work_q not poll list if conn has buffered more_data

2013-04-09 Thread Rich Megginson
https://fedorahosted.org/389/attachment/ticket/47320/0004-Ticket-47320-put-conn-on-work_q-not-poll-list-if-con.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please Review: Add make rpms build target

2013-04-19 Thread Rich Megginson
On 04/19/2013 12:54 PM, Nathan Kinder wrote: Hi, Please review the attached patch that adds the ability for convenient developer RPM builds. Details are in the patch description. Note that my patch does not include any changes that will be made by running autogen.sh. I did this to make

Re: [389-devel] Please Review: Add make rpms build target

2013-04-19 Thread Rich Megginson
On 04/19/2013 01:21 PM, Nathan Kinder wrote: On 04/19/2013 12:04 PM, Rich Megginson wrote: On 04/19/2013 12:54 PM, Nathan Kinder wrote: Hi, Please review the attached patch that adds the ability for convenient developer RPM builds. Details are in the patch description. Note that my patch

Re: [389-devel] Please Review: Allow RPM builds to be run without configure

2013-04-19 Thread Rich Megginson
On 04/19/2013 07:24 PM, Nathan Kinder wrote: HI, The previous patch for supporting developer RPM builds was useless for cases where you want to use mock for building. This new patch makes things more friendly for mock builds. It also eliminates the need to run configure before trying to

[389-devel] Please review: Ticket #47341 - logconv.pl -m time calculation is wrong

2013-04-22 Thread Rich Megginson
https://fedorahosted.org/389/attachment/ticket/47341/0001-Ticket-47341-logconv.pl-m-time-calculation-is-wrong.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: take 3: Ticket #47299 - allow cmdline scripts to work with non-root user

2013-04-25 Thread Rich Megginson
https://fedorahosted.org/389/attachment/ticket/47299/0001-Ticket-47299-allow-cmdline-scripts-to-work-with-non-.3.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: take 4: Ticket #47299 - allow cmdline scripts to work with non-root user

2013-04-25 Thread Rich Megginson
https://fedorahosted.org/389/attachment/ticket/47299/0001-Ticket-47299-allow-cmdline-scripts-to-work-with-non-.4.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: take 5: Ticket #47299 - allow cmdline scripts to work with non-root user

2013-04-25 Thread Rich Megginson
https://fedorahosted.org/389/attachment/ticket/47299/0001-Ticket-47299-allow-cmdline-scripts-to-work-with-non-.5.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #47359 - new ldap connections can block ldaps and ldapi connections

2013-05-21 Thread Rich Megginson
https://fedorahosted.org/389/attachment/ticket/47359/0001-Ticket-47359-new-ldap-connections-can-block-ldaps-an.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #47377 - make listen backlog size configurable

2013-05-30 Thread Rich Megginson
https://fedorahosted.org/389/attachment/ticket/47377/0001-Ticket-47377-make-listen-backlog-size-configurable.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #47378 - fix recent compiler warnings

2013-06-05 Thread Rich Megginson
https://fedorahosted.org/389/attachment/ticket/47378/0001-Ticket-47378-fix-recent-compiler-warnings.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket 47427 - Overflow in nsslapd-disk-monitoring-threshold

2013-07-26 Thread Rich Megginson
https://fedorahosted.org/389/attachment/ticket/47427/0001-Ticket-47427-Overflow-in-nsslapd-disk-monitoring-thr.4.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #47448 - Segfault in 389-ds-base-1.3.1.4-1.fc19 when setting up FreeIPA replication

2013-07-29 Thread Rich Megginson
https://fedorahosted.org/389/attachment/ticket/47448/0001-Ticket-47448-Segfault-in-389-ds-base-1.3.1.4-1.fc19-.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Ticket #47455 - valgrind - value mem leaks, uninit mem usage

2013-07-29 Thread Rich Megginson
https://fedorahosted.org/389/attachment/ticket/47455/slapd.vg.22729 https://fedorahosted.org/389/attachment/ticket/47455/0001-Ticket-47455-valgrind-value-mem-leaks-uninit-mem-usa.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org

  1   2   >