[389-devel] Re: Trac -> Pagure migration is complete

2017-02-13 Thread Simon Pichugin
On Sat, Feb 11, 2017 at 05:23:24PM -0500, Mark Reynolds wrote: >Our migration to Pagure is complete. Please use this project for >filing Directory Server issues (aka Tickets): >[1]https://pagure.io/389-ds-base >Trac is now in read-only mode. If you need help with any of this just

[389-devel] Please review: Issue 49147 - Fix tests compatibility with older versions

2017-02-24 Thread Simon Pichugin
Hi team, please, review the patch with fixes related to older builds. Also, I think I dont havea permission to set reviewstatus. Please, advise. https://pagure.io/389-ds-base/issue/49147 https://pagure.io/389-ds-base/issue/raw/files/e4578799a772b2ff2e0a1e02429c849552bb7f2e79f2bdb333db40dcc5e37d6b

[389-devel] Please review: Issue 49156 - Clean up test suites dir structure and docstrings

2017-03-05 Thread Simon Pichugin
Hi team, please, review my test suites clean up. Also, Amita, please, review the Polarion test plans part, if the fields fit the importer. https://pagure.io/389-ds-base/issue/49156 https://pagure.io/389-ds-base/issue/raw/files/0a0f06b64b6657be75436832cdd41e67dd5b383da2600787a34a7817b2d38602-0001-

[389-devel] Please review: Issue 49156 - Add more IDs and fix docstrings

2017-03-09 Thread Simon Pichugin
Hi team, please, review my small patch that should fix the points I've missed. https://pagure.io/389-ds-base/issue/49156 https://pagure.io/389-ds-base/issue/raw/files/f8e868bd9c2af26e54a63e56cefdf7b7d318c0550f1d619cea21af6533ff9254-0001-Issue-49156-Add-more-IDs-and-fix-docstrings.patch Thanks, Si

[389-devel] Re: Please review: Issue 49156 - Add more IDs and fix docstrings

2017-03-09 Thread Simon Pichugin
On Thu, Mar 09, 2017 at 04:51:54PM +0100, Simon Pichugin wrote: > Hi team, > please, review my small patch that should fix the points I've missed. > > https://pagure.io/389-ds-base/issue/49156 > https://pagure.io/389-ds-

[389-devel] Please review: Issue 7 - Add pause and resume methods to topology fixtures

2017-03-21 Thread Simon Pichugin
Hi team, for replication test suite I need a tool that can stop the replication on a big amount of agreements (4 and more, for instance). Please, review the patch: https://pagure.io/lib389/issue/7 https://pagure.io/lib389/issue/raw/files/b60a5748102ee2a48a8d3b79d6e0b8d5509eca28911edd4c61c4538354e9

[389-devel] Please review: New test cases and lib389 fix

2017-04-04 Thread Simon Pichugin
Hi team, please, review my new test cases for replication acceptance test suite and a small fix for lib389. https://pagure.io/389-ds-base/issue/48085 https://pagure.io/389-ds-base/issue/raw/files/a9826a42730d4ffad4ae826ef9d5e96fa585e06c1dcf67b4e9854a50ca659601-0001-Issue-48085-Expand-the-repl-acce

[389-devel] Please review: Issue 22 - Specify a basedn parameter for IDM modules

2017-04-11 Thread Simon Pichugin
Hi team, please, review a small change: https://pagure.io/lib389/issue/22 https://pagure.io/lib389/issue/raw/files/df2047a8be8107ef8a3b31c5a20518a5963e42d98fd07540541164653858318c-0001-Issue-22-Specify-a-basedn-parameter-for-IDM-modules.patch Thanks, Simon signature.asc Description: PGP signatu

[389-devel] Config attribute - nsslapd-allowed-sasl-mechanisms - behaviour

2017-04-20 Thread Simon Pichugin
Hello William, I think my question is for you in the first place. It regards the default attributes for cn=config feature. Version tested: 389-ds-base-1.3.6.1-9.el7.x86_64 During TET troubleshooting I've faced two issues: 1. By default, we have: [root@qeos-126 dirsrv-tet-install]# ldapsearch -h l

[389-devel] Re: Config attribute - nsslapd-allowed-sasl-mechanisms - behaviour

2017-04-20 Thread Simon Pichugin
On Fri, Apr 21, 2017 at 09:25:23AM +1000, William Brown wrote: > On Thu, 2017-04-20 at 22:54 +0200, Simon Pichugin wrote: > > Hello William, > > I think my question is for you in the first place. > > It regards the default attributes for cn=config feature. > > >

[389-devel] Re: Config attribute - nsslapd-allowed-sasl-mechanisms - behaviour

2017-04-23 Thread Simon Pichugin
On Fri, Apr 21, 2017 at 04:02:50PM +1000, William Brown wrote: > On Fri, 2017-04-21 at 07:55 +0200, Simon Pichugin wrote: > > On Fri, Apr 21, 2017 at 09:25:23AM +1000, William Brown wrote: > > Partly, yes. My question was about possible regression. > > > > We have

[389-devel] Please review: Issue 27 - Add a module for working with dse.ldif file

2017-05-04 Thread Simon Pichugin
Hi team, please review a new patch to lib389. For some tests we need a way to parse and edit dse.ldif file. For starters, it will be nice to have next operations support: - get - Return attribute values under a given entry; - add - Add an attribute under a given entry; - delete - Delete singlev

[389-devel] Please review: Add new DSEldif object

2017-05-15 Thread Simon Pichugin
Hi team, please, review small improvement for DSEldif API module: https://pagure.io/lib389/issue/27 https://pagure.io/lib389/issue/raw/files/bec12d1fa4aa1e66f2915c62c6a7bc61c7ffa53c06c225ca8f0d663b1f664131-0001-Add-new-DSEldif-object.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Add autotuning test suite (and Test Plan review)

2017-05-16 Thread Simon Pichugin
Hi team, please, review the test plan and the code. There is a few failures that probably reviel new bugs. Or the test cases are wrong (I expect wrong behaviour for example). Anyway, please, share you thoughts. https://pagure.io/389-ds-base/issue/49021 https://pagure.io/389-ds-base/issue/raw/file

[389-devel] Please review: Issue 49028 - Add autotuning test suite

2017-05-24 Thread Simon Pichugin
Hi team, please review my revised patch: https://pagure.io/389-ds-base/issue/49021 https://pagure.io/389-ds-base/issue/raw/2d03c0b6d91bf17bbf60021262c03401fd0af2d3f00466654b3aa24f7683b74f-0001-Issue-49028-Add-autotuning-test-suite.patch Thanks, Simon signature.asc Description: PGP signature ___

[389-devel] Please review: Issue 27 - Fix get function in tests

2017-05-28 Thread Simon Pichugin
Hi team, please, review a small fix: https://pagure.io/lib389/issue/27 https://pagure.io/lib389/issue/raw/f27d207209b87666524e606364971bcb44f302c20df107d4901fc9e18f6bd5fe-0001-Issue-27-Fix-get-function-in-tests.patch Thanks, Simon signature.asc Description: PGP signature ___

[389-devel] Please review: Issue 623 - Add test case and refactor the cleanallruv suite

2017-06-19 Thread Simon Pichugin
Hi team, please, review a patch: https://pagure.io/389-ds-base/issue/623 https://pagure.io/389-ds-base/issue/raw/59ae3de25d0f7dccc880c062c640bf7ef2b3fd1c8b737f51e97bfc75bbcaa9a7-0001-Issue-623-Add-test-case-and-refactor-the-cleanallruv.patch Thanks, Simon signature.asc Description: PGP signatur

[389-devel] Please review: Issue 49301 - Add one logpipe test case

2017-06-27 Thread Simon Pichugin
Hi team, please, review the new patch for suites/ds-tools: https://pagure.io/389-ds-base/issue/49301 https://pagure.io/389-ds-base/issue/raw/704b8814bfbd0b13c6e04f3c696a633d3fb236bc927e41827f32e4a58768ce7e-0001-Issue-49301-Add-one-logpipe-test-case.patch Thanks, Simon signature.asc Description:

[389-devel] Please review: Draft of the big lib389 and pytest guide

2017-07-19 Thread Simon Pichugin
Hi team, https://pagure.io/lib389/issue/77#comment-449299 https://pagure.io/lib389/issue/raw/2aef109dbf0f23a359c15f209c6c523cebda4faf583125ff62e0a228f8c3b321-Guidelines-for-using-pytest-and-lib389_47541162.html Thanks, Simon signature.asc Description: PGP signature _

[389-devel] Please review: Issue 79 - Fix replica.py and add tests

2017-07-27 Thread Simon Pichugin
Hi team, please review a patch that fixes Replicas DSLdapObject. https://pagure.io/lib389/issue/79 https://pagure.io/lib389/issue/raw/files/febe12b17a148405c527ed4938a9ef06c1d5046c9c3070ad32a0770526f33ee0-0001-Issue-79-Fix-replica.py-and-add-tests.patch Thanks, Simon signature.asc Description:

[389-devel] Re: Please review: Issue 79 - Fix replica.py and add tests

2017-07-31 Thread Simon Pichugin
/80825f0aee3bcb098b89d442af4526df8b13e2082496de83669dc4220199002e-0001-Issue-79-Fix-replica.py-and-add-tests.patch Thanks, Simon On Thu, Jul 27, 2017 at 03:14:59PM +0200, Simon Pichugin wrote: > Hi team, > please review a patch that fixes Replicas DSLdapObject. > > https://pagure.io/lib

[389-devel] Re: Please review: Issue 79 - Fix replica.py and add tests

2017-08-02 Thread Simon Pichugin
ps://pagure.io/lib389/issue/raw/files/80825f0aee3bcb098b89d442af4526df8b13e2082496de83669dc4220199002e-0001-Issue-79-Fix-replica.py-and-add-tests.patch > > Thanks, > Simon > > On Thu, Jul 27, 2017 at 03:14:59PM +0200, Simon Pichugin wrote: > > Hi team, > > please

[389-devel] Re: Please review: Draft of the big lib389 and pytest guide

2017-08-03 Thread Simon Pichugin
Hi team, a new version: https://pagure.io/lib389/issue/77#comment-451622 https://pagure.io/lib389/issue/raw/files/6047ac156e06192837271afc2770a83f7f3206400669537bb1d8f43ab7b9a434-Guidelines-for-using-pytest-and-lib389_47541162.html Thanks, Simon On Wed, Jul 19, 2017 at 04:31:50PM +0200, Simon

[389-devel] Please review: Issue 83 - Add an util for generating instance parameters

2017-08-04 Thread Simon Pichugin
Hi team, please, review a new patch for big topology refactoring. I'll add a patch for 389-ds-base tests before the pushing it. https://pagure.io/lib389/issue/83 https://pagure.io/lib389/issue/raw/files/57003067766f1a08da96060e1d51e95583cc5a43ef98d73991fb2576a50501ce-0001-Issue-83-Add-an-util-for-

[389-devel] Please review: issue 77, issue 79, issue 83

2017-08-08 Thread Simon Pichugin
Hi team, please, check out the issues. They were updated recently (or just waiting for the review): https://pagure.io/lib389/issue/77 https://pagure.io/lib389/issue/raw/files/6047ac156e06192837271afc2770a83f7f3206400669537bb1d8f43ab7b9a434-Guidelines-for-using-pytest-and-lib389_47541162.html http

[389-devel] Re: future of lib389 - seperate or merged?

2017-08-08 Thread Simon Pichugin
On Tue, Aug 01, 2017 at 04:00:23PM +1000, William Brown wrote: > My vote is to merge them. I came to this decision because I believe that > this will make development against multiple branches easier with regard > to testing and backport of patches. For example, we'll know that lib389 > that's insi

[389-devel] Re: Please review: Issue 79 - Fix replica.py and add tests

2017-08-09 Thread Simon Pichugin
, Simon Pichugin wrote: > Add enum34 to requirements.txt for py2 compatibility > > https://pagure.io/lib389/issue/79 > https://pagure.io/lib389/issue/raw/files/7be353523a4a7ad8382a9a98ad778819f5e7557ab1812b9d1e595499ef821244-0001-Issue-79-Fix-replica.py-and-add-tests.patch > > On

[389-devel] Issue 83 - lib389 - Replace topology agmt objects

2017-08-09 Thread Simon Pichugin
Hi team, please review a patch for 389-ds-base tests: https://pagure.io/lib389/issue/83 https://pagure.io/lib389/issue/raw/files/9d807e6ff14eb4df440feea988db6f94794eba9d40b3204b8ed8286d9fce3dff-0001-Issue-83-lib389-Replace-topology-agmt-objects.patch Thanks, Simon signature.asc Description: PGP

[389-devel] Issue 83, 79 - lib389 - Fix tests and create_test.py - Replica fix

2017-08-10 Thread Simon Pichugin
Hi team, some of the tests in 389-ds-base are broken. The following patches should fix them: For 389-ds-base: https://pagure.io/lib389/issue/83 https://pagure.io/lib389/issue/raw/files/7ce24a6d79ce0242a200354133f65d910af46f1f73da7497d45312cd19280f44-0001-Issue-83-lib389-Fix-tests-and-create_test.p

[389-devel] Please review: Issue 91 - Fix replication m1h1c1 topology

2017-08-12 Thread Simon Pichugin
Hi team, https://pagure.io/lib389/issue/91 https://pagure.io/lib389/issue/raw/files/f9874b05dcab8b6e01517163218c9572b14373b8809cf93a1a38827c3db1873f-0001-Issue-91-Fix-replication-m1h1c1-topology.patch Thanks, Simon signature.asc Description: PGP signature

[389-devel] Please review: Issue 85 - Remove legacy replication attribute

2017-08-15 Thread Simon Pichugin
Hi team, please, review the patch for lib389. I've checked, it fixes tickets/ticket48325_test.py. https://pagure.io/lib389/issue/85 https://pagure.io/lib389/issue/raw/files/d5d0b94c97f8d341f4785e76c94c719d3902b80c3f339f047a9e95316ff28dcd-0001-Issue-85-Remove-legacy-replication-attribute.patch Tha

[389-devel] Please review: Issue #77 - Add sphinx documentation

2017-08-28 Thread Simon Pichugin
Hi team, Most of the comments were applied. Thanks! Now the layout is: - index.rst - welcoming word, Table of Contents and Contact Us. - guidelines.rst - is included into index.rst and contains basic test development workflow, pytest features overview, and basic lib389 and python-ldap features

[389-devel] Please review: Issue #77 - Refactor docstrings in rST format - part 1

2017-09-06 Thread Simon Pichugin
Hi team, please, check out the new docs. https://fedorapeople.org/~spichugi/html/index.html https://pagure.io/lib389/issue/77 https://pagure.io/lib389/issue/raw/files/2e181d5321f194587899b1cbb37455d86d2754daeacb2d02c6de60aa9830b079-0001-Issue-77-Refactor-docstrings-in-rST-format-part-1.patch T

[389-devel] Please review: Issue #77 - Fix changelogdb param issue

2017-09-11 Thread Simon Pichugin
Hi team, please, review: https://pagure.io/lib389/issue/77 https://pagure.io/lib389/issue/raw/files/486d6f41143e829fde00c722747e95d4ad03efafd0680b1e78f1c95ec693c3c0-0001-Issue-77-Fix-changelogdb-param-issue.patch Thanks, Simon signature.asc Description: PGP signature ___

[389-devel] Please review: Issue 49381 - Refactor numerous suite docstrings

2017-09-15 Thread Simon Pichugin
Hi team, please, review the patch for suite docs. https://pagure.io/389-ds-base/issue/49381 https://pagure.io/389-ds-base/issue/raw/files/5e909fe03f497ebad570a73364de1c2145f5c9b99d88c0543628ff5c0f0b038a-0001-Issue-49381-Refactor-numerous-suite-docstrings.patch Thanks, Simon signature.asc Descr

[389-devel] Re: Please review: Issue 49381 - Refactor numerous suite docstrings

2017-09-19 Thread Simon Pichugin
New version: https://pagure.io/389-ds-base/issue/49381 https://pagure.io/389-ds-base/issue/raw/files/afa9b1a73b02e21633279b939d02deff33328cdc100b4c7c80645dd6b532f7ac-0001-Issue-49381-Refactor-numerous-suite-docstrings.patch On Fri, Sep 15, 2017 at 05:42:20PM +0200, Simon Pichugin wrote: > Hi t

[389-devel] Re: Please review: Issue 49381 - Refactor numerous suite docstrings

2017-09-19 Thread Simon Pichugin
New version: https://pagure.io/389-ds-base/issue/49381 https://pagure.io/389-ds-base/issue/raw/files/525619ec2b6d51ca4a78998e6b40c43d344e19d180e97ee67f1e09c82721f86f-0001-Issue-49381-Refactor-numerous-suite-docstrings.patch On Fri, Sep 15, 2017 at 05:42:20PM +0200, Simon Pichugin wrote: > Hi t

[389-devel] Please review: Issue 99 - Fix typo in create_topology

2017-09-24 Thread Simon Pichugin
Hi team, please review two line patch. https://pagure.io/lib389/issue/99 https://pagure.io/lib389/issue/raw/files/f3e504a5779b08eedf743645be3ab3af601213a5f35e9e44dd7f02254a43f72c-0001-Issue-99-Fix-typo-in-create_topology.patch Thanks, Simon signature.asc Description: PGP signature _

[389-devel] Please review: Issue 49381 - Refactor numerous suite docstrings - Part 2

2017-10-06 Thread Simon Pichugin
Hi team, please, review my second patch for suite docstrings: https://pagure.io/389-ds-base/issue/49381 https://pagure.io/389-ds-base/issue/raw/files/350ce1073ac05a722674475b679a346142e0b000b244df5c242b877ddd316a86-0001-Issue-49381-Refactor-numerous-suite-docstrings-Part-.patch Thanks, Simon si

[389-devel] Re: Please review: Issue 49381 - Refactor numerous suite docstrings - Part 2

2017-10-16 Thread Simon Pichugin
Fixed the issues: https://pagure.io/389-ds-base/issue/49381 https://pagure.io/389-ds-base/issue/raw/files/b050293a47890b3527564aa336937830b0fc298a90037f972e46d49477134a24-0001-Issue-49381-Refactor-numerous-suite-docstrings-Part-.patch On Fri, Oct 06, 2017 at 03:27:36PM +0200, Simon Pichugin wrote

[389-devel] Please review: Issue lib389 3 - Python 3 support for ACL test suite

2017-10-20 Thread Simon Pichugin
Hi team, please, review the Python 3 support patch for ACL. Also, please, check it if you are a developer. Because it contains the indended way to use lib389 feature for Python 3 support. https://pagure.io/lib389/issue/3 https://pagure.io/lib389/issue/raw/files/f5707f366a5769c0232aaa0a0270db72372

[389-devel] Re: Please review: Issue lib389 3 - Python 3 support for ACL test suite

2017-11-03 Thread Simon Pichugin
On Fri, Oct 20, 2017 at 12:14:12PM +0200, Simon Pichugin wrote: > Hi team, > please, review the Python 3 support patch for ACL. > > Also, please, check it if you are a developer. Because it contains > the indended way to use lib389 feature for Python 3 support. > > https://p

[389-devel] Please review: Issue 48393 - Add a test case for nsds5ReplicaId checks

2017-11-07 Thread Simon Pichugin
https://pagure.io/389-ds-base/issue/48393 https://pagure.io/389-ds-base/issue/raw/files/a900cbac9d8d6ed0bd14a424dd966cca4233a1376fb392c2129d5987d3073f90-0001-Issue-48393-Add-a-test-case-for-nsds5ReplicaId-check.patch signature.asc Description: PGP signature ___

[389-devel] Re: Please review: Issue #77 - Refactor docstrings in rST format - part 2

2017-11-15 Thread Simon Pichugin
A second part: https://pagure.io/lib389/issue/77 https://pagure.io/lib389/issue/raw/files/b050293a47890b3527564aa336937830b0fc298a90037f972e46d49477134a24-0001-Issue-49381-Refactor-numerous-suite-docstrings-Part-.patch On Wed, Sep 06, 2017 at 07:33:24PM +0200, Simon Pichugin wrote: > Hi t

[389-devel] Re: Please review: Issue #77 - Refactor docstrings in rST format - part 2

2017-11-15 Thread Simon Pichugin
https://pagure.io/lib389/issue/raw/files/a7f959f31cfd6f5b4f837dd715bf1d0beb96a182e30a0c1b13bfc4d3cdfbc905-0001-Issue-lib389-77-Refactor-docstrings-in-rST-format-pa.patch On Wed, Nov 15, 2017 at 04:44:07PM +0100, Simon Pichugin wrote: > A second part: > > https://pagure.io/lib389/issue/7

[389-devel] Please review: Issue 49408- Add a test case for nsds5ReplicaId checks

2017-11-20 Thread Simon Pichugin
Hi team, please, review a small test case I need to verify BZ: https://pagure.io/389-ds-base/issue/49408 https://pagure.io/389-ds-base/issue/raw/files/f5457f377c15dd5d35d153baa775a8be15f883c419d929fb41a4203be145a200-0001-Issue-49408-Add-a-test-case-for-nsds5ReplicaId-check.patch Thanks, Simon s

[389-devel] Please review: Issue 47536 - Add Python 3 support and move test case to suites

2017-11-23 Thread Simon Pichugin
Hi team, please, review the Python 3 support patch. https://pagure.io/389-ds-base/issue/47536 https://pagure.io/389-ds-base/issue/raw/files/1cdbed5b2520a0f85c950305ee3f40e605f8d263129ff70996952ba8ac94d895-0001-Issue-47536-Add-Python-3-support-and-move-test-case-.patch Thanks, Simon signature.as

[389-devel] Re: Please review: Issue 47536 - Add Python 3 support and move test case to suites

2017-11-24 Thread Simon Pichugin
I've fixed the issues: https://pagure.io/389-ds-base/issue/raw/files/e023d32821b13103e662b94b1348a0a3016b3ea15fd24b4e2bebfefbdae9e8e6-0001-Issue-47536-Add-Python-3-support-and-move-test-case-.patch On Thu, Nov 23, 2017 at 03:53:17PM +0100, Simon Pichugin wrote: > Hi team, > please,

[389-devel] Please review: Issue 49374 - Add CI test case

2017-11-28 Thread Simon Pichugin
Hi team, please review a small test case: https://pagure.io/389-ds-base/issue/49374 https://pagure.io/389-ds-base/issue/raw/files/f23c2afa41b204756126c621b8a0c12678179048a725e587f775b0a4cfc19200-0001-Issue-49374-Add-CI-test-case.patch Thanks, Simon signature.asc Description: PGP signature _

[389-devel] Re: PR's might now be an option!

2018-01-03 Thread Simon Pichugin
On Thu, Jan 04, 2018 at 10:33:35AM +1000, William Brown wrote: > Hi all, > > We recently have completed two PR based merges, both went successfully. > > I think it's time we bring up again the option of allowing PR's as a > main workflow for the project. > > I think we can allow both PR + patch

[389-devel] Please review: Ticket 49523 - Refactor CI test

2018-01-08 Thread Simon Pichugin
https://pagure.io/389-ds-base/issue/49523 https://pagure.io/389-ds-base/issue/raw/files/da1e9819a28050aed3d00828a1b8212f19420411d6fd8e11aabe7a6776f851c3-0001-Ticket-49523-Refactor-CI-test.patch signature.asc Description: PGP signature ___ 389-devel mai

[389-devel] Please review: Issue 49043 - Add a test suite

2018-02-01 Thread Simon Pichugin
Hi team, I'll be on PTO 02.02, I'll check the comments on Monday https://pagure.io/389-ds-base/pull-request/49558 Practicing pull-requests. Also, the test will fail at the tearDown. It will be fixed in https://pagure.io/389-ds-base/issue/49551 Thanks!

[389-devel] Please review: Issue 48085 - Add encryption cl5 test suite

2018-02-06 Thread Simon Pichugin
Hi team, please, review my rework of Sankar's patch. https://pagure.io/389-ds-base/issue/48085 https://pagure.io/389-ds-base/issue/raw/files/f78334baf6bc2eab6b9566f79aa2321b262ac604ff6b1a32dba7bf806376-0001-Issue-48085-Add-encryption-cl5-test-suite.patch Thanks! __

[389-devel] Please review: Issue 48085 - Add encryption cl5 test suite - updated

2018-02-07 Thread Simon Pichugin
Hi team, please, review my updated patch: https://pagure.io/389-ds-base/issue/48085 https://pagure.io/389-ds-base/issue/raw/files/8c490b029e355f97c0a5c992fc856ddaca3b14a93c7f8c9428b87891a7a02bc9-0001-Issue-48085-Add-encryption-cl5-test-suite.patch Thanks! _

[389-devel] Re: Please review: Issue 49043 - Add a test suite

2018-02-09 Thread Simon Pichugin
Final version. All tests from other tickets were added. Please, review. https://pagure.io/389-ds-base/pull-request/49558 - Original Message - > From: "Simon Pichugin" > To: "389 Directory server developer discussion." > <389-devel@lists.fedoraproject.o

[389-devel] Please review: Add a test suite for ds-replcheck tool RFE

2018-02-14 Thread Simon Pichugin
Hi team, please, review a draft of RFE tests https://pagure.io/389-ds-base/pull-request/49567 ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Add a test suite for ds-replcheck tool RFE

2018-02-21 Thread Simon Pichugin
Please, review the full version of the RFE test suite. https://pagure.io/389-ds-base/pull-request/49567 - Original Message - > From: "Simon Pichugin" > To: "389 Directory server developer discussion." > <389-devel@lists.fedoraproject.org> > Sent: W

[389-devel] Please review: Issue 49560 - Add a test case for extract-pemfiles

2018-02-26 Thread Simon Pichugin
Hi team, please, review a new pull request: https://pagure.io/389-ds-base/pull-request/49578 And a gentle reminder... https://pagure.io/389-ds-base/pull-request/49567 Thanks, Simon ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsub

[389-devel] Please review: Issue 49584 - Fix issues with paged_results test suite

2018-02-28 Thread Simon Pichugin
Hi team, please, review a small fix: https://pagure.io/389-ds-base/issue/49584 https://pagure.io/389-ds-base/pull-request/49590 Thanks, Simon ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to 389-devel-le..

[389-devel] Please review: Issue 49572 - ns_job_wait race on condvar

2018-03-02 Thread Simon Pichugin
Hi team, please, review a small fix for nunc-stance tests: https://pagure.io/389-ds-base/issue/49572 https://pagure.io/389-ds-base/pull-request/49592 Thanks, Simon ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an e

[389-devel] Please review: Issue 49593 - NDN cache stats should be under the global stats

2018-03-07 Thread Simon Pichugin
Hi team, please, review: https://pagure.io/389-ds-base/pull-request/49595 https://pagure.io/389-ds-base/issue/49593 Thanks, Simon ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to 389-devel-le...@lists.fedor

[389-devel] Re: Please review: Issue 49593 - NDN cache stats should be under the global stats

2018-03-07 Thread Simon Pichugin
Fixed compile warnings. On Wed, Mar 07, 2018 at 06:53:53PM +0100, Simon Pichugin wrote: > Hi team, > please, review: > > https://pagure.io/389-ds-base/pull-request/49595 > https://pagure.io/389-ds-base/issue/49593 > > Thanks, > Simon >

[389-devel] Re: Use of int types in the code base,

2018-03-08 Thread Simon Pichugin
Hi William! Thank you for the email. It has clarified the things for me. :) I still have one question though. Do I understand right that I need also to cast types with these types from inttypes.h? So use it not only in the defenitions. - sprintf(buf, "%lu", (long unsigned int)maxsize); + sprintf(

[389-devel] Re: Please review: Issue 49593 - NDN cache stats should be under the global stats

2018-03-08 Thread Simon Pichugin
Fixed issues with inttypes. On Wed, Mar 07, 2018 at 08:01:33PM +0100, Simon Pichugin wrote: > Fixed compile warnings. > > On Wed, Mar 07, 2018 at 06:53:53PM +0100, Simon Pichugin wrote: > > Hi team, > > please, review: > > > > https://pagure.io/389-ds-

[389-devel] Re: Use of int types in the code base,

2018-03-08 Thread Simon Pichugin
- Original Message - > From: "William Brown" > To: "Simon Pichugin" > Cc: "389-devel" <389-devel@lists.fedoraproject.org> > Sent: Friday, March 9, 2018 12:30:40 AM > Subject: Re: Use of int types in the code base, > > On Thu

[389-devel] Re: Use of int types in the code base,

2018-03-12 Thread Simon Pichugin
> On Fri, 2018-03-09 at 02:35 -0500, Simon Pichugin wrote: > > > > - Original Message - > > > From: "William Brown" > > > To: "Simon Pichugin" > > > Cc: "389-devel" <389-devel@lists.fedoraproject.org> > >

[389-devel] Please review: Issue 49109 - nsDS5ReplicaTransportInfo should accept StartTLS as an option

2018-03-19 Thread Simon Pichugin
Hi team, please, review: https://pagure.io/389-ds-base/issue/49109 https://pagure.io/389-ds-base/pull-request/49613 Thanks, Simon ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to 389-devel-le...@lists.fedor

[389-devel] Re: Please review: Issue 49109 - nsDS5ReplicaTransportInfo should accept StartTLS as an option

2018-03-21 Thread Simon Pichugin
Hi team, as William and Matus proposed, I've changed nsDS5ReplicaTransportInfo: TLS to LDAP+StartTLS. Also, I've changed existed TLS test suite so it covers the change. On Tue, Mar 20, 2018 at 12:45:52AM +0100, Simon Pichugin wrote: > Hi team, > please, review: > > https:/

[389-devel] Re: Please review: Issue 49109 - nsDS5ReplicaTransportInfo should accept StartTLS as an option

2018-04-12 Thread Simon Pichugin
On Wed, Mar 21, 2018 at 11:05:06PM +0100, Simon Pichugin wrote: > Hi team, > as William and Matus proposed, I've changed nsDS5ReplicaTransportInfo: TLS to > LDAP+StartTLS. > Also, I've changed existed TLS test suite so it covers the change. I changed the name for DNA_PRO

[389-devel] Please review: Issue 49581 - Fix dynamic plugins test suite

2018-04-12 Thread Simon Pichugin
Hi team, please review a PR for dynamic plugins test suite fix. https://pagure.io/389-ds-base/issue/49581 https://pagure.io/389-ds-base/pull-request/49626 I devided it in two parts for easy review. https://pagure.io/fork/spichugi/389-ds-base/c/9c7a76e27adfff02c40abdd4d49acfa187b97a14 First part a

[389-devel] Re: Please review: Issue 49581 - Fix dynamic plugins test suite

2018-04-16 Thread Simon Pichugin
On Thu, Apr 12, 2018 at 12:17:06PM +0200, Simon Pichugin wrote: > Hi team, > please review a PR for dynamic plugins test suite fix. > > https://pagure.io/389-ds-base/issue/49581 > https://pagure.io/389-ds-base/pull-request/49626 > I devided it in two parts for easy review. >

[389-devel] Please review: Issue 49511 - memory leak in pwdhash

2018-04-16 Thread Simon Pichugin
Hi team, please review a small fix for memory leak issue: https://pagure.io/389-ds-base/issue/49511 https://pagure.io/389-ds-base/pull-request/49638 Thanks! Simon ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an ema

[389-devel] Re: Please review: Issue 49109 - nsDS5ReplicaTransportInfo should accept StartTLS as an option

2018-04-17 Thread Simon Pichugin
The LDAP+StartTLS was changed back to StartTLS by Mark suggestions and I support his commentary. https://pagure.io/389-ds-base/pull-request/49613#comment-50699 Please, check once again if everything is okay. Thanks! Simon On Thu, Apr 12, 2018 at 11:38:51AM +0200, Simon Pichugin wrote: > On

[389-devel] Please review - Issue 49612 - lib389 remove_ds_instance() does not remove systemd units

2018-04-19 Thread Simon Pichugin
Hi team, please, review a lib389 Python installer (remove function) patch. https://pagure.io/389-ds-base/pull-request/49641 https://pagure.io/389-ds-base/issue/49612 Thanks, Simon ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubs

[389-devel] Please review: Issue 49642 - lib389 should generate a more complex password

2018-04-20 Thread Simon Pichugin
Hi team, https://pagure.io/389-ds-base/pull-request/49643 https://pagure.io/389-ds-base/issue/49642 Thanks, Simon ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49406 - Port backend_test.py test to DSLdapObject implementation

2018-04-23 Thread Simon Pichugin
Hi team, please review a test suite with simple tests for Backends(DSLdapObject) implementation. https://pagure.io/389-ds-base/issue/49406 https://pagure.io/389-ds-base/pull-request/49647 Thanks, Simon ___ 389-devel mailing list -- 389-devel@lists.fedor

[389-devel] Please review: Issue 49538 - replace cacertdir_rehash with openssl rehash

2018-04-23 Thread Simon Pichugin
Hi team, please, review: https://pagure.io/389-ds-base/issue/49538 https://pagure.io/389-ds-base/pull-request/49651 Thanks, Simon ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to 389-devel-le...@lists.fedor

[389-devel] Re: Please review: Issue 49538 - replace cacertdir_rehash with openssl rehash

2018-04-25 Thread Simon Pichugin
I've changed it to c_rehash tool and added a small fix related t remove_ds_instance. On Mon, Apr 23, 2018 at 04:06:35PM +0200, Simon Pichugin wrote: > Hi team, > please, review: > > https://pagure.io/389-ds-base/issue/49538 > https://pagure.io/389-ds-base/pull-request/49651

[389-devel] Please review: Ticket 49650 - lib389 enable_tls doesn't work on F28

2018-04-26 Thread Simon Pichugin
Hi team, please review: https://pagure.io/389-ds-base/issue/49650 https://pagure.io/389-ds-base/pull-request/49653 Thanks, Simon ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to 389-devel-le...@lists.fedora

[389-devel] Please review: Issue 49657 - Fix cascading replication scenario in lib389 API

2018-05-03 Thread Simon Pichugin
Hi team, please, review: https://pagure.io/389-ds-base/pull-request/49659 https://pagure.io/389-ds-base/issue/49657 Thanks! Simon ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to 389-devel-le...@lists.fedor

[389-devel] lib389 usage cheatsheet

2018-05-09 Thread Simon Pichugin
Hi team, recently, we had a discussion on a scrum meeting about lib389 and its new API. If I understood right there was an opinion that lib389 DSLdapObjects API is not very intuitive and it is much easier stick to python-ldap style because it uses ldapmodify/ldapadd wording (or close enough to it

[389-devel] Re: lib389 usage cheatsheet

2018-05-11 Thread Simon Pichugin
Hi Thierry, I agree with you, it was exactly my proposition :) Keeping main python-ldap elements is important because we don't want to implement or mask/wrap this basic functionality (like working with controls, etc) we just want to redirect them. Ideally, we should make our admin library very i

[389-devel] Re: Please review: Issue 49657 - Fix cascading replication scenario in lib389 API

2018-05-11 Thread Simon Pichugin
The issues mentioned by Mark were fixed. On Thu, May 03, 2018 at 02:32:22PM +0200, Simon Pichugin wrote: > Hi team, > please, review: > > https://pagure.io/389-ds-base/pull-request/49659 > https://pagure.io/389-ds-base/issue/49657 >

[389-devel] Re: Please review: Issue 49581 - Fix dynamic plugins test suite

2018-05-14 Thread Simon Pichugin
Fixed the issues Viktor has reported. Please, review. On Mon, Apr 16, 2018 at 12:25:35PM +0200, Simon Pichugin wrote: > On Thu, Apr 12, 2018 at 12:17:06PM +0200, Simon Pichugin wrote: > > Hi team, > > please review a PR for dynamic plugins test suite fix. > > > > ht

[389-devel] Please review: Issue 49381 - Add docstrings to plugin test suites - Part 1

2018-05-23 Thread Simon Pichugin
Hi team, please, review a docstrings commit. https://pagure.io/389-ds-base/issue/49381 https://pagure.io/389-ds-base/pull-request/49708 Thanks, Simon ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to 389-de

[389-devel] Please review: Issue 49646 - Improve TLS cert processing in lib389 CLI

2018-05-28 Thread Simon Pichugin
Hi team, https://pagure.io/389-ds-base/issue/49646 https://pagure.io/389-ds-base/pull-request/49709 And the issues were fixed: https://pagure.io/389-ds-base/issue/49381 https://pagure.io/389-ds-base/pull-request/49708 Thanks, Simon signature.asc Description: PGP signature _

[389-devel] Please review: Issue 49761 - Fix CI test suite issues

2018-06-06 Thread Simon Pichugin
Hi team, https://pagure.io/389-ds-base/issue/49761 https://pagure.io/389-ds-base/pull-request/49762 Thanks, Simon signature.asc Description: PGP signature ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to

[389-devel] Please review: Issue 49640 - Errors about PBKDF2 password storage plugin at server startup

2018-06-08 Thread Simon Pichugin
Hi team, https://pagure.io/389-ds-base/issue/49640 https://pagure.io/389-ds-base/pull-request/49771 Thanks, Simon signature.asc Description: PGP signature ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to

[389-devel] Please review: Issue 49761 - Fix more CI test issues

2018-06-17 Thread Simon Pichugin
Hi team, https://pagure.io/389-ds-base/issue/49761 https://pagure.io/389-ds-base/pull-request/49787 Thanks, Simon signature.asc Description: PGP signature ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to

[389-devel] Please review: Issue 49640 - Cleanup plugin bootstrap logging

2018-07-02 Thread Simon Pichugin
Hi team, https://pagure.io/389-ds-base/issue/49640 https://pagure.io/389-ds-base/pull-request/49822 Thanks! Simon signature.asc Description: PGP signature ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to

[389-devel] Please review: Issue 49761 - Fix replication test suite issues

2018-07-13 Thread Simon Pichugin
Hi team, https://pagure.io/389-ds-base/pull-request/49846 https://pagure.io/389-ds-base/issue/49761 Thanks! Simon signature.asc Description: PGP signature ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to

[389-devel] Re: Please review: Issue 49761 - Fix replication test suite issues

2018-07-16 Thread Simon Pichugin
Hi team, And especially Mark, please, take a look if it is okay for WebUI/CLI: https://pagure.io/389-ds-base/issue/49844 https://pagure.io/389-ds-base/pull-request/49853 And a gentle reminder: On Fri, Jul 13, 2018 at 10:21:58AM +0200, Simon Pichugin wrote: > Hi team, > > https://pagu

[389-devel] Please review: Issue 49381 - Refactor docstrings to the plugin test suite

2018-07-19 Thread Simon Pichugin
Hi team, https://pagure.io/389-ds-base/issue/49381 https://pagure.io/389-ds-base/pull-request/49861 Thanks, Simon signature.asc Description: PGP signature ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email to

[389-devel] Please review: Issue 49928 - WebUI schema functionality and improve CLI part

2018-09-20 Thread Simon Pichugin
Hi team, please, review WebUI schema PR: https://pagure.io/389-ds-base/issue/49928 https://pagure.io/389-ds-base/pull-request/49957 Thanks! Simon signature.asc Description: PGP signature ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org

[389-devel] Please review: Issue 49928 - Fix various small WebUI schema issues

2018-10-09 Thread Simon Pichugin
Hi team, please, review the WebUI schema change. Also, I wait for this to be merged https://github.com/python-ldap/python-ldap/pull/247 but my PR will work as intended without it, I put a small workaround which we will remove later. https://pagure.io/389-ds-base/pull-request/49966 https://pagure.i

[389-devel] Re: Please review

2019-04-30 Thread Simon Pichugin
On Tue, Apr 30, 2019 at 02:15:55PM +0530, Anuj Borah wrote: >Hi all, Hi Anuj, >Please review these PRs. >Pending from Long Time. >[1]https://pagure.io/389-ds-base/pull-request/50180 >[2]https://pagure.io/389-ds-base/pull-request/50192 Could you please rebase them onto master?

[389-devel] Re: Use of rust for new logging backend

2019-05-15 Thread Simon Pichugin
On Tue, May 14, 2019 at 01:21:28PM +1000, William Brown wrote: > Hi all, > > So it's been a while since I pushed this, but again, I think I want to bring > this up. I'd like to write the new logging backend in Rust. > > I'll start with a summary: > > Pros: > * Faster development time due to str

[389-devel] Re: On the command line tools ....

2019-05-24 Thread Simon Pichugin
On Fri, May 24, 2019 at 09:50:48AM -0400, Mark Reynolds wrote: > On 5/22/19 9:02 PM, William Brown wrote: > > Hi all, Hi William, > > I would propose to change this - but I feel we are now wedged on change by > > two things: > > > > * Red Hat have documented these tools, and it's a big ask to ge

[389-devel] Please review: PR 50440 - Truncate the message when buffer capacity is exceeded

2019-06-16 Thread Simon Pichugin
Hi team, please, review my recent PR: https://pagure.io/389-ds-base/pull-request/50440 I've added CI test and I've done stress testing to see if performans is affected (the details are inside) Thanks, Simon signature.asc Description: PGP signature __

[389-devel] Issue with building RPMs with ASAN_ON

2019-06-17 Thread Simon Pichugin
Hi team, I'm in the process of creating a Vagrant file which is close to the customer's ENV. It is heavilly based on Viktor's beaker task. I use it for building and testing my code. And it is pretty important to build with ASAN. Currently, what I do is: 1. Set 'ASAN_ON = 1' in rpm.mk 2. Run `mak

  1   2   3   >