Re: [9fans] 5c bug

2019-07-25 Thread Charles Forsyth
5c shouldn't discard the cast, which implies a mask, but you should also rewrite the code as you suggest. (it's not just 5c, since it's the same for several other RISCy ones.) On Thu, Jul 25, 2019 at 12:20 PM Steve Simon wrote: > Hi, > > I traced a long standing cifs issue to 5c the compiler.

[9fans] 5c bug

2019-07-25 Thread Steve Simon
Hi, I traced a long standing cifs issue to 5c the compiler. The code in lib9p to validate wstat calls uses a neat bit of casting which fails when using 5c. /sys/src/lib9p/srv.c:658-669 These following lines missfire reporting type or qid change when trying to rename files over cifs.