[Bug 198783] empty filename in /sys/firmware/acpi/tables
https://bugzilla.kernel.org/show_bug.cgi?id=198783 Zhang Rui (rui.zh...@intel.com) changed: What|Removed |Added Status|NEEDINFO|CLOSED Resolution|--- |UNREPRODUCIBLE --- Comment #13 from Zhang Rui (rui.zh...@intel.com) --- then let's close it for now, and we can reopen it whenever you can access the machine and the problem can be reproduced in the latest upstream kernel. -- You are receiving this mail because: You are watching the assignee of the bug. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 198783] empty filename in /sys/firmware/acpi/tables
https://bugzilla.kernel.org/show_bug.cgi?id=198783 --- Comment #12 from Martin von Wittich (martin.von.witt...@iserv.eu) --- (In reply to Zhang Rui from comment #11) > Hi, Martin, > > any new findings? does the problem still exist in the latest upstream kernel? Sorry for not replying earlier, I forgot :( I currently don't have any access to an affected machine, so can't really try to reproduce the issue with the latest kernel. If you want you can close the bug; I'll report back when I encounter it again. Thanks! -- You are receiving this mail because: You are watching the assignee of the bug. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 198783] empty filename in /sys/firmware/acpi/tables
https://bugzilla.kernel.org/show_bug.cgi?id=198783 --- Comment #11 from Zhang Rui (rui.zh...@intel.com) --- Hi, Martin, any new findings? does the problem still exist in the latest upstream kernel? -- You are receiving this mail because: You are watching the assignee of the bug. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 198783] empty filename in /sys/firmware/acpi/tables
https://bugzilla.kernel.org/show_bug.cgi?id=198783 --- Comment #9 from Martin von Wittich (martin.von.witt...@iserv.eu) --- Created attachment 275069 --> https://bugzilla.kernel.org/attachment.cgi?id=275069=edit complete dmidecode output -- You are receiving this mail because: You are watching the assignee of the bug. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 198783] empty filename in /sys/firmware/acpi/tables
https://bugzilla.kernel.org/show_bug.cgi?id=198783 --- Comment #8 from Martin von Wittich (martin.von.witt...@iserv.eu) --- Created attachment 275067 --> https://bugzilla.kernel.org/attachment.cgi?id=275067=edit complete plain text output of acpidump -- You are receiving this mail because: You are watching the assignee of the bug. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 198783] empty filename in /sys/firmware/acpi/tables
https://bugzilla.kernel.org/show_bug.cgi?id=198783 --- Comment #7 from Martin von Wittich (martin.von.witt...@iserv.eu) --- Created attachment 275065 --> https://bugzilla.kernel.org/attachment.cgi?id=275065=edit complete binary acpidump (acpidump -b) -- You are receiving this mail because: You are watching the assignee of the bug. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 198783] empty filename in /sys/firmware/acpi/tables
https://bugzilla.kernel.org/show_bug.cgi?id=198783 --- Comment #6 from Martin von Wittich (martin.von.witt...@iserv.eu) --- I've got access to an affected machine again, so I've collected some further information: * `ls | cat` output - you can see the unnamed folder in the form of an empty line that shouldn't be there (`|cat` to force ls to print each filename on a line of its own; `command` builtin to circumvent `ls` aliases): root@notebooksak02:/sys/firmware/acpi/tables# command ls | cat APIC BOOT DSDT dynamic FACP FACS1 FACS2 HPET MCFG SSDT1 SSDT2 SSDT3 SSDT4 SSDT5 * `ls -l` output: root@notebooksak02:~# command ls -l /sys/firmware/acpi/tables/ total 0 drwxr-xr-x 3 root root 0 2018-04-03 10:35 -r 1 root root 104 2018-04-03 10:35 APIC -r 1 root root40 2018-04-03 10:35 BOOT -r 1 root root 34035 2018-04-03 10:35 DSDT drwxr-xr-x 2 root root 0 2018-04-03 10:35 dynamic -r 1 root root 244 2018-04-03 10:35 FACP -r 1 root root64 2018-04-03 10:35 FACS1 -r 1 root root64 2018-04-03 10:35 FACS2 -r 1 root root56 2018-04-03 10:35 HPET -r 1 root root60 2018-04-03 10:35 MCFG -r 1 root root 692 2018-04-03 10:35 SSDT1 -r 1 root root 1263 2018-04-03 10:35 SSDT2 -r 1 root root 458 2018-04-03 10:35 SSDT3 -r 1 root root 4329 2018-04-03 10:35 SSDT4 -r 1 root root 1095 2018-04-03 10:35 SSDT5 * For some reason I don't understand, the `ls` output changes (it prints lots of ??? and also an error message) when I `cd` to the folder: root@notebooksak02:~# cd /sys/firmware/acpi/tables/ root@notebooksak02:/sys/firmware/acpi/tables# command ls -l ls: cannot access : No such file or directory total 0 -? ? ???? -r 1 root root 104 2018-04-03 10:35 APIC -r 1 root root40 2018-04-03 10:35 BOOT -r 1 root root 34035 2018-04-03 10:35 DSDT drwxr-xr-x 2 root root 0 2018-04-03 10:35 dynamic -r 1 root root 244 2018-04-03 10:35 FACP -r 1 root root64 2018-04-03 10:35 FACS1 -r 1 root root64 2018-04-03 10:35 FACS2 -r 1 root root56 2018-04-03 10:35 HPET -r 1 root root60 2018-04-03 10:35 MCFG -r 1 root root 692 2018-04-03 10:35 SSDT1 -r 1 root root 1263 2018-04-03 10:35 SSDT2 -r 1 root root 458 2018-04-03 10:35 SSDT3 -r 1 root root 4329 2018-04-03 10:35 SSDT4 -r 1 root root 1095 2018-04-03 10:35 SSDT5 * You can see the folder without a name in the second line of the `find` output, but it's impossible to differentiate it from the parent folder because both lines seem to end with `/`: root@notebooksak02:/sys/firmware/acpi/tables# cd root@notebooksak02:~# find /sys/firmware/acpi/tables/ /sys/firmware/acpi/tables/ /sys/firmware/acpi/tables/ /sys/firmware/acpi/tables/MCFG /sys/firmware/acpi/tables/FACS1 /sys/firmware/acpi/tables/SSDT4 /sys/firmware/acpi/tables/APIC /sys/firmware/acpi/tables/SSDT2 /sys/firmware/acpi/tables/BOOT /sys/firmware/acpi/tables/dynamic /sys/firmware/acpi/tables/dynamic/SSDT6 /sys/firmware/acpi/tables/dynamic/SSDT9 /sys/firmware/acpi/tables/dynamic/SSDT7 /sys/firmware/acpi/tables/dynamic/SSDT8 /sys/firmware/acpi/tables/DSDT /sys/firmware/acpi/tables/FACS2 /sys/firmware/acpi/tables/SSDT5 /sys/firmware/acpi/tables/FACP /sys/firmware/acpi/tables/SSDT3 /sys/firmware/acpi/tables/SSDT1 /sys/firmware/acpi/tables/HPET * `find` in the dir also looks a bit different, now you can differentiate the parent folder and the unnamed folder: root@notebooksak02:~# cd - /sys/firmware/acpi/tables root@notebooksak02:/sys/firmware/acpi/tables# find . ./ ./MCFG ./FACS1
[Bug 198783] empty filename in /sys/firmware/acpi/tables
https://bugzilla.kernel.org/show_bug.cgi?id=198783
--- Comment #5 from Martin von Wittich (martin.von.witt...@iserv.eu) ---
(In reply to Zhang Rui from comment #3)
> I don't know what the python error means.
Sorry for not clarifying this; I'll try to explain. The code crashes at this
point:
```
File "/usr/lib/python2.6/glob.py", line 60, in
names = filter(lambda x: x[0] != '.', names)
```
Here you can see line 60 of glob.py of python2.6:
https://hg.python.org/cpython/file/2.6/Lib/glob.py#l60
The code essentially loops through the array "names", which contains all
filenames that have been generated by `os.listdir("/sys/firmware/acpi/tables")`
(l. 56). It checks if the current filename begins with "." (which would
indicate a hidden file). If the glob pattern begins with a ".", then it will
only return filenames beginning with ".", and if the pattern doesn't, it will
only return filenames not beginning with ".". Standard glob behaviour so far :)
Unfortunately, the `names` array contains an empty string, ie it looks like
this:
```
names = ["", "APIC", "BOOT", ... ]
```
The code crashes as soon as it tries to extract the first character of "" (the
`x[0]` in the code), because the string doesn't contain any characters. As far
as I know, empty filenames aren't allowed on Linux (can't find any
documentation on this though, maybe I'm wrong?), so I'd argue that this is a
kernel bug and not a Python bug.
> what's the output of following bash code?
I don't currently have access to the machine because it is a notebook on a
remote customer site; I would have to ask the customer to boot it for me,
because I can't wake it up remotely :/
> for table in $(ls /sys/firmware/acpi/tables)
> do
>if [ -d $table ]
>then
>echo found directory: $table
>continue
>else
>echo found file: $table
>fi
> done
>
>
> you may also run similar code to dump the file names under
> /sys/firmware/acpi/tables/data/ and /sys/firmware/acpi/tables/dynamic/
I'm sorry, but I do not see how this code would be any help in the current
situation. `ls` will just print an empty string for the unnamed folder that is
causing this issue, and the word splitting of the shell would then eat that;
the `for` loop will only ever see the valid entries of
`/sys/firmware/acpi/tables`. The `ls` output in my original posting contains
all the information that this code could gather.
(Also, it would work only after `cd`'ing to `/sys/firmware/acpi/tables`, and
parsing `ls` is always a mistake ;) )
--
You are receiving this mail because:
You are watching the assignee of the bug.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 198783] empty filename in /sys/firmware/acpi/tables
https://bugzilla.kernel.org/show_bug.cgi?id=198783 --- Comment #4 from Martin von Wittich (martin.von.witt...@iserv.eu) --- (In reply to Erik Schmauss from comment #2) > Could it be this ^ root directory that it's having issues with? I'm assuming > that this is a symbolic link. You might try removing this link and invoke > the python code again... You're right, the issue is caused by this entry, although I wouldn't call it a "root" directory. It is an unnamed directory, that is, the name of that directory is "". The trailing / is produced by `ls -F` to indicate that the entry is a directory: -F, --classify append indicator (one of */=>@|) to entries The fact that this entry doesn't have a name in turn breaks the Python glob function, because it can't deal with nameless entries. I'm pretty certain that it isn't a symlink, because `ls -l` would display symlinks as `symlink => target`. -- You are receiving this mail because: You are watching the assignee of the bug. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 198783] empty filename in /sys/firmware/acpi/tables
https://bugzilla.kernel.org/show_bug.cgi?id=198783 Zhang Rui (rui.zh...@intel.com) changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from Zhang Rui (rui.zh...@intel.com) --- I don't know what the python error means. what's the output of following bash code? for table in $(ls /sys/firmware/acpi/tables) do if [ -d $table ] then echo found directory: $table continue else echo found file: $table fi done you may also run similar code to dump the file names under /sys/firmware/acpi/tables/data/ and /sys/firmware/acpi/tables/dynamic/ -- You are receiving this mail because: You are watching the assignee of the bug. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 198783] empty filename in /sys/firmware/acpi/tables
https://bugzilla.kernel.org/show_bug.cgi?id=198783
--- Comment #2 from Erik Schmauss (erik.schma...@intel.com) ---
(In reply to Martin von Wittich from comment #0)
> Created attachment 274161 [details]
> dmesg output
>
> We've encountered a strange issue with a piece of Python code that occurs on
> a single customer client:
>
> python -c '
> import glob
> print glob.glob("/sys/firmware/acpi/tables/*")
> '
>
> This prints the following error message:
>
> Traceback (most recent call last):
> File "", line 3, in
> File "/usr/lib/python2.6/glob.py", line 16, in glob
> return list(iglob(pathname))
> File "/usr/lib/python2.6/glob.py", line 42, in iglob
> for name in glob_in_dir(dirname, basename):
> File "/usr/lib/python2.6/glob.py", line 60, in glob1
> names = filter(lambda x: x[0] != '.', names)
> File "/usr/lib/python2.6/glob.py", line 60, in
> names = filter(lambda x: x[0] != '.', names)
> IndexError: string index out of range
>
>
> This seems to be caused by a folder without a name in
> /sys/firmware/acpi/tables:
>
> root@client:~# command ls -lFa /sys/firmware/acpi/tables/
> total 0
> drwxr-xr-x 3 root root 0 2018-02-14 12:35 /
Could it be this ^ root directory that it's having issues with? I'm assuming
that this is a symbolic link. You might try removing this link and invoke the
python code again...
> drwxr-xr-x 3 root root 0 2018-02-14 12:35 ./
> drwxr-xr-x 5 root root 0 2018-02-14 12:35 ../
> -r 1 root root 104 2018-02-14 12:35 APIC
> -r 1 root root40 2018-02-14 12:35 BOOT
> -r 1 root root 34035 2018-02-14 12:35 DSDT
> drwxr-xr-x 2 root root 0 2018-02-14 12:35 dynamic/
> -r 1 root root 244 2018-02-14 12:35 FACP
> -r 1 root root64 2018-02-14 12:35 FACS1
> -r 1 root root64 2018-02-14 12:35 FACS2
> -r 1 root root56 2018-02-14 12:35 HPET
> -r 1 root root60 2018-02-14 12:35 MCFG
> -r 1 root root 692 2018-02-14 12:35 SSDT1
> -r 1 root root 1263 2018-02-14 12:35 SSDT2
> -r 1 root root 458 2018-02-14 12:35 SSDT3
> -r 1 root root 4329 2018-02-14 12:35 SSDT4
> -r 1 root root 1095 2018-02-14 12:35 SSDT5
>
> Bug 11539 seems to describe this issue, but that report is closed since 2008
> / Linux 2.6.26. We're running:
>
> root@client:~# cat /proc/version
> Linux version 4.10.0-28-generic (buildd@lgw01-11) (gcc version 6.3.0
> 20170406 (Ubuntu 6.3.0-12ubuntu2) ) #32-Ubuntu SMP Fri Jun 30 05:32:18 UTC
> 2017
--
You are receiving this mail because:
You are watching the assignee of the bug.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 198783] empty filename in /sys/firmware/acpi/tables
https://bugzilla.kernel.org/show_bug.cgi?id=198783
Chen Yu (yu.c.c...@intel.com) changed:
What|Removed |Added
CC||erik.schma...@intel.com,
||rui.zh...@intel.com,
||yu.c.c...@intel.com
--- Comment #1 from Chen Yu (yu.c.c...@intel.com) ---
python -c '
> import glob
> print glob.glob("/sys/firmware/acpi/tables/*")
> '
['/sys/firmware/acpi/tables/SSDT', '/sys/firmware/acpi/tables/MCFG',
'/sys/firmware/acpi/tables/APIC', '/sys/firmware/acpi/tables/dynamic',
'/sys/firmware/acpi/tables/DSDT', '/sys/firmware/acpi/tables/FACP',
'/sys/firmware/acpi/tables/data', '/sys/firmware/acpi/tables/HPET',
'/sys/firmware/acpi/tables/FACS']
Seems you don' have FACS, but i'm not an expert on this,
@Rui, @Erik, any ideas?
--
You are receiving this mail because:
You are watching the assignee of the bug.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
