[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 --- Comment #16 from Chris Chiu (chris.c...@canonical.com) --- Thanks. I've filed a bug on https://gitlab.freedesktop.org/drm/intel/-/issues/3500 and still get no information about the progress. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 Zhang Rui (rui.zh...@intel.com) changed: What|Removed |Added Status|NEEDINFO|CLOSED Resolution|--- |MOVED -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 Zhang Rui (rui.zh...@intel.com) changed: What|Removed |Added Status|NEW |NEEDINFO CC||rui.zh...@intel.com --- Comment #15 from Zhang Rui (rui.zh...@intel.com) --- Thanks for the information and your debug patch, that is very helpful to illustrate the problem. Given this is graphics related, can you please file a bug to the graphics experts following this page? https://gitlab.freedesktop.org/drm/intel/-/wikis/How-to-file-i915-bugs -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 --- Comment #14 from Chris Chiu (chris.c...@canonical.com) --- Created attachment 296897 --> https://bugzilla.kernel.org/attachment.cgi?id=296897=edit Log of doing hpd_init during .resume_noirq -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951
--- Comment #13 from Chris Chiu (chris.c...@canonical.com) ---
I got this problem fixed with the following hacky code and I think it should be
a finding that could help.
```
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1399,6 +1399,15 @@ static int i915_pm_poweroff_late(struct device *kdev)
return i915_drm_suspend_late(>drm, true);
}
+static int i915_pm_resume_noirq(struct device *kdev)
+{
+ struct drm_i915_private *i915 = kdev_to_i915(kdev);
+
+ if (!IS_VALLEYVIEW(i915) && !IS_CHERRYVIEW(i915))
+ intel_hpd_init(i915);
+ return 0;
+}
+
static int i915_pm_resume_early(struct device *kdev)
{
struct drm_i915_private *i915 = kdev_to_i915(kdev);
@@ -1626,6 +1635,7 @@ const struct dev_pm_ops i915_pm_ops = {
.prepare = i915_pm_prepare,
.suspend = i915_pm_suspend,
.suspend_late = i915_pm_suspend_late,
+ .resume_noirq = i915_pm_resume_noirq,
.resume_early = i915_pm_resume_early,
.resume = i915_pm_resume,
```
Because this APCI method IPCS lockup only happens when we remove the dock with
external display connected(or the USB-C dongle with external display connected)
when suspended and then exit s2idle. It should be related to either graphic
drivers or hpd events handling. I did lots of experiments and found if the
\_SB.PC00.PEG1.PG01._ON exeutes after i915_pm_resume_early, the IPCS will not
be locked by the IBSY and IERR.
Since the \_SB.PC00.PEG1.PG01._ON is invoked by pci_power_up() in
pci_pm_resume_noirq and it's in the context of dpm_resume_noirq(). The
i915_pm_resume_early is in dpm_resume_early() context and that's why the
Sleep(One) in the IPCS lasts for >30 seconds but i915 still has no chance to
early resume to free the IPCS lock.
I assume that it's due to the unplug action is not handled properly during
resume, so I add the .resume_noirq() in i915 driver to let the hpd have chance
to do something during in the same dpm_resume_noirq context. It seems to work
fine and pci :01:00.0 (PEG1) can transition to D0 w/o problem. However,
it's a dirty hack because I'll hit the kernel WARN in hpd_init(). Please refer
to the attached hpd_init_dmesg.log.
Can anyone from Intel help on this? I'll be glad to collect logs or test any
PATCH. Thanks
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
___
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 --- Comment #12 from Hsiao-Ting Wang, Tiffany (hsiaoting.w...@gmail.com) --- Created attachment 296855 --> https://bugzilla.kernel.org/attachment.cgi?id=296855=edit ACPI debug log with enabling trace_state ACPI debug log with enabling trace_state -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 --- Comment #11 from Hsiao-Ting Wang, Tiffany (hsiaoting.w...@gmail.com) --- Verbose ACPI debug log with drm.debug=0xe https://files.support.canonical.com/f/208f43fd63f86041 echo 0x00f0 > debug_layer echo 0x600 > debug_level -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 --- Comment #10 from Hsiao-Ting Wang, Tiffany (hsiaoting.w...@gmail.com) --- Created attachment 296849 --> https://bugzilla.kernel.org/attachment.cgi?id=296849=edit ACPI debug log on TGL-U ACPI debug log on TGL-U with dual C docking. Issue cannot reproduce. "PM: suspend entry (s2idle)" which indicates the suspend start and "ACPI: EC: interrupt unblocked" which indicate the system starts the resume. Note: TGL-U system seems a little bit slow to resume but it still can resume back okay. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 --- Comment #9 from Hsiao-Ting Wang, Tiffany (hsiaoting.w...@gmail.com) --- Created attachment 296847 --> https://bugzilla.kernel.org/attachment.cgi?id=296847=edit TGL-U log with kernel parameter "drm.debug=0xe" TGL-U log with kernel parameter "drm.debug=0xe" Issue cannot reproduce. "PM: suspend entry (s2idle)" which indicates the suspend start and "ACPI: EC: interrupt unblocked" which indicate the system starts the resume. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 --- Comment #8 from Hsiao-Ting Wang, Tiffany (hsiaoting.w...@gmail.com) --- Created attachment 296745 --> https://bugzilla.kernel.org/attachment.cgi?id=296745=edit fail log (DC docking) with kernel parameter "drm.debug=0xe" fail log (DC docking) with kernel parameter "drm.debug=0xe" -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 --- Comment #7 from Hsiao-Ting Wang (hsiaoting.w...@gmail.com) --- Provide ACPI verbose log: Pass log with TBT dock: https://files.support.canonical.com/f/550898f54203b96d Fail log with DC dock: https://files.support.canonical.com/f/5aedaec721232a34 All based on the latest BIOS. Capture method under Ubuntu Linux: sudo su cd /sys/kernel/debug/dynamic_debug echo "file drivers/pci/pci.c +p" > control echo "file drivers/acpi/device_pm.c +p" > control cd /sys/module/acpi/parameters/ echo 0x00f0 > debug_layer echo 0x600 > debug_level Start to suspend Exit suspend Use dmesg to get the output file -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 --- Comment #6 from Chris Chiu (chris.c...@canonical.com) --- Don't know whether the PCM information in /sys/kernel/debug/pmc_core is helpful or not. The file includes `ltr_show`, `pch_ip_power_gating_status`, I`substate_live_status_registers` and `substate_status_registers`. I also attached the same information when exit s2idle w/o problem. The major difference is mainly XHCI/USB related (because the dock is removed). And maybe the ISH? Attach the information for your reference. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 --- Comment #5 from Chris Chiu (chris.c...@canonical.com) --- Created attachment 296741 --> https://bugzilla.kernel.org/attachment.cgi?id=296741=edit PMC info of normal s2idle exit -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 --- Comment #4 from Chris Chiu (chris.c...@canonical.com) --- Created attachment 296739 --> https://bugzilla.kernel.org/attachment.cgi?id=296739=edit PMC info when IPSC timeout -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 Hsiao-Ting Wang (hsiaoting.w...@gmail.com) changed: What|Removed |Added CC||hsiaoting.w...@gmail.com -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951
--- Comment #3 from Chris Chiu (chris.c...@canonical.com) ---
I found a timing issue which might be worth investigation. The TBT WD dock I
have here with the latest BIOS 0.5.57 can be manually waked up w/o
AE_AML_LOOP_TIMEOUT problem. So I dump the acpi log and do cross-comparison
between the WD19SC and WD19TB dock.
A key resource and function in ssdt6.dsl are PowerResource (D3C) and
\_SB.PC00.TCON ().
The \_SB.PC00.D3C._ON and \_SB.PC00.TCON begins after the \_SB.PC00.PGON. Then
during the period of TCON, the IPCS will run in parallel with TCON but the
timing between TB and SC are different.
Please refer to the TCON code in
https://gist.github.com/mschiu77/05b9b8ff3ba795f11dd467660952f6e5#file-ssdt7-dsl-L884
In WD19SC case, the IPCS() will begin running before L911 (line 911 in the
above link) per the ACPI log as follows.
[ 262.733726] extrace-0138 ex_trace_point : Method Begin
[0x24236d48:\MCUI] execution.
[ 262.733882] extrace-0138 ex_trace_point : Method Begin
[0x3ff97c7a:\IPCS] execution.
[ 262.744064] extrace-0138 ex_trace_point : Method Begin
[0x4edb7213:\_SB.PC00.DSGS] execution.
[ 262.744233] extrace-0138 ex_trace_point : Method End
[0x4edb7213:\_SB.PC00.DSGS] execution.
[ 262.744245] extrace-0138 ex_trace_point : Method Begin
[0x73d60801:\_SB.PC00.DSCR] execution.
[ 262.744424] extrace-0138 ex_trace_point : Method Begin
[0x4edb7213:\_SB.PC00.DSGS] execution.
In WD19TB case, the IPCS will begin to run in parallel with L913 per the
following ACPI log.
[ 147.643528] extrace-0138 ex_trace_point : Method Begin
[0x8fde276b:\MCUI] execution.
[ 147.643927] extrace-0138 ex_trace_point : Method Begin
[0x06dad187:\_SB.PC00.DSGS] execution.
[ 147.644164] extrace-0138 ex_trace_point : Method End
[0x06dad187:\_SB.PC00.DSGS] execution.
[ 147.644175] extrace-0138 ex_trace_point : Method Begin
[0x3af322ca:\_SB.PC00.DSCR] execution.
[ 147.644338] extrace-0138 ex_trace_point : Method Begin
[0xdd5b6bc8:\IPCS] execution.
[ 147.644788] extrace-0138 ex_trace_point : Method Begin
[0x06dad187:\_SB.PC00.DSGS] execution.
[ 147.644927] extrace-0138 ex_trace_point : Method End
[0x06dad187:\_SB.PC00.DSGS] execution.
[ 147.644949] extrace-0138 ex_trace_point : Method End
[0x3af322ca:\_SB.PC00.DSCR] execution.
>From the timestamp of WD19SC case, the IPCS starts 11ms ahead of L911, which
may indicate the TCON is still in the while loop of L893. According to the
debug message, the "TACK after D3 cold exit" is not printed which means TACK is
not asserted yet. Is it possible that the IPCS also needs to wait for the TACK
or the "ADBG ("D3Cold Exit")"?
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
___
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 --- Comment #2 from Chris Chiu (chris.c...@canonical.com) --- Created attachment 296651 --> https://bugzilla.kernel.org/attachment.cgi?id=296651=edit dmesg with dynamic debug and ACPI trace_state on -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 212951] System freeze for 30 seconds after exiting s2idle
https://bugzilla.kernel.org/show_bug.cgi?id=212951 --- Comment #1 from Chris Chiu (chris.c...@canonical.com) --- Created attachment 296649 --> https://bugzilla.kernel.org/attachment.cgi?id=296649=edit lspci -nnvt output -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
