Re: Small improvements to run_spec_clang_asan.sh

2014-10-02 Thread 'Evgeniy Stepanov' via address-sanitizer
Done. On Wed, Oct 1, 2014 at 8:18 PM, Yuri Gribov tetra2...@gmail.com wrote: Cool! Could someone apply this then? On Wed, Oct 1, 2014 at 2:18 PM, 'Evgeniy Stepanov' via address-sanitizer address-sanitizer@googlegroups.com wrote: Sorry, my bad, missed the $ sign. On Wed, Oct 1, 2014 at

Re: Small improvements to run_spec_clang_asan.sh

2014-10-01 Thread 'Evgeniy Stepanov' via address-sanitizer
CLANGXX=${CLANGXX:-$(echo $CLANG | sed -e 's/gcc$/g++/')} What if there is more than one gcc in the compiler path? Otherwise LGTM. On Wed, Oct 1, 2014 at 1:35 PM, Yuri Gribov tetra2...@gmail.com wrote: On Fri, Sep 19, 2014 at 11:13 PM, Yuri Gribov tetra2...@gmail.com wrote: Will test and

Re: Small improvements to run_spec_clang_asan.sh

2014-10-01 Thread 'Evgeniy Stepanov' via address-sanitizer
Sorry, my bad, missed the $ sign. On Wed, Oct 1, 2014 at 2:03 PM, Yuri Gribov tetra2...@gmail.com wrote: On Wed, Oct 1, 2014 at 1:56 PM, 'Evgeniy Stepanov' via address-sanitizer address-sanitizer@googlegroups.com wrote: CLANGXX=${CLANGXX:-$(echo $CLANG | sed -e 's/gcc$/g++/')} What if there

Re: Small improvements to run_spec_clang_asan.sh

2014-10-01 Thread Yuri Gribov
Cool! Could someone apply this then? On Wed, Oct 1, 2014 at 2:18 PM, 'Evgeniy Stepanov' via address-sanitizer address-sanitizer@googlegroups.com wrote: Sorry, my bad, missed the $ sign. On Wed, Oct 1, 2014 at 2:03 PM, Yuri Gribov tetra2...@gmail.com wrote: On Wed, Oct 1, 2014 at 1:56 PM,

Re: Small improvements to run_spec_clang_asan.sh

2014-09-19 Thread Konstantin Serebryany
On Fri, Sep 19, 2014 at 5:13 AM, 'Evgeniy Stepanov' via address-sanitizer address-sanitizer@googlegroups.com wrote: CLANG=${CLANG:-clang} You probably need the same for CLANGXX Why are you disabling leak detection? It is on by default, which means you are benchmarking not the same thing that

Re: Small improvements to run_spec_clang_asan.sh

2014-09-19 Thread Yuri Gribov
On Fri, Sep 19, 2014 at 4:13 PM, 'Evgeniy Stepanov' via address-sanitizer address-sanitizer@googlegroups.com wrote: CLANG=${CLANG:-clang} You probably need the same for CLANGXX I do this in the next block (autodetection is different clang and gcc are different). Why are you disabling leak

Re: Small improvements to run_spec_clang_asan.sh

2014-09-19 Thread Yuri Gribov
On Fri, Sep 19, 2014 at 9:02 PM, Yuri Gribov tetra2...@gmail.com wrote: I don't understand this LD_LIBRARY_PATH magic, what's its for? Snap, believe it or not but that's a typo. It should be ASAN_OPTIONS and the weird expression optionally inserts : in front of added options (so that user can

Small improvements to run_spec_clang_asan.sh

2014-09-18 Thread Yuri Gribov
Hi all, Here is a small patch for https://code.google.com/p/address-sanitizer/source/browse/trunk/spec/run_spec_clang_asan.sh which * updates docs * adds some option verification * adds GCC support * disables leak detection Does the change look sane? -Y -- You received this message because