Re: svn commit: r501699 - in /incubator/adffaces/trunk/trinidad: trinidad-api/pom.xml trinidad-impl/pom.xml

2007-01-30 Thread Matthias Wessendorf
Hey Jeanne, that fix is causing issues with the META-INF stuff in the jars (for instance an empty faces-config.xml inside the JAR, since there no one generated to $TRIN_HOME/trinidad-impl/target/classes/META-INF I did an "undo" for now, thx On 1/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wr

Re: Early Prototype - Dialog using DHTML / iFrame

2007-01-30 Thread Matthias Wessendorf
Thanks! the CLA is already available on file (Daniel Robinson) http://people.apache.org/~jim/committers.html -Matthias On 1/31/07, Adam Winer <[EMAIL PROTECTED]> wrote: Danny, I grabbed the patch, made a branch, and applied it. I fixed up some things: - Moved (almost) all of the popup dial

Re: Early Prototype - Dialog using DHTML / iFrame

2007-01-30 Thread Adam Winer
Danny, I grabbed the patch, made a branch, and applied it. I fixed up some things: - Moved (almost) all of the popup dialog and panel popup JS code into TrPanelPopup and TrPopupDialog wrapper objects - Fix coding convention problems: no tabs allowed, braces on new lines - Instead of removing th

Re: Early Prototype - Dialog using DHTML / iFrame

2007-01-30 Thread Matthias Wessendorf
taking no 3rd party js lib is welcome. To me it doesn't make sense to use a huge lib for "just one widget" -Matthias On 1/31/07, Danny Robinson <[EMAIL PROTECTED]> wrote: I'll post up a .patch file later today. I used custom .js for the dialog, as I wasn't sure how we'd go about integrating a

Re: svn commit: r500011 - /incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java

2007-01-30 Thread Scott O'Bryan
Yeah sorry, I didn't notice the comment either. I updates the JIRA ticket. You're correct Adam, and I need some advice on the ticket if you could. Jeanne Waldman wrote: Adam, I just noticed this email. I'll ping Scott. - Jeanne Adam Winer wrote: Has this change been tested? I'm far from c

Re: svn commit: r500011 - /incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java

2007-01-30 Thread Jeanne Waldman
Adam, I just noticed this email. I'll ping Scott. - Jeanne Adam Winer wrote: Has this change been tested? I'm far from certain that this was purely an optimization. We often check whether there is a PartialPageContext to see if PPR is enabled, and if this check is removed, then a lot of code w

Re: Early Prototype - Dialog using DHTML / iFrame

2007-01-30 Thread Danny Robinson
Patch file available here: http://thefoxberry.com/ Only note, is that this also contains the panelPopup component, and that you'll need to include the two .js files into the servlet that merges the common javascript. If I get chance later, I'll do this and repost the patch. Should work fine in

Re: Oracle Skin Release

2007-01-30 Thread Mark Robinson
Hi Matt, I've been working on a skin which looks like the old Oracle skin from ADF. There's been some moderate interest in it on the user mailing list. It is based upon images/CSS from inside Trinidad. What this means is that it's licensed under the Apache license. So it can be freely use

Re: Early Prototype - Dialog using DHTML / iFrame

2007-01-30 Thread Danny Robinson
I'll post up a .patch file later today. I used custom .js for the dialog, as I wasn't sure how we'd go about integrating a 3rd party lib, and the few I looked at didn't quite fit right, or had license issues. Besides, it was good practice. However, if we have a library that we're trying to inte

Re: [Skinning] CSS selector limit hit in IE

2007-01-30 Thread Jeanne Waldman
Hi Matt, Matt Cooper wrote: Hi Jeanne, That example of setting styleClass="AFInstructionText" (or styleClass="foo bar") was the case I was thinking about too and think it should be okay to have all compressed and all uncompressed. To be on the safe side, I just decided that what I can do is

Re: [Skinning] CSS selector limit hit in IE

2007-01-30 Thread Matt Cooper
Hi Jeanne, That example of setting styleClass="AFInstructionText" (or styleClass="foo bar") was the case I was thinking about too and think it should be okay to have all compressed and all uncompressed. If there are any cases where a component developer is writing a JavaScript counterpart to the

[Skinning] CSS selector limit hit in IE

2007-01-30 Thread Jeanne Waldman
Hi, Well, it turns out that IE has a limit to the size of a CSS file. It's not the actual size of the file, but rather it is the # of CSS selectors. I did a test and found out that the limit is 4095 CSS selectors. Firefox doesn't appear to have a limit. As you may know, the CSS file we genera

Re: Oracle Skin Release

2007-01-30 Thread Matthias Wessendorf
what does that mean ? "finished up the packing for thje Oracle Skin" ? Is it like "taking the ADF Faces Skin" and bundling it separate? If yes, I am pretty much sure that we cannot have it here in Trinidad, since that code belongs Oracle. Oracle donated *parts* of ADF Faces to the ASF, what is n

Oracle Skin Release

2007-01-30 Thread Mark Robinson
Hi Guys, I've finished up the packing for the Oracle Skin. Is there a sandbox/upload region available? Mark

Re: Early Prototype - Dialog using DHTML / iFrame

2007-01-30 Thread Matthias Wessendorf
HEy Danny, two things; 1) the image looks great. 2) do you use one of these days upcoming "ajax-ish" JavaScript libs? (or "custom" JS?) Another one, will you also provide the source in somewhat format? That would allow us to start with a sandbox .. Thanks, Matthias On 1/30/07, Danny Robinso

Re: unknown-version in generated css file

2007-01-30 Thread Jeanne Waldman
Yes, that is a better way. I'll add this to our impl pom.xml and our api pom.xml files. Thanks, Jeanne Adam Winer wrote: Jeanne, There's a better way. See: http://maven.apache.org/plugins/maven-jar-plugin/examples/manifest-customization.html "Starting with version 2.1, the maven-jar-pl

Early Prototype - Dialog using DHTML / iFrame

2007-01-30 Thread Danny Robinson
Hey, In a timely fashion, I've just seen Adams comments about wanting to switch to a DHTML/iFrame solution for dialog windows. I've pulled together a prototype set of changes that switches the default implementation of dialog windows, to use a floating popup iframe. It seems to work well and bo

Re: unknown-version in generated css file

2007-01-30 Thread Adam Winer
Jeanne, There's a better way. See: http://maven.apache.org/plugins/maven-jar-plugin/examples/manifest-customization.html "Starting with version 2.1, the maven-jar-plugin no longer creates the Specification and Implementation details in the manifest by default. If you want them you have to say