Re: TrainRenderer using the new train selectors

2006-08-31 Thread Simon Lessard
isited >> {background-image:url('/TrinidadDemo-MenuModel-context-root/skins/train/skin_images/JoinUnvisited.gif');background-repeat:repeat-x} >> >> > > > >> > > > >> > > > >> > > > >> > > > The classes

Re: TrainRenderer using the new train selectors

2006-08-31 Thread Jeanne Waldman
; > > > > > > > Regards, > > > > > > ~ Simon > > > > > > > > > > > > On 8/29/06, Pavitra Subramaniam <[EMAIL PROTECTED]> > > > wrote: > > > > > > > > It may also be a go

Re: TrainRenderer using the new train selectors

2006-08-30 Thread Simon Lessard
ent: Tuesday, August 29, 2006 5:24 PM > To: adffaces-dev@incubator.apache.org > Subject: Re: TrainRenderer using the new train selectors > > Added some inline comments > > On 8/29/06, Pavitra Subramaniam > <[EMAIL PROTECTED]> wrote: > > > > Hello Simon, Jeanne,

RE: TrainRenderer using the new train selectors

2006-08-30 Thread Pavitra Subramaniam
che.org > Subject: RE: TrainRenderer using the new train selectors > > Comments inline > > - Pavitra > > > > -Original Message- > > From: Simon Lessard [mailto:[EMAIL PROTECTED] > > Sent: Tuesday, August 29, 2006 5:24 PM > > To: adffaces-dev@inc

RE: TrainRenderer using the new train selectors

2006-08-30 Thread Pavitra Subramaniam
Comments inline - Pavitra > -Original Message- > From: Simon Lessard [mailto:[EMAIL PROTECTED] > Sent: Tuesday, August 29, 2006 5:24 PM > To: adffaces-dev@incubator.apache.org > Subject: Re: TrainRenderer using the new train selectors > > Added some inline com

RE: TrainRenderer using the new train selectors

2006-08-30 Thread Pavitra Subramaniam
org > Subject: Re: TrainRenderer using the new train selectors > > Hello, > > I did not have any nightmare in the end, I found a quote > instead: "Don't be too hard with Microsoft Internet Explorer, > it is not bad, you can download Firefox with it". > >

RE: TrainRenderer using the new train selectors

2006-08-30 Thread Pavitra Subramaniam
First Step - Pavitra > -Original Message- > From: Simon Lessard [mailto:[EMAIL PROTECTED] > Sent: Tuesday, August 29, 2006 6:54 PM > To: adffaces-dev@incubator.apache.org > Subject: Re: TrainRenderer using the new train selectors > &g

Re: TrainRenderer using the new train selectors

2006-08-30 Thread Simon Lessard
gt; Regards, > > > > > > ~ Simon > > > > > > > > > > > > On 8/29/06, Pavitra Subramaniam <[EMAIL PROTECTED]> > > > wrote: > > > > > > > > It may also be a good idea to update MVariableResolver.java, the > >

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Simon Lessard
<[EMAIL PROTECTED]> > > wrote: > > > > > > It may also be a good idea to update MVariableResolver.java, the > > > test code that sets up MenuModel #{pageList}, to include the visited, > > > disabled, unvisited + readOnly states. Right now the train gold

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Simon Lessard
; - Pavitra > > > > > > > -Original Message----- > > > From: Pavitra Subramaniam [mailto: [EMAIL PROTECTED] > > > Sent: Tuesday, August 29, 2006 2:46 PM > > > To: adffaces-dev@incubator.apache.org > > > Subject: RE: TrainRenderer using the

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Simon Lessard
vitra > > > > -Original Message- > > From: Pavitra Subramaniam [mailto:[EMAIL PROTECTED] > > Sent: Tuesday, August 29, 2006 2:46 PM > > To: adffaces-dev@incubator.apache.org > > Subject: RE: TrainRenderer using the new train selectors > > > > Hell

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Simon Lessard
dev@incubator.apache.org > Subject: RE: TrainRenderer using the new train selectors > > Hello Simon, Jeanne, > > I have some comments on both your email exhanges. I have > consolidated all the items below as it was getting hard to read. > > > >>>> > - af|trai

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Simon Lessard
ins. Thanks - Pavitra > -Original Message- > From: Simon Lessard [mailto:[EMAIL PROTECTED] > Sent: Tuesday, August 29, 2006 11:43 AM > To: adffaces-dev@incubator.apache.org > Subject: Re: TrainRenderer using the new train selectors > > Ok, > > Then if

RE: TrainRenderer using the new train selectors

2006-08-29 Thread Pavitra Subramaniam
age- > From: Pavitra Subramaniam [mailto:[EMAIL PROTECTED] > Sent: Tuesday, August 29, 2006 2:46 PM > To: adffaces-dev@incubator.apache.org > Subject: RE: TrainRenderer using the new train selectors > > Hello Simon, Jeanne, > > I have some comments on both your email exhan

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Jeanne Waldman
August 29, 2006 2:00 PM To: adffaces-dev@incubator.apache.org; [EMAIL PROTECTED] Subject: Re: TrainRenderer using the new train selectors Ah, don't that expose the markup though? ~ Simon On 8/29/06, Pavitra Subramaniam <[EMAIL PROTECTED] > wrote: I am using block to indicate style class th

RE: TrainRenderer using the new train selectors

2006-08-29 Thread Pavitra Subramaniam
bject: Re: TrainRenderer using the new train selectors Ah, don't that expose the markup though? ~ Simon On 8/29/06, Pavitra Subramaniam <[EMAIL PROTECTED] > wrote: I am using block to indicate style class that goes in a and technically I should use cell for style class that goes

RE: TrainRenderer using the new train selectors

2006-08-29 Thread Pavitra Subramaniam
ed? Can you send me a HTML fragment? Thanks - Pavitra > -Original Message- > From: Simon Lessard [mailto:[EMAIL PROTECTED] > Sent: Tuesday, August 29, 2006 11:43 AM > To: adffaces-dev@incubator.apache.org > Subject: Re: TrainRenderer using the new train selectors >

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Simon Lessard
> From: Simon Lessard [mailto:[EMAIL PROTECTED] > Sent: Tuesday, August 29, 2006 11:18 AM > To: adffaces-dev@incubator.apache.org > Subject: Re: TrainRenderer using the new train selectors > > Oups, comments below > > On 8/29/06, Jeanne Waldman <[EMAIL PROTECTED]> wrote: >

RE: TrainRenderer using the new train selectors

2006-08-29 Thread Pavitra Subramaniam
r.apache.org > Subject: Re: TrainRenderer using the new train selectors > > Oups, comments below > > On 8/29/06, Jeanne Waldman <[EMAIL PROTECTED]> wrote: > > > > one question below > > > > Simon Lessard wrote: > > > > > Hello Pavitra, &

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Jeanne Waldman
Sounds good to me. Simon Lessard wrote: Ok, Then if those selectors are ok for you as well Pavitra I'll make the changes to -outer and and -icon-cell tonight and upload the patch as well as a test skin I used. Regards, ~ Simon On 8/29/06, Jeanne Waldman <[EMAIL PROTECTED]> wrote: yep

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Simon Lessard
Ok, Then if those selectors are ok for you as well Pavitra I'll make the changes to -outer and and -icon-cell tonight and upload the patch as well as a test skin I used. Regards, ~ Simon On 8/29/06, Jeanne Waldman <[EMAIL PROTECTED]> wrote: yep, it all makes sense. I can see where you'd wan

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Jeanne Waldman
yep, it all makes sense. I can see where you'd want to use a ::content. That would make sense. We don't do this yet in any of our skinning keys, so I am fine with the -content, since we do that all over the place. :) - Jeanne Simon Lessard wrote: Oups, comments below On 8/29/06, Jeanne Wal

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Simon Lessard
Bleh, the "Does that make more sense now? Regards, ~ Simon" should have been placed much later, there're comments after it. And it should have been "Does it make more sense now? Regards, ~ Simon" Thanks to my broken English... On 8/29/06, Simon Lessard <[EMAIL PROTECTED]> wrote: Oups,

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Simon Lessard
Oups, comments below On 8/29/06, Jeanne Waldman <[EMAIL PROTECTED]> wrote: one question below Simon Lessard wrote: > Hello Pavitra, > > I had to do about the same changes on my side. Here's my list of selector > and the rules I used: > > - af|train::stop combinable with :selected, :disabled,

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Jeanne Waldman
one question below Simon Lessard wrote: Hello Pavitra, I had to do about the same changes on my side. Here's my list of selector and the rules I used: - af|train::stop combinable with :selected, :disabled, :completed (will probably become p_AFVisited) and :unvisited. You can append :readOnly

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Simon Lessard
Hello again, Here's the remaining of the mail as I had to send the last one in a hurry. I use the same join rule as you, that is previous stop determine the join state, except for the join after the selected stop. The only exception are disabled stops, those have disabled joins on both sides. I

Re: TrainRenderer using the new train selectors

2006-08-29 Thread Simon Lessard
Hello Pavitra, I had to do about the same changes on my side. Here's my list of selector and the rules I used: - af|train::stop combinable with :selected, :disabled, :completed (will probably become p_AFVisited) and :unvisited. You can append :readOnly at the end of the result. So af|train::stop

TrainRenderer using the new train selectors

2006-08-28 Thread Pavitra Subramaniam
Hello Simon, I have also almost completed implementing the TrainRenderer using the new skin selectors. It's great to know you are done as well. If you plan to check in the train renderer code anytime soon, can we agree on the common list of skin selectors, so that I can reuse them for my work i