No problem, raised as https://github.com/akka/akka/issues/17801
On Monday, 22 June 2015 13:23:02 UTC+1, Patrik Nordwall wrote:
>
> ok
> Sam, please open an issue.
> /Patrik
>
> On Mon, Jun 22, 2015 at 1:57 PM, Roland Kuhn > wrote:
>
>> Ah, it seems that I misunderstood: this filter is not part of
ok
Sam, please open an issue.
/Patrik
On Mon, Jun 22, 2015 at 1:57 PM, Roland Kuhn wrote:
> Ah, it seems that I misunderstood: this filter is not part of the
> pre-filtering that is done before even sending to the logger actor. Then
> disregard my comment about saving some cycles, within the log
Ah, it seems that I misunderstood: this filter is not part of the pre-filtering
that is done before even sending to the logger actor. Then disregard my comment
about saving some cycles, within the logger actor it is obviously too late for
that anyway.
Patrik, your comment brought back a dim rec
One problem could be if the string contains placeholders {}.
I would guess that the reason why we used debug("{}", message) was to avoid
the toString of the message if the level is not enabled. Checking the level
as you suggest might be enough.
When using LoggingAdapter we materialize it to a str
On Monday, 22 June 2015 11:30:30 UTC+1, √ wrote:
>
> Why deduplicate non-logged events at all?
>
> Doing the substitution but not incurring the IO cost must be worth it?
>
>
Turbo Filters are a well defined concept in Logback land:
http://logback.qos.ch/manual/filters.html#TurboFilter
The only lo
Why deduplicate non-logged events at all?
Doing the substitution but not incurring the IO cost must be worth it?
--
Cheers,
√
On 22 Jun 2015 11:09, "Roland Kuhn" wrote:
> It depends on what you want to achieve: not doing the substitution for
> non-logged events is an explicit goal in our infra
Does anyone see any major problems with this workaround? If not, I
recommend it as a patch to the mainline.
package akka.event.slf4j
import akka.actor._
import akka.event.Logging._
/**
* Stock Slf4jLogger actually logs everything as "{}" with a
* parameter, which is incompatible with much of
On Monday, 22 June 2015 10:02:06 UTC+1, √ wrote:
>
> Doing the filtering pre-substitution seems like a bug.
>
If you're suggesting that there is a bug in the filter, then that is not
true: it's a well documented, incredibly useful, feature:
http://logback.qos.ch/manual/filters.html#DuplicateMess
It depends on what you want to achieve: not doing the substitution for
non-logged events is an explicit goal in our infrastructure.
Regards,
Roland
> 22 jun 2015 kl. 11:02 skrev Viktor Klang :
>
> Doing the filtering pre-substitution seems like a bug.
>
> --
> Cheers,
> √
>
> On 22 Jun 2015
Doing the filtering pre-substitution seems like a bug.
--
Cheers,
√
On 22 Jun 2015 01:54, "Sam Halliday" wrote:
> Patrik,
>
> Thanks for investigating! You saved me a few hours off my Monday as I
> was going to go through this in detail and put together a minimal test
> case :-)
>
> Unfortunate
Patrik,
Thanks for investigating! You saved me a few hours off my Monday as I
was going to go through this in detail and put together a minimal test
case :-)
Unfortunately, your conclusion seems to be pretty damning. It might just
be this one turbofilter that is incompatible with akka, but its li
On Sun, Jun 21, 2015 at 4:04 PM, Sam Halliday
wrote:
> Everything is DEBUG, and this is akka 2.3.11.
>
ok
We log these (and all other things) with
Logger(logClass, logSource).debug("{}", message.asInstanceOf[AnyRef])
"{}" is the part that the duplicate filter will use to identify the log
messa
Everything is DEBUG, and this is akka 2.3.11.
On Sunday, 21 June 2015 15:03:48 UTC+1, Patrik Nordwall wrote:
>
> What akka.loglevel are you using?
>
> I guess that you see the changed behavior in 2.4-M1 compared to 2.3.11.
>
> In 2.4 we have added a check in LoggingReceive that it will only be act
What akka.loglevel are you using?
I guess that you see the changed behavior in 2.4-M1 compared to 2.3.11.
In 2.4 we have added a check in LoggingReceive that it will only be active
if the loglevel is DEBUG.
if (context.system.eventStream.logLevel >= Logging.DebugLevel) {
/Patrik
On Thu, Jun 1
Hi all,
I'm seeing something very weird.
When I enable the logback turboFilter DuplicateMessageFilter:
http://logback.qos.ch/manual/filters.html#DuplicateMessageFilter
https://github.com/qos-ch/logback/blob/master/logback-classic/src/main/java/ch/qos/logback/classic/turbo/DuplicateMessageF
15 matches
Mail list logo
