@@ -60,8 +60,10 @@ void ManualDWARFIndex::Index() {
}
if (dwp_info && dwp_info->ContainsTypeUnits()) {
for (size_t U = 0; U < dwp_info->GetNumUnits(); ++U) {
- if (auto *tu =
llvm::dyn_cast(dwp_info->GetUnitAtIndex(U)))
-units_to_index.push_back(tu);
+
@@ -0,0 +1,91 @@
+// REQUIRES: lld
+
+// This test will make a type that will be compiled differently into two
+// different .dwo files in a type unit with the same type hash, but with
+// differing contents. I have discovered that the hash for the type unit is
+// simply based
@@ -1726,44 +1725,59 @@ lldb::ModuleSP
SymbolFileDWARF::GetExternalModule(ConstString name) {
return pos->second;
}
-DWARFDIE
-SymbolFileDWARF::GetDIE(const DIERef _ref) {
- // This method can be called without going through the symbol vendor so we
- // need to lock the
@@ -21,9 +21,11 @@ class SymbolFileDWARFDwo;
class ManualDWARFIndex : public DWARFIndex {
public:
ManualDWARFIndex(Module , SymbolFileDWARF ,
- llvm::DenseSet units_to_avoid = {})
+ llvm::DenseSet units_to_avoid = {},
+
@@ -1726,44 +1725,59 @@ lldb::ModuleSP
SymbolFileDWARF::GetExternalModule(ConstString name) {
return pos->second;
}
-DWARFDIE
-SymbolFileDWARF::GetDIE(const DIERef _ref) {
- // This method can be called without going through the symbol vendor so we
- // need to lock the
@@ -2717,7 +2731,6 @@ void SymbolFileDWARF::FindTypes(const TypeQuery ,
TypeResults ) {
die_context = die.GetDeclContext();
else
die_context = die.GetTypeLookupContext();
-assert(!die_context.empty());
bulbazord wrote:
Why remove the
@@ -48,15 +60,31 @@ DebugNamesDWARFIndex::GetUnits(const DebugNames
_names) {
return result;
}
+DWARFTypeUnit *
+DebugNamesDWARFIndex::GetForeignTypeUnit(const DebugNames::Entry ) const
{
+ std::optional type_sig = entry.getForeignTUTypeSignature();
+ if (type_sig)
@@ -273,6 +301,44 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
if (!isType(entry.tag()))
continue;
+
+DWARFTypeUnit *foreign_tu = GetForeignTypeUnit(entry);
+if (foreign_tu) {
+ // If this entry represents a foreign type unit, we need to verify
@@ -693,7 +693,6 @@ llvm::DWARFDebugAbbrev *SymbolFileDWARF::DebugAbbrev() {
if (debug_abbrev_data.GetByteSize() == 0)
return nullptr;
- ElapsedTime elapsed(m_parse_time);
bulbazord wrote:
Why remove this `ElapsedTime`?
@@ -34,6 +34,18 @@ DebugNamesDWARFIndex::Create(Module ,
DWARFDataExtractor debug_names,
module, std::move(index_up), debug_names, debug_str, dwarf));
}
+
+llvm::DenseSet
+DebugNamesDWARFIndex::GetTypeUnitSigs(const DebugNames _names) {
bulbazord
@@ -273,6 +301,44 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
if (!isType(entry.tag()))
continue;
+
+DWARFTypeUnit *foreign_tu = GetForeignTypeUnit(entry);
+if (foreign_tu) {
bulbazord wrote:
nit: Merge these two lines
```
if
@@ -273,6 +301,44 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
if (!isType(entry.tag()))
continue;
+
+DWARFTypeUnit *foreign_tu = GetForeignTypeUnit(entry);
+if (foreign_tu) {
+ // If this entry represents a foreign type unit, we need to verify
bulbazord wrote:
> Why don't we just remove the enum from SBDebugger and use the one from
> Debugger instead, this will ensure the offsets are always the same.
SBDebugger is public and Debugger is private, so I'm not sure how you can do
this? Maybe I'm misunderstanding your suggestion...
It
https://github.com/bulbazord approved this pull request.
Rewriting this has been on my backlog for a few months now. This looks better
than what I had in mind. Thank you!
https://github.com/llvm/llvm-project/pull/87263
___
lldb-commits mailing
@@ -1089,6 +1089,116 @@ int64_t ValueObject::GetValueAsSigned(int64_t
fail_value, bool *success) {
return fail_value;
}
+llvm::APSInt ValueObject::GetValueAsAPSInt() {
+ lldb::TargetSP target = GetTargetSP();
+ uint64_t byte_size = 0;
+ if (auto temp =
@@ -1089,6 +1089,116 @@ int64_t ValueObject::GetValueAsSigned(int64_t
fail_value, bool *success) {
return fail_value;
}
+llvm::APSInt ValueObject::GetValueAsAPSInt() {
+ lldb::TargetSP target = GetTargetSP();
+ uint64_t byte_size = 0;
+ if (auto temp =
@@ -2809,6 +2919,243 @@ ValueObjectSP ValueObject::CastPointerType(const char
*name, TypeSP _sp) {
return valobj_sp;
}
+lldb::addr_t ValueObject::GetLoadAddress() {
+ lldb::addr_t addr_value = LLDB_INVALID_ADDRESS;
+ lldb::TargetSP target_sp = GetTargetSP();
+ if
@@ -2809,6 +2919,243 @@ ValueObjectSP ValueObject::CastPointerType(const char
*name, TypeSP _sp) {
return valobj_sp;
}
+lldb::addr_t ValueObject::GetLoadAddress() {
+ lldb::addr_t addr_value = LLDB_INVALID_ADDRESS;
+ lldb::TargetSP target_sp = GetTargetSP();
+ if
@@ -2809,6 +2919,243 @@ ValueObjectSP ValueObject::CastPointerType(const char
*name, TypeSP _sp) {
return valobj_sp;
}
+lldb::addr_t ValueObject::GetLoadAddress() {
+ lldb::addr_t addr_value = LLDB_INVALID_ADDRESS;
+ lldb::TargetSP target_sp = GetTargetSP();
+ if
@@ -2809,6 +2919,243 @@ ValueObjectSP ValueObject::CastPointerType(const char
*name, TypeSP _sp) {
return valobj_sp;
}
+lldb::addr_t ValueObject::GetLoadAddress() {
+ lldb::addr_t addr_value = LLDB_INVALID_ADDRESS;
+ lldb::TargetSP target_sp = GetTargetSP();
+ if
@@ -1089,6 +1089,116 @@ int64_t ValueObject::GetValueAsSigned(int64_t
fail_value, bool *success) {
return fail_value;
}
+llvm::APSInt ValueObject::GetValueAsAPSInt() {
+ lldb::TargetSP target = GetTargetSP();
+ uint64_t byte_size = 0;
+ if (auto temp =
@@ -2809,6 +2919,243 @@ ValueObjectSP ValueObject::CastPointerType(const char
*name, TypeSP _sp) {
return valobj_sp;
}
+lldb::addr_t ValueObject::GetLoadAddress() {
+ lldb::addr_t addr_value = LLDB_INVALID_ADDRESS;
+ lldb::TargetSP target_sp = GetTargetSP();
+ if
@@ -618,6 +631,24 @@ class ValueObject {
virtual lldb::ValueObjectSP CastPointerType(const char *name,
lldb::TypeSP _sp);
+ /// Return the target load address assocaited with this value object.
+ lldb::addr_t GetLoadAddress();
@@ -1089,6 +1089,116 @@ int64_t ValueObject::GetValueAsSigned(int64_t
fail_value, bool *success) {
return fail_value;
}
+llvm::APSInt ValueObject::GetValueAsAPSInt() {
+ lldb::TargetSP target = GetTargetSP();
+ uint64_t byte_size = 0;
+ if (auto temp =
@@ -1089,6 +1089,116 @@ int64_t ValueObject::GetValueAsSigned(int64_t
fail_value, bool *success) {
return fail_value;
}
+llvm::APSInt ValueObject::GetValueAsAPSInt() {
+ lldb::TargetSP target = GetTargetSP();
+ uint64_t byte_size = 0;
+ if (auto temp =
@@ -1089,6 +1089,116 @@ int64_t ValueObject::GetValueAsSigned(int64_t
fail_value, bool *success) {
return fail_value;
}
+llvm::APSInt ValueObject::GetValueAsAPSInt() {
+ lldb::TargetSP target = GetTargetSP();
+ uint64_t byte_size = 0;
+ if (auto temp =
@@ -1089,6 +1089,116 @@ int64_t ValueObject::GetValueAsSigned(int64_t
fail_value, bool *success) {
return fail_value;
}
+llvm::APSInt ValueObject::GetValueAsAPSInt() {
+ lldb::TargetSP target = GetTargetSP();
+ uint64_t byte_size = 0;
+ if (auto temp =
@@ -618,6 +631,24 @@ class ValueObject {
virtual lldb::ValueObjectSP CastPointerType(const char *name,
lldb::TypeSP _sp);
+ /// Return the target load address assocaited with this value object.
bulbazord wrote:
https://github.com/bulbazord requested changes to this pull request.
+1 to all of Jim and Adrian's comments.
High level comments:
1. I'm a little concerned about the use of assertions in this patch. I
generally like assertions when they are used to assert internal consistency. It
looks like
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/87197
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
> > Could you add a test for these new methods in
> > `unittests/Utility/ScalarTest.cpp`?
>
> Done. :-)
Thank you! :)
https://github.com/llvm/llvm-project/pull/86862
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/86862
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord requested changes to this pull request.
Could you add a test for these new methods in
`unittests/Utility/ScalarTest.cpp`?
https://github.com/llvm/llvm-project/pull/86862
___
lldb-commits mailing list
https://github.com/bulbazord approved this pull request.
Makes sense to me.
https://github.com/llvm/llvm-project/pull/86888
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/86605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3154,7 +3154,7 @@
AppleObjCRuntimeV2::TaggedPointerVendorExtended::GetClassDescriptor(
<< m_objc_debug_taggedpointer_ext_payload_lshift)
>>
m_objc_debug_taggedpointer_ext_payload_rshift);
int64_t
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/86740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3154,7 +3154,7 @@
AppleObjCRuntimeV2::TaggedPointerVendorExtended::GetClassDescriptor(
<< m_objc_debug_taggedpointer_ext_payload_lshift)
>>
m_objc_debug_taggedpointer_ext_payload_rshift);
int64_t
@@ -491,34 +491,42 @@ which will work like all the natively defined lldb
commands. This provides a
very flexible and easy way to extend LLDB to meet your debugging requirements.
To write a python function that implements a new LLDB command define the
-function to take four
@@ -491,34 +491,42 @@ which will work like all the natively defined lldb
commands. This provides a
very flexible and easy way to extend LLDB to meet your debugging requirements.
To write a python function that implements a new LLDB command define the
-function to take four
https://github.com/bulbazord approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/86593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/86593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
What happens if you have colors disabled in your terminal? Does this do
nothing? Or does it start inserting ANSI escape codes in plain text?
https://github.com/llvm/llvm-project/pull/86159
___
lldb-commits mailing list
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/85858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/85861
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/85861
>From c24630bbccd3d53079314f7dc6393ffa27ea192f Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Tue, 19 Mar 2024 13:18:23 -0700
Subject: [PATCH 1/2] [lldb] Remove process restart prompt from
@@ -323,13 +323,13 @@ def test_artificial_source_location(self):
)
self.expect(
-"run",
-RUN_SUCCEEDED,
+"thread info", substrs=[f"{src_file}:0", "stop reason =
breakpoint"]
+)
+self.expect(
+
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/85861
In TestSourceManager, test_artificial_source_location will give the process
restart prompt if you run the test individually. The reason is that we run the
process twice: first using a convenience function to
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/85858
AddressableBits is in the Utility module of LLDB. It currently directly refers
to Process, which is from the Target LLDB module. This is a layering violation
which concretely means that it is impossible to
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/85855
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/85855
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -50,6 +50,11 @@ static constexpr OptionDefinition g_variable_options[] = {
"Specify a summary string to use to format the variable output."},
};
+static constexpr auto g_num_frame_options = 4;
bulbazord wrote:
Is this number computable? Or does it
https://github.com/bulbazord commented:
Big fan of centralizing the options here. I had one question about automating
another portion of this, but otherwise LGTM.
https://github.com/llvm/llvm-project/pull/85855
___
lldb-commits mailing list
https://github.com/bulbazord approved this pull request.
+1 to Adrian's suggestion.
LGTM since you've addressed that now
https://github.com/llvm/llvm-project/pull/85342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/83941
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/83941
>From 89d1c201636403bb26f12cf9681cbaf86b5c943b Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 4 Mar 2024 14:17:20 -0800
Subject: [PATCH] [lldb] Add ability to detect darwin host linker version to
@@ -168,8 +168,8 @@ class ConstString {
// Implicitly convert \class ConstString instances to \class StringRef.
operator llvm::StringRef() const { return GetStringRef(); }
- // Implicitly convert \class ConstString instances to \class
std::string_view.
- operator
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/83941
>From a72d9d259b441c338399340d630ed7a64c1e228a Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 4 Mar 2024 14:17:20 -0800
Subject: [PATCH] [lldb] Add ability to detect darwin host linker version to
bulbazord wrote:
> Called it `ld_new-bug`. If it's not the TLS bug, I wonder if the version
> range is correct.
The TLS bug in the new linker is explicitly from versions 1000 to 1109. If this
isn't related to TLS, we'll need to confirm with the linker folks on our side.
bulbazord wrote:
> To start with option #1, I created #84246
Just took a look, thanks for taking care of that. I'll address your feedback
(or just look at what you did in the other PR) and update this tomorrow.
https://github.com/llvm/llvm-project/pull/83941
https://github.com/bulbazord approved this pull request.
Thanks for taking care of that!
https://github.com/llvm/llvm-project/pull/84246
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/84262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
I'm a little disappointed but I think this is the right step to take. Thanks!
https://github.com/llvm/llvm-project/pull/83501
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/83941
When Apple released its new linker, it had a subtle bug that caused LLDB's TLS
tests to fail. Unfortunately this means that TLS tests are not going to work on
machines that have affected versions of the
bulbazord wrote:
> I would almost vote to change everything to `uint64_t` except for the public
> API since we can't change the API without breaking. Though I winder if we can
> actually change this one:
>
> ```
> uint64_t SBValue::GetNumChildren();
> ```
>
> Since the return value isn't
bulbazord wrote:
Why not increase TypeSystem::GetNumChildren to return a size_t instead?
https://github.com/llvm/llvm-project/pull/83501
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/bulbazord approved this pull request.
Looks great!!! Thanks for fixing the bug and gardening!
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/83502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
@DavidSpickett If you haven't already, might I suggest looking into a CMake
setting I implemented last year? `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS` --
this will cause your CMake configure step to fail if your bots are missing
python packages so that you know your bots are
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/83317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Thinkos are the most insidious bugs. Nice catch.
https://github.com/llvm/llvm-project/pull/83350
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/83341
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
:)
https://github.com/llvm/llvm-project/pull/83330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/83317
This specifically addresses the warnings:
$LLVM/lldb/include/lldb/API/SBCommandReturnObject.h:119: Warning 509:
Overloaded method lldb::SBCommandReturnObject::PutCString(char const *)
effectively ignored,
https://github.com/bulbazord approved this pull request.
LGTM
@JDevlieghere @adrian-prantl we should consider adding this to the list of
required python modules on our bots too and enforce it with
`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS`? Probably not in this PR, but after we
can get our bots
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/83086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/83086
This updates the remaining SetOptionValue methods in CommandObjectBreakpoint to
use CreateOptionParsingError.
I found a few minor bugs that were fixed during this refactor (e.g. using the
wrong flag in an
@@ -3944,15 +3955,22 @@ rnb_err_t RNBRemote::HandlePacket_v(const char *p) {
// The order of these checks is important.
if (process_does_not_exist (pid_attaching_to)) {
DNBLogError("Tried to attach to pid that doesn't exist");
- std::string
https://github.com/bulbazord approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/82672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
拾
Please wait a little bit for others to look. Thanks for taking care of this!
https://github.com/llvm/llvm-project/pull/82670
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3944,15 +3955,22 @@ rnb_err_t RNBRemote::HandlePacket_v(const char *p) {
// The order of these checks is important.
if (process_does_not_exist (pid_attaching_to)) {
DNBLogError("Tried to attach to pid that doesn't exist");
- std::string
https://github.com/bulbazord approved this pull request.
LGTM, seems like a good fix. One question/suggestion.
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/82273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/82526
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
I've added a doxygen comment to the new function I introduced. I plan on
landing this later today if there are no objections.
https://github.com/llvm/llvm-project/pull/82273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/82273
>From 790810f9318c7947fe2edd187f60425a85c949b5 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Thu, 15 Feb 2024 17:39:42 -0800
Subject: [PATCH 1/2] [lldb] Standardize command option parsing error messages
@@ -456,8 +457,9 @@ def queues_with_libBacktraceRecording(self):
"doing_the_work_2",
"queue 2's pending item #0 should be doing_the_work_2",
)
-self.assertTrue(
-queue_performer_2.GetPendingItemAtIndex().IsValid() ==
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/82503
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
I did a quick manual inspection of all of them, the transformation produced by
Teyit looks correct to me. I did notice a few places where we were doing
convoluted checks (I left a comment on one) but those should be addressed in
bulbazord wrote:
> > > This LGTM!
> > > I don't think I can see far enough ahead on what you are planning here,
> > > but I was just wondering if the ultimate goal is to have the
> > > `option_arg.getAsT` return an `Expected`. In this case, wouldn't all
> > > these arguments (short option,
bulbazord wrote:
> This LGTM!
>
> I don't think I can see far enough ahead on what you are planning here, but I
> was just wondering if the ultimate goal is to have the `option_arg.getAsT`
> return an `Expected`. In this case, wouldn't all these arguments (short
> option, long option,
https://github.com/bulbazord approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/82085
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/82273
I have been looking to simplify parsing logic and improve the interfaces so
that they are both easier to use and harder to abuse. To be specific, I am
referring to functions such as
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/82096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
> The downside of doing the initialization manually is that we do lose a bit of
> test coverage. For example, issue #70453 also manifested itself in the unit
> tests.
I think this is an acceptable tradeoff. The unit tests are for testing LLDB's
python internals, not for
https://github.com/bulbazord approved this pull request.
Makes sense to me.
https://github.com/llvm/llvm-project/pull/82095
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1139,6 +1097,15 @@ class CommandObjectPlatformProcessLaunch : public
CommandObjectParsed {
m_arguments.push_back({run_arg_arg});
}
+ void
+ HandleArgumentCompletion(CompletionRequest ,
+ OptionElementVector _element_vector) override {
@@ -305,6 +305,42 @@ void CommandObject::HandleCompletion(CompletionRequest
) {
}
}
+void
+CommandObject::HandleArgumentCompletion(CompletionRequest ,
+ OptionElementVector _element_vector) {
+ size_t num_arg_entries = GetNumArgumentEntries();
+
@@ -243,7 +243,7 @@ static constexpr CommandObject::ArgumentTableEntry
g_argument_table[] = {
{ lldb::eArgTypeLogCategory, "log-category",
lldb::CompletionType::eNoCompletion, {}, { nullptr, false }, "The name of a
category within a log channel, e.g. all (try \"log list\"
201 - 300 of 1257 matches
Mail list logo
