[Lldb-commits] [lldb] [lldb-vscode] Allow specifying a custom escape character for LLDB commands (PR #69238)

2023-10-16 Thread Alex Langford via lldb-commits
bulbazord wrote: > With "lldb-vscode" (which might be "lldb-dap" soon) being a native DAP > plug-in, I believe this means we can't set settings in the IDE itself if we > are not a typescript DAP plug-in. > > How would anyone specify this extra option when running lldb-vscode? Is there > a

[Lldb-commits] [lldb] [lldb] Scalar::GetValue() should take a Stream by reference (PR #69231)

2023-10-16 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/69231 This function always expects the pointer to be valid, a reference seems more appropriate. >From fd70abe32d822be5a791f8650c86ca61a86fa755 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Mon, 16 Oct 2023

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

2023-10-13 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Thanks for taking the time to clean this up, and thanks for taking the time to make sure this wouldn't hurt us downstream with swift! https://github.com/llvm/llvm-project/pull/68927 ___

[Lldb-commits] [lldb] [LLDB] Fix type formatting empty c-strings (PR #68924)

2023-10-13 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. I'm alright with this, though I'm a little concerned that the return value of `ReadCStringFromMemory` and `error.Success()` don't give you the same result. I'm also somewhat sad that we have to check **both** of those to know if we

[Lldb-commits] [lldb] [lldb] Add SBType::FindNestedType() function (PR #68705)

2023-10-10 Thread Alex Langford via lldb-commits
@@ -1082,6 +1082,19 @@ bool TypeImpl::GetDescription(lldb_private::Stream , return true; } +CompilerType TypeImpl::FindNestedType(ConstString name) { + auto type_system = GetTypeSystem(false); bulbazord wrote: Can you add an inline comment for this false?

[Lldb-commits] [lldb] [lldb] Add SBType::FindNestedType() function (PR #68705)

2023-10-10 Thread Alex Langford via lldb-commits
@@ -1082,6 +1082,19 @@ bool TypeImpl::GetDescription(lldb_private::Stream , return true; } +CompilerType TypeImpl::FindNestedType(ConstString name) { + auto type_system = GetTypeSystem(false); + auto *symbol_file = type_system->GetSymbolFile(); + auto decl_context =

[Lldb-commits] [lldb] [lldb] Add SBType::FindNestedType() function (PR #68705)

2023-10-10 Thread Alex Langford via lldb-commits
@@ -586,6 +586,15 @@ lldb::TemplateArgumentKind SBType::GetTemplateArgumentKind(uint32_t idx) { return eTemplateArgumentKindNull; } +SBType SBType::FindNestedType(const char *name) { + LLDB_INSTRUMENT_VA(this); bulbazord wrote: `name` needs to be in the

[Lldb-commits] [lldb] [lldb][DataFormatter] unordered_map: account for new libc++ __hash_node layout (PR #68574)

2023-10-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/68574 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] unordered_map: account for new libc++ __hash_node layout (PR #68574)

2023-10-10 Thread Alex Langford via lldb-commits
@@ -162,10 +162,21 @@ lldb::ValueObjectSP lldb_private::formatters:: if (!node_sp || error.Fail()) return nullptr; - value_sp = node_sp->GetChildMemberWithName("__value_"); hash_sp = node_sp->GetChildMemberWithName("__hash_"); - if (!value_sp

[Lldb-commits] [lldb] [lldb][NFCI] Remove use of ConstString from FilterRule in StructuredDataDarwinLog (PR #68347)

2023-10-09 Thread Alex Langford via lldb-commits
@@ -252,7 +253,8 @@ class FilterRule { const bool m_accept; const size_t m_attribute_index; - const ConstString m_operation; + // The lifetime of m_operation should be static. bulbazord wrote: Ah, yeah it is a little confusing now that I look at it. I

[Lldb-commits] [lldb] [lldb][DataFormatter] unordered_map: account for new libc++ __hash_node layout (PR #68574)

2023-10-09 Thread Alex Langford via lldb-commits
@@ -162,10 +162,21 @@ lldb::ValueObjectSP lldb_private::formatters:: if (!node_sp || error.Fail()) return nullptr; - value_sp = node_sp->GetChildMemberWithName("__value_"); hash_sp = node_sp->GetChildMemberWithName("__hash_"); - if (!value_sp

[Lldb-commits] [lldb] [lldb][NFCI] Remove use of ConstString from FilterRule in StructuredDataDarwinLog (PR #68347)

2023-10-09 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/68347 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose SBPlatform::GetAllProcesses to the SB API (PR #68378)

2023-10-05 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/68378 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

2023-10-05 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. The warnings look good to me, thanks for taking care of that. How does this look @jimingham? https://github.com/llvm/llvm-project/pull/68013 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb][NFCI] Remove use of ConstString from FilterRule in StructuredDataDarwinLog (PR #68347)

2023-10-05 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/68347 There are only ever 2 FilterRules and their operations are either "regex" or "match". This does not benefit from deduplication since the strings have static lifetime and we can just compare StringRefs

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

2023-10-04 Thread Alex Langford via lldb-commits
bulbazord wrote: > I think we need to make it clear wherever in the build system that the knob > for turning on these exports lives that you use these symbols at your own > risk, and we guarantee NO ABI stability for anything but the SB API's. We > know that on this list but somebody getting

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

2023-10-04 Thread Alex Langford via lldb-commits
bulbazord wrote: Personally I have no qualms about this. It's just an option that lets you choose which symbols to export. We already allow exporting every symbol, why not just some of them? I would be careful though, since we don't guarantee any stability for lldb_private (including things

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

2023-10-04 Thread Alex Langford via lldb-commits
bulbazord wrote: I have no problem with putting things form SymbolFileDWARF into its own namespace. Let's wait a bit though to see if anyone else has any opinions. https://github.com/llvm/llvm-project/pull/68150 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 91223c9 - [lldb] Unbreak debian build after dd76375c8009

2023-10-03 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-10-03T16:11:02-07:00 New Revision: 91223c92f7f7e1a6c074a28de6b5206c22eec116 URL: https://github.com/llvm/llvm-project/commit/91223c92f7f7e1a6c074a28de6b5206c22eec116 DIFF: https://github.com/llvm/llvm-project/commit/91223c92f7f7e1a6c074a28de6b5206c22eec116.diff

[Lldb-commits] [lldb] dd76375 - [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction

2023-10-03 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-10-03T10:27:18-07:00 New Revision: dd76375c80098be4d08b7e02290e39a8c1d00ab1 URL: https://github.com/llvm/llvm-project/commit/dd76375c80098be4d08b7e02290e39a8c1d00ab1 DIFF: https://github.com/llvm/llvm-project/commit/dd76375c80098be4d08b7e02290e39a8c1d00ab1.diff

[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

2023-10-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Lgtm https://github.com/llvm/llvm-project/pull/68050 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

2023-10-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Looks fine to me, but I want to really make sure we get this interface right. Left some comments inline. https://github.com/llvm/llvm-project/pull/68050 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

2023-10-02 Thread Alex Langford via lldb-commits
@@ -574,6 +576,29 @@ SBError SBPlatform::Launch(SBLaunchInfo _info) { }); } +SBProcess SBPlatform::Attach(SBAttachInfo _info, + const SBDebugger , SBTarget , + SBError ) { + LLDB_INSTRUMENT_VA(this, attach_info);

[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

2023-10-02 Thread Alex Langford via lldb-commits
@@ -574,6 +576,29 @@ SBError SBPlatform::Launch(SBLaunchInfo _info) { }); } +SBProcess SBPlatform::Attach(SBAttachInfo _info, + const SBDebugger , SBTarget , bulbazord wrote: I'd like to see the `attach_info` parameter marked

[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

2023-10-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/68050 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

2023-10-02 Thread Alex Langford via lldb-commits
@@ -19,6 +20,7 @@ struct PlatformShellCommand; namespace lldb { class SBLaunchInfo; +class SBAttachInfo; bulbazord wrote: sort https://github.com/llvm/llvm-project/pull/68050 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Replace lldb's DWARFDebugAbbrev implementation with llvm's (PR #67841)

2023-10-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/67841 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Alex Langford via lldb-commits
bulbazord wrote: Adding Jonas and Adrian for visibility https://github.com/llvm/llvm-project/pull/67851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-09-29 Thread Alex Langford via lldb-commits
bulbazord wrote: I think I am on the same page with Greg for not exposing these symbols for not shoving everything into `lldb_private`. Perhaps instead of `lldb_plugin` we can name it something like `lldb_private::plugin` instead? Not a huge difference, but keeping the top-level private

[Lldb-commits] [lldb] 12f4e11 - [lldb][NFCI] Remove unneeded use of ConstString from StructuredDataDarwinLog

2023-09-29 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-09-29T14:09:22-07:00 New Revision: 12f4e113869ff93d7b25cfc83c56f546e3d52c0f URL: https://github.com/llvm/llvm-project/commit/12f4e113869ff93d7b25cfc83c56f546e3d52c0f DIFF: https://github.com/llvm/llvm-project/commit/12f4e113869ff93d7b25cfc83c56f546e3d52c0f.diff

[Lldb-commits] [lldb] 2e12fc3 - [lldb][NFCI] Remove unused constructors from BreakpointName

2023-09-29 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-09-29T12:06:13-07:00 New Revision: 2e12fc3d04032be743b2aded354d81d53c5195ec URL: https://github.com/llvm/llvm-project/commit/2e12fc3d04032be743b2aded354d81d53c5195ec DIFF: https://github.com/llvm/llvm-project/commit/2e12fc3d04032be743b2aded354d81d53c5195ec.diff

[Lldb-commits] [lldb] [lldb] Replace lldb's DWARFDebugAbbrev implementation with llvm's (PR #67841)

2023-09-29 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/67841 The implementations are now close enough that replacing it is trivial. >From 8913eb7f4c768545debf12dd42f2e308466f200b Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Fri, 29 Sep 2023 11:09:09 -0700

[Lldb-commits] [lldb] [lldb][NFCI] Move functionality for getting unsupported DW_FORM values (PR #67579)

2023-09-28 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/67579 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a bug in handling ^C at the "y/n/a" completion prompt. (PR #67621)

2023-09-27 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM, thanks! Please fix the python formatting before landing. https://github.com/llvm/llvm-project/pull/67621 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/67599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Alex Langford via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Alex Langford via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Alex Langford via lldb-commits
@@ -0,0 +1,65 @@ +//===-- ValueObjectVTable.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Alex Langford via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Alex Langford via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Overall I think this is fine, just a few comments here or there. I like the idea a lot, thanks for working on this. https://github.com/llvm/llvm-project/pull/67599 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb][NFCI] Move functionality for getting unsupported DW_FORM values (PR #67579)

2023-09-27 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/67579 The LLVM implementation of DWARFDebugAbbrev does not have a way of listing all the DW_FORM values that have been parsed but are unsupported or otherwise unknown. AFAICT this functionality does not exist in

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb] Add SetValueFromCString API to SyntheticFronend (PR #67309)

2023-09-25 Thread Alex Langford via lldb-commits
@@ -34,7 +34,9 @@ class SyntheticChildrenFrontEnd { public: SyntheticChildrenFrontEnd(ValueObject ) - : m_backend(backend), m_valid(true) {} + : m_backend(backend), m_valid(true) { +backend.SetSyntheticFrontend(this); + } bulbazord wrote:

[Lldb-commits] [lldb] [lldb] Add SetValueFromCString API to SyntheticFronend (PR #67309)

2023-09-25 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/67309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SetValueFromCString API to SyntheticFronend (PR #67309)

2023-09-25 Thread Alex Langford via lldb-commits
@@ -75,6 +77,10 @@ class SyntheticChildrenFrontEnd { // display purposes virtual ConstString GetSyntheticTypeName() { return ConstString(); } + virtual bool SetValueFromCString(const char *value_str, Status ) { +return false; + } + bulbazord wrote:

[Lldb-commits] [lldb] [lldb] Add SetValueFromCString API to SyntheticFronend (PR #67309)

2023-09-25 Thread Alex Langford via lldb-commits
https://github.com/bulbazord requested changes to this pull request. I echo Jim's sentiments here, not sure if this is the right way to go about it. Independent of that, I have one concern about the implementation and a few minor points. https://github.com/llvm/llvm-project/pull/67309

[Lldb-commits] [lldb] [lldb] Add SetValueFromCString API to SyntheticFronend (PR #67309)

2023-09-25 Thread Alex Langford via lldb-commits
@@ -1535,7 +1535,12 @@ bool ValueObject::SetValueFromCString(const char *value_str, Status ) { } } else { // We don't support setting things bigger than a scalar at present. -error.SetErrorString("unable to write aggregate data type"); +// But maybe our

[Lldb-commits] [lldb] [lldb] Modify the DWARFDebugAbbrev interface to be closer to LLVM's (PR #67190)

2023-09-25 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/67190 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,165 @@ +#ifndef LLDB_SOURCE_PLUGINS_DYNAMICLOADER_FREEBSD_KERNEL_DYNAMICLOADERFREEBSDKERNEL_H bulbazord wrote: This file needs a license header. https://github.com/llvm/llvm-project/pull/67106 ___

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -935,6 +935,16 @@ lldb_private::Address ObjectFileELF::GetEntryPointAddress() { } Address ObjectFileELF::GetBaseAddress() { + if (GetType() == ObjectFile::eTypeObjectFile) { +for (SectionHeaderCollIter I = std::next(m_section_headers.begin()); + I !=

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Alex Langford via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: bulbazord wrote: You also may want to change the title of your PR to reflect the actual change you'll be making as well. When you squash and merge, you'll have an opportunity to rewrite the commit message to more accurately reflect what

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Alex Langford via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: bulbazord wrote: Concretely, you can revert the first commit and push that so that your branch has your first commit, second commit, and a revert commit for the first one. As Walter said, it should squash down and resolve correctly.

[Lldb-commits] [lldb] [lldb] Modify the DWARFDebugAbbrev interface to be closer to LLVM's (PR #67190)

2023-09-22 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/67190 I want to work towards unifying the implementations. It would be a lot easier to do if LLDB's DWARFDebugAbbrev looked more similar to LLVM's implementation, so this change moves in that direction. >From

[Lldb-commits] [lldb] [lldb][NFCI] Change parameter type in UserExpression::GetObjectPointer (PR #67055)

2023-09-22 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/67055 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

2023-09-22 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Makes sense to me, if we're defining a lot of the methods for these classes in implementation files, we should do the same for constructors and destructors too. https://github.com/llvm/llvm-project/pull/67165

[Lldb-commits] [lldb] [lldb][NFCI] Change parameter type in UserExpression::GetObjectPointer (PR #67055)

2023-09-21 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/67055 GetObjectPointer (and other related methods) do not need `ConstString` parameters. The string parameter in these methods boil down to getting a StringRef and calling

[Lldb-commits] [lldb] b927490 - [lldb][NFCI] Remove unused struct ConstString::StringIsEqual

2023-09-19 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-09-19T17:39:22-07:00 New Revision: b927490d73eebe0a7e8071047d79a330145b0488 URL: https://github.com/llvm/llvm-project/commit/b927490d73eebe0a7e8071047d79a330145b0488 DIFF: https://github.com/llvm/llvm-project/commit/b927490d73eebe0a7e8071047d79a330145b0488.diff

[Lldb-commits] [lldb] [lldb][NFCI] Remove unneccessary allocation in ScriptInterpreterPythonImpl::GetSyntheticTypeName (PR #66724)

2023-09-19 Thread Alex Langford via lldb-commits
bulbazord wrote: Fixed with `f1097e88d22511f3ec96386ca165b75bb75aaa7a`. https://github.com/llvm/llvm-project/pull/66724 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f1097e8 - [lldb] Fix build after d5a62b78b8ae

2023-09-19 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-09-19T10:56:13-07:00 New Revision: f1097e88d22511f3ec96386ca165b75bb75aaa7a URL: https://github.com/llvm/llvm-project/commit/f1097e88d22511f3ec96386ca165b75bb75aaa7a DIFF: https://github.com/llvm/llvm-project/commit/f1097e88d22511f3ec96386ca165b75bb75aaa7a.diff

[Lldb-commits] [lldb] [lldb][NFCI] Remove unneccessary allocation in ScriptInterpreterPythonImpl::GetSyntheticTypeName (PR #66724)

2023-09-19 Thread Alex Langford via lldb-commits
bulbazord wrote: I'm aware this has broken the build, working on it. Thanks for your patience. https://github.com/llvm/llvm-project/pull/66724 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb][NFCI] Remove unneccessary allocation in ScriptInterpreterPythonImpl::GetSyntheticTypeName (PR #66724)

2023-09-19 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/66724 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Remove unneeded ConstString from intel-pt plugin (PR #66721)

2023-09-19 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/66721 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Remove unneccessary allocation in ScriptInterpreterPythonImpl::GetSyntheticTypeName (PR #66724)

2023-09-18 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/66724 Instead of copying memory out of the PythonString (via a std::string) and then using that to create a ConstString, it would make more sense to just create the ConstString from the original StringRef in the

[Lldb-commits] [lldb] [lldb][NFCI] Remove unneeded ConstString from intel-pt plugin (PR #66721)

2023-09-18 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/66721 This is a follow-up to 14d95b26aee0ac0ac8a70252e8a3c7a986e0e812. I would have changed it in that commit, but I don't build the intel-pt plugin so I didn't see this until later. >From

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-14 Thread Alex Langford via lldb-commits
bulbazord wrote: > > ``` > >SBWatchpoint SBTarget::WatchpointCreateByAddress(addr_t address, size_t > > size, uint32_t access_flags, SBError ); > > ``` > > > > > > > > > > > > > > > > > > > > > > > > with `eWatchpointAccess{Read,Write,Modify}` flags

[Lldb-commits] [lldb] a5a2a5a - [lldb][NFCI] Remove use of ConstString in StructuredData

2023-09-14 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-09-14T10:53:39-07:00 New Revision: a5a2a5a3eca06998d9f71186db2ce78ae2716022 URL: https://github.com/llvm/llvm-project/commit/a5a2a5a3eca06998d9f71186db2ce78ae2716022 DIFF: https://github.com/llvm/llvm-project/commit/a5a2a5a3eca06998d9f71186db2ce78ae2716022.diff

[Lldb-commits] [lldb] 2f377c5 - [lldb][NFCI] Remove use of ConstString from UnixSignals

2023-09-14 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-09-14T10:19:53-07:00 New Revision: 2f377c5bd713e9ee72faa6a99088bb81358059e3 URL: https://github.com/llvm/llvm-project/commit/2f377c5bd713e9ee72faa6a99088bb81358059e3 DIFF: https://github.com/llvm/llvm-project/commit/2f377c5bd713e9ee72faa6a99088bb81358059e3.diff

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-14 Thread Alex Langford via lldb-commits
@@ -3109,14 +3109,15 @@ static GDBStoppointType GetGDBStoppointType(Watchpoint *wp) { assert(wp); bool watch_read = wp->WatchpointRead(); bool watch_write = wp->WatchpointWrite(); + bool watch_modify = wp->WatchpointModify(); - // watch_read and watch_write cannot

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-14 Thread Alex Langford via lldb-commits
@@ -211,6 +212,35 @@ bool Watchpoint::CaptureWatchedValue(const ExecutionContext _ctx) { return (m_new_value_sp && m_new_value_sp->GetError().Success()); } +bool Watchpoint::WatchedValueReportable(const ExecutionContext _ctx) { + if (!m_watch_modify) +return true; +

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread Alex Langford via lldb-commits
bulbazord wrote: > @bulbazord This would be a good place to put your plugin dependency / const > string guidance. Or tell me where it lives now and I'll link to it. Oh, yes! I'd be happy to take care of that after this goes in, thanks for pointing that out! :)

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread Alex Langford via lldb-commits
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. - - **Test infrastructure**: Like LLVM it is important to submit tests with your - patches, but note that

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread Alex Langford via lldb-commits
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. - - **Test infrastructure**: Like LLVM it is important to submit tests with your - patches, but note that

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread Alex Langford via lldb-commits
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. - - **Test infrastructure**: Like LLVM it is important to submit tests with your - patches, but note that

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread Alex Langford via lldb-commits
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. - - **Test infrastructure**: Like LLVM it is important to submit tests with your - patches, but note that

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Excellent write up, thanks for taking care of that! https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 5bff905 - [lldb][NFCI] Remove unused method TypeCategoryMap::Get(uint32_t, ValueSP &)

2023-09-05 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-09-05T10:53:56-07:00 New Revision: 5bff905c0de50ff87b73e6a1e93d0a5b0f38e1a9 URL: https://github.com/llvm/llvm-project/commit/5bff905c0de50ff87b73e6a1e93d0a5b0f38e1a9 DIFF: https://github.com/llvm/llvm-project/commit/5bff905c0de50ff87b73e6a1e93d0a5b0f38e1a9.diff

[Lldb-commits] [lldb] 764287f - [lldb] Add support for recognizing swift ast sections in object files

2023-08-31 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-31T15:16:12-07:00 New Revision: 764287f1ad69469cc264bb094e8fcdcfdd0fcdfb URL: https://github.com/llvm/llvm-project/commit/764287f1ad69469cc264bb094e8fcdcfdd0fcdfb DIFF: https://github.com/llvm/llvm-project/commit/764287f1ad69469cc264bb094e8fcdcfdd0fcdfb.diff

[Lldb-commits] [lldb] 14d95b2 - [lldb][NFCI] Remove unneeded ConstString conversions

2023-08-31 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-31T11:27:59-07:00 New Revision: 14d95b26aee0ac0ac8a70252e8a3c7a986e0e812 URL: https://github.com/llvm/llvm-project/commit/14d95b26aee0ac0ac8a70252e8a3c7a986e0e812 DIFF: https://github.com/llvm/llvm-project/commit/14d95b26aee0ac0ac8a70252e8a3c7a986e0e812.diff

[Lldb-commits] [lldb] 9ed72d4 - [lldb][NFCI] Replace bespoke iterator check with std::next

2023-08-31 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-31T10:55:00-07:00 New Revision: 9ed72d4d4d507b60a54f6b74e86433f837ded93c URL: https://github.com/llvm/llvm-project/commit/9ed72d4d4d507b60a54f6b74e86433f837ded93c DIFF: https://github.com/llvm/llvm-project/commit/9ed72d4d4d507b60a54f6b74e86433f837ded93c.diff

[Lldb-commits] [lldb] 5d49c9c - [lldb][NFCI] Remove StructuredData::Array::GetItemAtIndexAsString overloads with ConstString

2023-08-29 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-29T16:02:26-07:00 New Revision: 5d49c9ce65881467295fd5ef2022b60d6601e82f URL: https://github.com/llvm/llvm-project/commit/5d49c9ce65881467295fd5ef2022b60d6601e82f DIFF: https://github.com/llvm/llvm-project/commit/5d49c9ce65881467295fd5ef2022b60d6601e82f.diff

[Lldb-commits] [lldb] ebff12d - [lldb][NFCI] Change return type of UnixSignals::GetSignalInfo

2023-08-22 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-22T10:54:06-07:00 New Revision: ebff12d675aa4db4ee8762c165a387a8d86dd0d5 URL: https://github.com/llvm/llvm-project/commit/ebff12d675aa4db4ee8762c165a387a8d86dd0d5 DIFF: https://github.com/llvm/llvm-project/commit/ebff12d675aa4db4ee8762c165a387a8d86dd0d5.diff

[Lldb-commits] [lldb] a43e23a - [lldb][NFCI] Silence warning about unhandled value eManglingSchemeSwift in switch statement

2023-08-22 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-22T10:35:36-07:00 New Revision: a43e23a2141f4fa78940844d810648ff8d40f474 URL: https://github.com/llvm/llvm-project/commit/a43e23a2141f4fa78940844d810648ff8d40f474 DIFF: https://github.com/llvm/llvm-project/commit/a43e23a2141f4fa78940844d810648ff8d40f474.diff

[Lldb-commits] [lldb] edc64d4 - [lldb] Add support for recognizing swift mangled names

2023-08-22 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-22T10:28:55-07:00 New Revision: edc64d49de92d33e709bcde1db5670ff430f5fad URL: https://github.com/llvm/llvm-project/commit/edc64d49de92d33e709bcde1db5670ff430f5fad DIFF: https://github.com/llvm/llvm-project/commit/edc64d49de92d33e709bcde1db5670ff430f5fad.diff

[Lldb-commits] [lldb] 58fe7b7 - [lldb] Change UnixSignals::GetSignalAsCString to GetSignalAsStringRef

2023-08-21 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-21T12:44:17-07:00 New Revision: 58fe7b751dc4a611a013a7708c1c0cac159b5f1e URL: https://github.com/llvm/llvm-project/commit/58fe7b751dc4a611a013a7708c1c0cac159b5f1e DIFF: https://github.com/llvm/llvm-project/commit/58fe7b751dc4a611a013a7708c1c0cac159b5f1e.diff

[Lldb-commits] [lldb] 3415798 - [lldb][NFCI] Remove unneeded ConstString from ValueObject::GetValueForExpressionPath_Impl

2023-08-17 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-17T10:44:01-07:00 New Revision: 3415798f7993974a19bd22b0481f2f6a71e4a2ab URL: https://github.com/llvm/llvm-project/commit/3415798f7993974a19bd22b0481f2f6a71e4a2ab DIFF: https://github.com/llvm/llvm-project/commit/3415798f7993974a19bd22b0481f2f6a71e4a2ab.diff

[Lldb-commits] [lldb] 9e6d48e - [lldb][NFCI] Module constructor should take ConstString by value

2023-08-17 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-17T10:34:57-07:00 New Revision: 9e6d48ef6085b762d8eb2531bbb481f57446da1c URL: https://github.com/llvm/llvm-project/commit/9e6d48ef6085b762d8eb2531bbb481f57446da1c DIFF: https://github.com/llvm/llvm-project/commit/9e6d48ef6085b762d8eb2531bbb481f57446da1c.diff

[Lldb-commits] [lldb] 90c5675 - [lldb][NFCI] Rewrite error-handling code in ProcessGDBRemote::MonitorDebugserverProcess

2023-08-17 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-17T10:32:23-07:00 New Revision: 90c5675a3db2319dd449a1753c79568355dfaaed URL: https://github.com/llvm/llvm-project/commit/90c5675a3db2319dd449a1753c79568355dfaaed DIFF: https://github.com/llvm/llvm-project/commit/90c5675a3db2319dd449a1753c79568355dfaaed.diff

[Lldb-commits] [lldb] 2f382bf - [lldb][NFCI] Remove unused method overload of ValueObject::GetChildAtNamePath

2023-08-16 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-16T14:23:58-07:00 New Revision: 2f382bfb14e38429e69885406ae8cedc9bb3028e URL: https://github.com/llvm/llvm-project/commit/2f382bfb14e38429e69885406ae8cedc9bb3028e DIFF: https://github.com/llvm/llvm-project/commit/2f382bfb14e38429e69885406ae8cedc9bb3028e.diff

[Lldb-commits] [lldb] 5a25f97 - [lldb][NFCI] Change parameter type in Process::SetExitStatus

2023-08-14 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-14T15:49:03-07:00 New Revision: 5a25f97e69500d4f65ce0e56027787752c7aab61 URL: https://github.com/llvm/llvm-project/commit/5a25f97e69500d4f65ce0e56027787752c7aab61 DIFF: https://github.com/llvm/llvm-project/commit/5a25f97e69500d4f65ce0e56027787752c7aab61.diff

[Lldb-commits] [lldb] 69fdbdc - [lldb] Remove support for SBHostOS threading functionality

2023-08-14 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-14T14:33:08-07:00 New Revision: 69fdbdc4493aacf4d418a063930b39b02b5e18c5 URL: https://github.com/llvm/llvm-project/commit/69fdbdc4493aacf4d418a063930b39b02b5e18c5 DIFF: https://github.com/llvm/llvm-project/commit/69fdbdc4493aacf4d418a063930b39b02b5e18c5.diff

<    4   5   6   7   8   9   10   11   12   13   >