https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/96560
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/96560
Reverting to unblock macOS buildbots which are currently failing on these
tests. https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/6377/
>From 22127178761968b01be207a1c83c7048dc3ec47d
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
Hey Miro, looks like this change broke the LLDB MacOS buildbot:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/6353/
https://github.com/llvm/llvm-project/pull/95007
___
lldb-commits mailing list
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/96001
>From a59949cc908d5216950f2530fe1455da8ad39b5f Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 Jun 2024 16:02:07 -0700
Subject: [PATCH] add unit test for breakpoint::setcallback
---
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/96001
>From 44ea5e0d0a319fa12463129ff072bcaef6112544 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 Jun 2024 16:02:07 -0700
Subject: [PATCH] add unit test for breakpoint::setcallback
---
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/96001
>From 86dcffcc7a1820756fe8104d8239f25185a27733 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 Jun 2024 16:02:07 -0700
Subject: [PATCH] add unit test for breakpoint::setcallback
---
@@ -0,0 +1,93 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/96001
>From 2cfcef620125ed7d0ba84acfa20de3064437282c Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 Jun 2024 16:02:07 -0700
Subject: [PATCH] add unit test for breakpoint::setcallback
---
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/96001
>From aa575bbc2b91837851631cf7a14e03398e2efa48 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 Jun 2024 16:02:07 -0700
Subject: [PATCH] add unit test for breakpoint::setcallback
---
@@ -0,0 +1,89 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
@@ -0,0 +1,89 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
chelcassanova wrote:
Not anymore, I'll remove these.
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
chelcassanova wrote:
Closing this PR, we wanted to be able to do this _without_ using the
`PythonDataObjects` class in the swig wrapper that contains callback functions
but this looks to be unfeasible for callbacks that return SB objects
https://github.com/llvm/llvm-project/pull/95318
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/95318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/96001
>From 0dc804076d624883e966b58c94cae8dc5065f1e3 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 Jun 2024 16:02:07 -0700
Subject: [PATCH] add unit test for breakpoint::setcallback
---
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/96001
This commit adds a unit test for SBBreakpoint::SetCallback as it wasn't being
tested before.
>From dc51494a84d6b0dac1d4c6b106eeb6e625a09b58 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91404
>From 5724d6c77d29ad80e9ca03ce7ac1c3e6ed33afc0 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 11:08:29 -0700
Subject: [PATCH] [lldb][breakpoint] Grey out disabled breakpoints
This
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/95318
This commit refactors the typemaps and static functions used in the SWIG
typemaps and wrappers to be in their own SWIG files that are included in the
main `python.swig` file.
>From
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/95181
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/95181
…andOverrideCallback (#94518)"
This reverts commit 7cff05ada05e87408966d56b4c1675033187ff5c. The API test that
was added erroneously imports a module that isn't needed and wouldn't be found
which causes
Author: Chelsea Cassanova
Date: 2024-06-11T15:27:10-07:00
New Revision: 7cff05ada05e87408966d56b4c1675033187ff5c
URL:
https://github.com/llvm/llvm-project/commit/7cff05ada05e87408966d56b4c1675033187ff5c
DIFF:
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/94518
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/94518
>From 4e40f07e424458be6e44cc41d333f38763a0d0fb Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 5 Jun 2024 11:24:01 -0700
Subject: [PATCH] [lldb][api-test] Add API test for
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/94518
>From a7215585f55617a41f7c8e566088d3f50203fe55 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 5 Jun 2024 11:24:01 -0700
Subject: [PATCH] [lldb][api-test] Add API test for
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/94518
>From 44e8cab5d45a87eb1ea2076c498abe5be423eb1c Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 5 Jun 2024 11:24:01 -0700
Subject: [PATCH] [lldb][api-test] Add API test for
@@ -476,6 +475,32 @@ template <> bool SetNumberFromPyObject(double
, PyObject *obj) {
$1 = $1 || PyCallable_Check(reinterpret_cast($input));
}
+%typemap(in) (lldb::CommandOverrideCallback callback, void *baton) {
+ if (!($input == Py_None ||
+
@@ -476,6 +475,32 @@ template <> bool SetNumberFromPyObject(double
, PyObject *obj) {
$1 = $1 || PyCallable_Check(reinterpret_cast($input));
}
+%typemap(in) (lldb::CommandOverrideCallback callback, void *baton) {
+ if (!($input == Py_None ||
+
@@ -1099,6 +1099,19 @@ static void
LLDBSwigPythonCallPythonSBDebuggerTerminateCallback(lldb::user_id_t
}
}
+static bool
LLDBSwigPythonCallPythonSBCommandInterpreterSetCommandOverrideCallback(void
*baton, const char **argv) {
+ bool b = false;
+ if (baton != Py_None) {
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/94518
>From e4ba69ac4983e4e2882200e7efe0e850eeefae21 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 5 Jun 2024 11:24:01 -0700
Subject: [PATCH] [lldb][api-test] Add API test for
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/94518
`SBCommandInterpreter::CommandOverrideCallback` was not being exposed to the
Python API has no coverage in the
API test suite, so this commits exposes and adds a test for it. Doing this
involves also
chelcassanova wrote:
Cool, sorry for the delay but I made changes to `Stream` and `SBStream` to add
a `GetUseColor()` accessor and to change the bool it uses in initialization to
a `std::optional` and I'm gonna put them up in a separate PR.
https://github.com/llvm/llvm-project/pull/91404
chelcassanova wrote:
Hm, so in that case should we focus on adding an `SBStream::GetUseColor` so
that the stream's colour settings can take precedence here?
https://github.com/llvm/llvm-project/pull/91404
___
lldb-commits mailing list
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91404
>From 0e45adeac968aa435f58dfef026ef308e56b40a5 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 11:08:29 -0700
Subject: [PATCH] [lldb][breakpoint] Grey out disabled breakpoints
This
@@ -848,6 +850,13 @@ void Breakpoint::GetDescription(Stream *s,
lldb::DescriptionLevel level,
const size_t num_locations = GetNumLocations();
const size_t num_resolved_locations = GetNumResolvedLocations();
+ // Grey out any disabled breakpoints in the list of
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/91404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/91404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
I changed this PR to make disabled breakpoints greyed out (per Ismail's
suggestion). Since this is being done at the `Breakpoint` level we have access
to the target and its debugger to access `GetUseColor()`.
https://github.com/llvm/llvm-project/pull/91404
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91404
>From c334f7357aebefa3e0b7af645396e699cf3a4c8d Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 11:08:29 -0700
Subject: [PATCH] [lldb][breakpoint] Grey out disabled breakpoints
This
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/91618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91618
>From 167850e01960175e332b9da3d95d6054102a960a Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 09:23:02 -0700
Subject: [PATCH] [lldb][enums] Remove broadcast bits from debugger
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/91618
Removes the debugger broadcast bits from `Debugger.h` and instead uses the enum
from `lldb-enumerations.h`. Also adds the `eBroadcastSymbolChange` bit to the
enum in `lldb-enumerations.h`.
>From
@@ -534,7 +534,8 @@ void BreakpointOptions::GetDescription(Stream *s,
if (m_ignore_count > 0)
s->Printf("ignore: %d ", m_ignore_count);
-s->Printf("%sabled ", m_enabled ? "en" : "dis");
+s->PutCStringColorHighlighted(m_enabled ? "enabled " : "disabled ",
+
@@ -1240,7 +1241,13 @@ TypeSP
SymbolFileDWARFDebugMap::FindCompleteObjCDefinitionTypeForDIE(
void SymbolFileDWARFDebugMap::FindTypes(const TypeQuery ,
TypeResults ) {
std::lock_guard guard(GetModuleMutex());
+ Progress progress(
+
@@ -534,7 +534,8 @@ void BreakpointOptions::GetDescription(Stream *s,
if (m_ignore_count > 0)
s->Printf("ignore: %d ", m_ignore_count);
-s->Printf("%sabled ", m_enabled ? "en" : "dis");
+s->PutCStringColorHighlighted(m_enabled ? "enabled " : "disabled ",
+
@@ -534,7 +534,8 @@ void BreakpointOptions::GetDescription(Stream *s,
if (m_ignore_count > 0)
s->Printf("ignore: %d ", m_ignore_count);
-s->Printf("%sabled ", m_enabled ? "en" : "dis");
+s->PutCStringColorHighlighted(m_enabled ? "enabled " : "disabled ",
+
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/91404
This commit adds colour highlighting to the `disabled` keyword in the
breakpoint list so that it appears red (and should be easier to see in a large
sea of breakpoints).
>From
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/90261
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/90261
>From 697ab926dd1139810ec7d126258f6386552cdf96 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Fri, 26 Apr 2024 12:52:19 -0700
Subject: [PATCH] [lldb][sbapi] Fix API break in SBDebugger broadcast
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/90261
https://github.com/llvm/llvm-project/pull/87409 removed the broadcast bits from
SBDebugger and placed them in `lldb-enumerations.h`. This is API-breaking so
this commits places the enum back into
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/89979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/89979
This adds the option to use the `breakpoint()` keyword as a way to debug the
API tests.
>From f1a0a1bc059e133d2e00157ce58b2cbda4904fab Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 24 Apr
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/88824
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/88824
>From 7b95abd2247ca3e34985ce2c7e93c3dbe3a609c5 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 15 Apr 2024 15:29:06 -0700
Subject: [PATCH] [lldb][lit] Guard MallocNanoZone envvar in shell tests
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/88824
Previously the MallocNanoZone envvar would be set to 0 on Darwin for the LLDB
shell tests, but this should guarded behind ASan being enabled as opposed to
simply running the test suite behind Darwin. This
https://github.com/chelcassanova approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/88535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/88442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/88468
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/88468
Reverts llvm/llvm-project#88047. TestFrames.py is failing on x86_64
GreenDragon:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/983/
>From 069d90a500ed02067f3f1a5d01c7827623353b85 Mon
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/88442
…(#88436)"
This reverts commit 1f5d130df85c2d0550dc8687ad0fa1d96856c318. The original
commit checks that the host system is "Darwin" before setting the
`MallocNanoZone` envvar, but on the Shell lit
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/88436
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/88436
Reverts llvm/llvm-project#88431. A config variable for the host OS is
unrecognized on the Linux builds and is causing a build failure.
>From 79a4eb5047d8c90568b04ad5fb90e6421e1aba69 Mon Sep 17 00:00:00
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/88431
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
If that's the case then I'll just merge this in.
https://github.com/llvm/llvm-project/pull/88431
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/88431
When builds on Darwin are configured with ASan, running tests will emit a
warning about malloc's nano zone that can interfere with the test output and
cause failures. Setting the environment variable
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/88331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/88331
…db-enumerations.h" (#88324)"
This reverts commit 9f6d08f2566a26144ea1753f80aebb1f2ecfdc63. This broke the
build because of a usage of one of the original SBDebugger broadcast bits that
wasn't updated in
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/88324
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/88324
Reverts llvm/llvm-project#87409 due a missed update to the broadcast bit
causing a build failure on the x86_64 Debian buildbot.
>From 27a49dc1d37f3e7ffa855ed7a536a796fa2e1642 Mon Sep 17 00:00:00 2001
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/87409
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/87409
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/87409
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/87409
>From 7561d03d775822f789a61a5b827dfa04b29b57b2 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 2 Apr 2024 13:22:15 -0700
Subject: [PATCH 1/3] [lldb][sbdebugger] Match progress category enum bit
@@ -1339,6 +1339,14 @@ enum AddressMaskRange {
eAddressMaskRangeAll = eAddressMaskRangeAny,
};
+/// Used by the debugger to indicate which events are being broadcasted.
+enum DebuggerBroadcastBit {
+ eBroadcastBitProgress = (1 << 0),
+ eBroadcastBitWarning = (1 << 1),
+
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/87409
>From 7561d03d775822f789a61a5b827dfa04b29b57b2 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 2 Apr 2024 13:22:15 -0700
Subject: [PATCH 1/3] [lldb][sbdebugger] Match progress category enum bit
@@ -42,11 +42,13 @@ class LLDB_API SBInputReader {
class LLDB_API SBDebugger {
public:
+ // The enum values here need to match their corresponding values in
+ // Debugger.h.
FLAGS_ANONYMOUS_ENUM(){
eBroadcastBitProgress = (1 << 0),
eBroadcastBitWarning = (1
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/87409
>From 7561d03d775822f789a61a5b827dfa04b29b57b2 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 2 Apr 2024 13:22:15 -0700
Subject: [PATCH 1/2] [lldb][sbdebugger] Match progress category enum bit
https://github.com/chelcassanova approved this pull request.
https://github.com/llvm/llvm-project/pull/86593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/86002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/86002
The Doxygen comments for the `details` field of a progress report currently
does not specify that this field will act as the initial set of details for a
progress report that gets updated with
https://github.com/chelcassanova approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/85342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova approved this pull request.
https://github.com/llvm/llvm-project/pull/84854
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,164 @@
+//===-- AlarmTest.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,164 @@
+//===-- AlarmTest.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -210,3 +211,37 @@ TEST_F(ProgressReportTest, TestOverlappingEvents) {
// initial report.
EXPECT_EQ(data->GetID(), expected_progress_id);
}
+
+TEST_F(ProgressReportTest, TestProgressManagerDisjointReports) {
+ ListenerSP listener_sp =
+
@@ -0,0 +1,88 @@
+//===-- Alarm.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/chelcassanova approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/84278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/84281
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/83069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/83502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/83502
The `details` field in the constructor for `Progress` is missing Doxygen
documentation, this commit adds this.
>From 7b26213416e45853514e98d5043255ccd42153a9 Mon Sep 17 00:00:00 2001
From: Chelsea
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From 5fcab5d9b7af70861bbc46f096032dce7de41517 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From 59e3b1da1335261badeace24d6136d924cda6949 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From f38204941062691bf3e3f6e57d8171a5c0258f77 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From 40caaa80180d4845393fc4b80ee2dc09b7c87a7e Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From 03268312834c61a16c4bc28efc442fcd027ec0a9 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and
@@ -82,20 +94,37 @@ ProgressManager ::Instance() {
return *g_progress_manager;
}
-void ProgressManager::Increment(std::string title) {
+void ProgressManager::Increment(Progress::ProgressData progress_data) {
chelcassanova wrote:
Yeah, the title is used for
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From 63dded34a47dd161fa918e45aaeecf966ba08476 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and
@@ -29,8 +30,12 @@ Progress::Progress(std::string title, std::string details,
if (debugger)
m_debugger_id = debugger->GetID();
+
+ m_progress_data = {m_title, m_details, m_id,
+ m_completed, m_total, m_debugger_id};
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From 2cef4a29f0105847fa11b7f6a6ee063184fb838a Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and
1 - 100 of 265 matches
Mail list logo
