[FFmpeg-cvslog] avformat/mov: Fix integer overflow in mov_read_packet().

ffmpeg | branch: release/5.1 | Dale Curtis | Wed Nov 22 22:17:37 2023 +| [8f209d2c90e84cd250f1a4667d1d83ec196f51dc] | committer: Michael Niedermayer avformat/mov: Fix integer overflow in mov_read_packet(). Fixes https://crbug.com/1499669: runtime error: signed integer overflow

[FFmpeg-cvslog] avformat/mov: Fix integer overflow in mov_read_packet().

ffmpeg | branch: release/6.0 | Dale Curtis | Wed Nov 22 22:17:37 2023 +| [90571795e208a7061eb358e7f0f073c17a7ecbcc] | committer: Michael Niedermayer avformat/mov: Fix integer overflow in mov_read_packet(). Fixes https://crbug.com/1499669: runtime error: signed integer overflow

[FFmpeg-cvslog] Don't throw an error when attached picture isn't recognized.

ffmpeg | branch: master | Dale Curtis | Mon Apr 10 10:52:08 2023 -0700| [bba6df9ac7bd8386d92e1a7f5c737ca4e575fccf] | committer: Michael Niedermayer Don't throw an error when attached picture isn't recognized. The MIME type field is required per the FLAC standard, but it's not an error just

Re: [FFmpeg-devel] [PATCH] libavformat/flac_picture: Don't return AVERROR_INVALIDDATA for errors with flac picture mimetype

Bump on this patch -- it still applies cleanly. We're still seeing files in the wild like this. - dale On Mon, Apr 10, 2023 at 10:54 AM Dale Curtis wrote: > Will left Google, but I've updated the patch to only skip errors when the > type is unrecognized. > > On Wed, Sep 28, 202

[FFmpeg-cvslog] Avoid OOM for invalid STCO / CO64 constructions.

ffmpeg | branch: master | Dale Curtis | Fri Feb 2 20:49:44 2024 +| [6ef32ea5748e9dcc2c8d1c076607b8d15650a5fe] | committer: Michael Niedermayer Avoid OOM for invalid STCO / CO64 constructions. The `entries` value is read directly from the stream and used to allocate memory. This change

Re: [FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

On Thu, Feb 15, 2024 at 2:35 PM Michael Niedermayer wrote: > FFMIN/MAX can evaluate their arguments multiple times so avio_rb32() might > be executed more than once > Thanks. Good catch. Fixed. stco-clamp-entries-v4.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

, but I've added a FFMAX(0,) there too. - dale From db3e9ffc364cc94cb3a72696d4d4858af6abcc42 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Fri, 2 Feb 2024 20:49:44 + Subject: [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions. The `entries` value is read directly from the str

Re: [FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

On Fri, Feb 2, 2024 at 3:42 PM Dale Curtis wrote: > On Fri, Feb 2, 2024 at 3:20 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Dale Curtis: >> > +// Clamp allocation size for `chunk_offsets` -- don't throw an >> error for an >

Re: [FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

On Fri, Feb 2, 2024 at 3:20 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Dale Curtis: > > +// Clamp allocation size for `chunk_offsets` -- don't throw an > error for an > > +// invalid count since the EOF path doesn't throw either. > > +

[FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

The `entries` value is read directly from the stream and used to allocate memory. This change clamps `entries` to however many are possible in the remaining atom or file size (whichever is smallest). Fixes https://crbug.com/1429357 Signed-off-by: Dale Curtis --- libavformat/mov.c | 7

[FFmpeg-cvslog] avformat/mov: Fix integer overflow in mov_read_packet().

ffmpeg | branch: release/6.1 | Dale Curtis | Wed Nov 22 22:17:37 2023 +| [ca5ebfb066b1298c6b1f84b03185fb8463bc7884] | committer: Michael Niedermayer avformat/mov: Fix integer overflow in mov_read_packet(). Fixes https://crbug.com/1499669: runtime error: signed integer overflow

[FFmpeg-cvslog] avformat/mov: Fix integer overflow in mov_read_packet().

ffmpeg | branch: release/4.4 | Dale Curtis | Wed Nov 22 22:17:37 2023 +| [207e003758d80ffa595e21543007021659c0e535] | committer: Michael Niedermayer avformat/mov: Fix integer overflow in mov_read_packet(). Fixes https://crbug.com/1499669: runtime error: signed integer overflow

Re: [FFmpeg-devel] [PATCH] avformat/mov: Ignore duplicate ftyp

Thanks! lgtm, defer to you on FF_COMPLIANCE_STRICT. On Fri, Dec 1, 2023 at 3:59 PM wrote: > > > On 2 Dec 2023, at 0:26, Michael Niedermayer wrote: > > > Fixes: switch_1080p_720p.mp4 > > Found-by: Dale Curtis > > Signed-off-by: Michael Niedermayer >

[FFmpeg-cvslog] avformat/mov: Fix integer overflow in mov_read_packet().

ffmpeg | branch: master | Dale Curtis | Wed Nov 22 22:17:37 2023 +| [2182173a6933c02b0853751034bd5e0bf829b5f7] | committer: Michael Niedermayer avformat/mov: Fix integer overflow in mov_read_packet(). Fixes https://crbug.com/1499669: runtime error: signed integer overflow

Re: [FFmpeg-devel] [PATCH] Fix integer overflow in mov_read_packet().

On Fri, Nov 24, 2023 at 3:38 PM Michael Niedermayer wrote: > On Wed, Nov 22, 2023 at 02:20:59PM -0800, Dale Curtis wrote: > > Fixes https://crbug.com/1499669: > > > runtime error: signed integer overflow: 9223372036853334272 + 1375731456 > > this looks a bit close t

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Disallow FTYP after streams

FWIW, this ends up breaking files which are basically just concatenated fragmented mp4 files -- which is pretty sketchy, but we had some test content doing that: https://storage.googleapis.com/chromiumos-test-assets-public/Shaka-Dash/switch_1080p_720p.mp4 Is that intentional? Or should an

[FFmpeg-devel] [PATCH] Fix integer overflow in mov_read_packet().

Fixes https://crbug.com/1499669: runtime error: signed integer overflow: 9223372036853334272 + 1375731456 cannot be represented in type 'int64_t' (aka 'long') Signed-off-by: Dale Curtis --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b

Re: [blink-dev] Intent to Ship: MediaCapabilities: Query HDR support with decodingInfo()

with Safari already > shipping. LGTM1 > > On Wed, Oct 18, 2023 at 7:18 PM Dale Curtis > wrote: > >> Contact emails v...@microsoft.com, gw...@microsoft.com, >> gur...@microsoft.com, dalecur...@chromium.org >> >> Explainer >> https://github.com/w3c/medi

[blink-dev] Re: Intent to Ship: MediaCapabilities: Query HDR support with decodingInfo()

On Wed, Oct 25, 2023 at 8:30 AM Yoav Weiss wrote: > > > On Thursday, October 19, 2023 at 1:18:44 AM UTC+2 blink-dev wrote: > > Contact emailsv...@microsoft.com, gw...@microsoft.com, gurvir@ > microsoft.com, dalecur...@chromium.org > > Explainerhttps://github.com/w3c/media-capabilities/blob/main/

Re: [blink-dev] Re: Intent to Ship: Deprecate and remove Theora support.

involved who got us here. > > On Wed, Oct 25, 2023 at 10:37 AM Yoav Weiss > wrote: > >> LGTM2 >> >> On Tue, Oct 24, 2023 at 7:05 PM Dale Curtis >> wrote: >> >>> WMF has long switched away from Theora (to VP9) per prior discussions >>> w

[blink-dev] Re: Intent to Ship: Deprecate and remove Theora support.

options. - dale On Mon, Oct 23, 2023 at 8:41 PM Yuhong Bao wrote: > > I am asking the WMF to add MP4: > https://phabricator.wikimedia.org/T329258 > On Monday, October 23, 2023 at 8:53:14 AM UTC-7 Dale Curtis wrote: > >> Contact emailsdalec...@chromium.or

Re: [blink-dev] Re: Intent to Ship: Deprecate and remove Theora support.

On Tue, Oct 24, 2023 at 4:49 AM Mike Taylor wrote: > On 10/23/23 1:13 PM, Dale Curtis wrote: > > On Mon, Oct 23, 2023 at 10:02 AM Mike Taylor > wrote: > >> On 10/23/23 11:54 AM, Dale Curtis wrote: >> >> Hmm, not sure why the description got reflowed

Re: [blink-dev] Re: Intent to Ship: Deprecate and remove Theora support.

On Mon, Oct 23, 2023 at 10:02 AM Mike Taylor wrote: > On 10/23/23 11:54 AM, Dale Curtis wrote: > > Hmm, not sure why the description got reflowed, here's the formatted > version: > > Chrome will deprecate and remove support for the Theora video codec in > desktop Chrome due

[blink-dev] Re: Intent to Ship: Deprecate and remove Theora support.

On Mon, Oct 23, 2023 at 8:54 AM Dale Curtis wrote: > Hmm, not sure why the description got reflowed, here's the formatted > version: > > Chrome will deprecate and remove support for the Theora video codec in > desktop Chrome due to emerging security risks. Theora's low (and now of

[blink-dev] Re: Intent to Ship: Deprecate and remove Theora support.

%. - ~Feb 2024: remove code and chrome://flag in M123. - ~Mar 2024: Chrome 123 will roll to stable. - dale On Mon, Oct 23, 2023 at 8:52 AM Dale Curtis wrote: > Contact emailsdalecur...@chromium.org > > ExplainerNone > > Specificationhttps://en.wikipedia.org/wiki/Theora > &g

[blink-dev] Intent to Ship: Deprecate and remove Theora support.

Contact emailsdalecur...@chromium.org ExplainerNone Specificationhttps://en.wikipedia.org/wiki/Theora Summary Chrome will deprecate and remove support for the Theora video codec in desktop Chrome due to emerging security risks. Theora's low (and now often incorrect) usage no longer justifies

[blink-dev] Intent to Ship: MediaCapabilities: Query HDR support with decodingInfo()

Contact emailsv...@microsoft.com, gw...@microsoft.com, gur...@microsoft.com , dalecur...@chromium.org Explainer https://github.com/w3c/media-capabilities/blob/main/explainer.md#decode-capabilities Specificationhttps://www.w3.org/TR/media-capabilities/#hdrmetadatatype Summary Extends the Media

Re: [blink-dev] Intent to implement and ship: Media query support for video elements

Thanks! On Thu, Oct 5, 2023 at 12:53 PM Yoav Weiss wrote: > LGTM1 > > Thanks for correcting this historical mistake! > > On Thu, Oct 5, 2023, 21:11 Dale Curtis wrote: > >> Contact emailsdalecur...@chromium.org >> >> ExplainerNone >> > > We coul

[blink-dev] Intent to implement and ship: Media query support for video elements

Contact emailsdalecur...@chromium.org ExplainerNone Specification https://html.spec.whatwg.org/multipage/media.html#loading-the-media-resource Design docs https://developer.mozilla.org/en-US/docs/Web/HTML/Element/source#media Summary Adds support for CSS media queries to elements used with

Re: [blink-dev] Re: Intent to Prototype And Ship: Allow transferring ArrayBuffer into VideoFrame, AudioData, EncodedVideoChunk, EncodedAudioChunk, ImageDecoder constructors

ia blink-dev < > blink-dev@chromium.org> wrote: > >  > TAG review: https://github.com/w3ctag/design-reviews/issues/889 > > On Wed, Aug 30, 2023 at 9:50 AM Dale Curtis > wrote: > >> Alex, I assume you mean TAG's views on consistency regarding transfer >>

Re: [blink-dev] Intent to Implement and Ship: SVGImageElement.crossOrigin attribute.

;> >> /Daniel >> On 2023-08-30 16:24, Yoav Weiss wrote: >> >> LGTM1 to ship, with a base flag to ensure we can rollback if needed. >> >> On Mon, Aug 28, 2023 at 6:16 PM Dale Curtis >> wrote: >> >>> On Mon, Aug 21, 2023 at 9:41 AM Dal

Re: [blink-dev] Re: Intent to Prototype And Ship: Allow transferring ArrayBuffer into VideoFrame, AudioData, EncodedVideoChunk, EncodedAudioChunk, ImageDecoder constructors

Alex, I assume you mean TAG's views on consistency regarding transfer ergonomics? Otherwise https://www.w3.org/TR/design-principles/#consistency is what we followed here. We have not asked, given that we felt this was a small performance improvement, with pre-existing ergonomics, and already has

Re: [blink-dev] Intent to Implement and Ship: SVGImageElement.crossOrigin attribute.

On Mon, Aug 21, 2023 at 9:41 AM Dale Curtis wrote: > On Sun, Aug 20, 2023 at 7:36 PM Yoav Weiss wrote: > >> Thanks for working on this!! Eliminating resources which can't be loaded >> as CORS enabled resources is super useful! >> >> On Fri, Aug 18, 2023 at

Re: [blink-dev] Intent to Implement and Ship: SVGImageElement.crossOrigin attribute.

On Mon, Aug 21, 2023 at 1:24 AM Fredrik Söderquist wrote: > On Mon, Aug 21, 2023 at 4:36 AM Yoav Weiss wrote: > >> Thanks for working on this!! Eliminating resources which can't be loaded >> as CORS enabled resources is super useful! >> >> On Fri, Aug 18, 2023 at

Re: [blink-dev] Intent to Implement and Ship: SVGImageElement.crossOrigin attribute.

On Sun, Aug 20, 2023 at 7:36 PM Yoav Weiss wrote: > Thanks for working on this!! Eliminating resources which can't be loaded > as CORS enabled resources is super useful! > > On Fri, Aug 18, 2023 at 11:28 PM Dale Curtis > wrote: > >> Contact emailsdalecur...@chromium

Re: [blink-dev] Intent to Prototype: Zstd Content-Encoding

On Wed, Jun 21, 2023 at 3:18 AM Adam Rice wrote: > Drive by question: Given that the codec is going to be in the browser, are >> there plans to surface this up to CompressionStreams? (same question >> applies for Brotli, I suppose) > > > For the zstd Content-Encoding, we will only be linking in

Re: [blink-dev] Re: Intent to Implement and Ship: WebCodecs dequeue event

Yes, it shipped in M106 per chrome status. The MDN documentation is here: https://developer.mozilla.org/en-US/docs/Web/API/AudioDecoder/dequeue_event https://developer.mozilla.org/en-US/docs/Web/API/VideoDecoder/dequeue_event

Re: [blink-dev] Intent to deprecate and remove ImageDecoderInit.premultiplyAlpha.

> wrote: > >> LGTM2 >> >> On 9/21/22 7:44 AM, Yoav Weiss wrote: >> >> LGTM1 >> >> It seems unlikely that even the (few) developers who access this data are >> somehow relying on it. >> >> On Tue, Sep 20, 2022 at 8:10 PM Dale Cur

Re: [blink-dev] Intent to deprecate and remove ImageDecoderInit.premultiplyAlpha.

On Tue, Sep 20, 2022 at 3:36 AM Yoav Weiss wrote: > > > On Fri, Sep 16, 2022 at 11:19 PM Dale Curtis > wrote: > >> Contact emailsdalecur...@chromium.org >> >> ExplainerNone >> >> Specificationhttps://github.com/w3c/webcodecs/issues/508 >>

[blink-dev] Intent to deprecate and remove ImageDecoderInit.premultiplyAlpha.

Contact emailsdalecur...@chromium.org ExplainerNone Specificationhttps://github.com/w3c/webcodecs/issues/508 Summary premultiplyAlpha tells ImageDecoder to multiply the alpha channel into the RGB channels of decoded images. It was added to mirror the capabilities of ImageBitmapOptions, but in

Device change handling for AirPods in Big Sur?

Hi, we have some users reporting that the AirPods Pro automatic switching does not work in any applications but Safari or QuickTime player. Is there any documentation for how to listen for the necessary device

Re: [FFmpeg-devel] Question about HEIF/HEIC support

http://ffmpeg.org/pipermail/ffmpeg-devel/2019-November/252827.html was the last discussion on this. At the time I found it broke some mp4 files. - dale On Sat, Sep 26, 2020 at 4:37 AM Tom Needham <06needh...@gmail.com> wrote: > Hello > > I have spent some time researching the possibility of

[FFmpeg-cvslog] avformat/mov: See if mfra makes up the difference for an incomplete sidx.

ffmpeg | branch: master | Dale Curtis | Thu Aug 13 15:02:02 2020 -0700| [2ff3c466eca66bb8eb32bb41a4ce70fe285e3ea0] | committer: Derek Buitenhuis avformat/mov: See if mfra makes up the difference for an incomplete sidx. A few popular sites have started generating MP4 files which have a sidx

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

Bump to get this applied. Thanks! - dale On Wed, Aug 19, 2020 at 6:13 AM Michael Niedermayer wrote: > On Tue, Aug 18, 2020 at 02:04:04PM +0100, Derek Buitenhuis wrote: > > On 18/08/2020 04:57, Dale Curtis wrote: > > > Can't be an else statement since the prior clause mo

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

On Mon, Aug 17, 2020 at 12:12 PM Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > Patch lacks the context for stream_size here - will it always be > correct? Only asking since the check for the coede below this will > have changed from avio_size(pb) to stream_size. > stream_size ==

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

Bump. Thanks for consideration! - dale On Thu, Aug 13, 2020 at 3:03 PM Dale Curtis wrote: > A few popular sites have started generating MP4 files which have a > sidx plus an mfra. The sidx accounts for all size except the mfra, > so the old code did not mark the fragment index as

[FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

the index as complete. Fixes: https://crbug.com/1107130 Signed-off-by: Dale Curtis sidx_fix_v0.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

[FFmpeg-cvslog] avformat/mov: Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

ffmpeg | branch: release/4.2 | Dale Curtis | Thu May 14 14:38:07 2020 -0700| [361416218a2d3b4d83209b4ca5e36419cfd5eeb0] | committer: Michael Niedermayer avformat/mov: Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample(). Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer

[FFmpeg-cvslog] avformat/mov: Don't allow negative sample sizes.

ffmpeg | branch: release/2.8 | Dale Curtis | Thu May 14 15:31:55 2020 -0700| [832ae51f9b4ce1003c2e817900b0332d1df457f7] | committer: Michael Niedermayer avformat/mov: Don't allow negative sample sizes. Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer (cherry picked from commit

[FFmpeg-cvslog] avformat/mov: Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

ffmpeg | branch: release/4.3 | Dale Curtis | Thu May 14 14:38:07 2020 -0700| [8dee726b1a5c82c5e6578a606b299c6fdc74c142] | committer: Michael Niedermayer avformat/mov: Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample(). Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer

[FFmpeg-cvslog] avformat/mov: Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

ffmpeg | branch: master | Dale Curtis | Thu May 14 14:38:07 2020 -0700| [bf446711bc8b7f316771870b8d4dc4dd65f5d94b] | committer: Michael Niedermayer avformat/mov: Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample(). Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer > h

Re: [FFmpeg-devel] [PATCH 3/5] [mov] Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

Bump again. Thanks. - dale On Fri, Jun 5, 2020 at 11:48 AM Dale Curtis wrote: > Bump for this one again. Thanks in advance. > > - dale > > On Thu, May 28, 2020 at 12:37 PM Dale Curtis > wrote: > >> Bump now that the saturated math operations have landed. Thanks

[FFmpeg-cvslog] avutil/mathematics: Fix overflow with NaN in av_add_stable()

ffmpeg | branch: master | Dale Curtis | Thu May 14 14:47:49 2020 -0700| [d9aa1ef2c2dfbadcfe3783cee97e9c59dbfe7fb1] | committer: Michael Niedermayer avutil/mathematics: Fix overflow with NaN in av_add_stable() Signed-off-by: Michael Niedermayer > http://git.videolan.org/gitweb.cgi/ffmpeg.

[FFmpeg-cvslog] avformat: Fix overflow in compute_pkt_fields().

ffmpeg | branch: master | Dale Curtis | Thu May 14 14:47:49 2020 -0700| [63ce7c71bc1b1b6c141df5daae0f8fed52194b72] | committer: Michael Niedermayer avformat: Fix overflow in compute_pkt_fields(). Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer > http://git.videolan.

Re: [FFmpeg-devel] [PATCH 3/5] [mov] Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

Bump for this one again. Thanks in advance. - dale On Thu, May 28, 2020 at 12:37 PM Dale Curtis wrote: > Bump now that the saturated math operations have landed. Thanks! > > - dale > > On Thu, May 14, 2020 at 3:31 PM Dale Curtis > wrote: > >> &g

Re: [FFmpeg-devel] [PATCH 4/5] [utils, mathematics] Fix overflow in compute_pkt_fields().

Bump for this one again. Thanks in advance. - dale On Thu, May 28, 2020 at 12:37 PM Dale Curtis wrote: > Bump now that the saturated math operations have landed. Thanks! > > - dale > > On Thu, May 14, 2020 at 3:31 PM Dale Curtis > wrote: > >> Fixes one issue in

[FFmpeg-cvslog] avformat/oggparsetheora: Don't update start time when lastpts is AV_NOPTS_VALUE.

ffmpeg | branch: master | Dale Curtis | Fri May 15 12:37:02 2020 -0700| [57564a2cfc9c424d137e8279955ac9e892c8d794] | committer: Michael Niedermayer avformat/oggparsetheora: Don't update start time when lastpts is AV_NOPTS_VALUE. Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] Don't adjust start time for MP3 files; packets are not adjusted.

On Thu, May 28, 2020 at 1:33 PM Michael Niedermayer wrote: > I dont really have an oppinion about start_time, its more the change in > timestamps & duratiion on the output side which is whats user vissible > and that looked worse for the testcase > The difference is due to the decode stage

[FFmpeg-devel] [PATCH] Don't update start time when lastpts is AV_NOPTS_VALUE.

Signed-off-by: Dale Curtis --- libavformat/oggparsetheora.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) no_start_time_update_v0.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman

[FFmpeg-cvslog] Use av_sat_sub64() when updating pts by duration.

ffmpeg | branch: master | Dale Curtis | Thu May 14 14:33:55 2020 -0700| [fc54db32652bc830fba002da19c2ba9ba4508ca5] | committer: Michael Niedermayer Use av_sat_sub64() when updating pts by duration. Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer > http://git.videolan.

[FFmpeg-cvslog] avformat/utils: Use av_sat_add64() when updating start_time by skip_samples.

ffmpeg | branch: master | Dale Curtis | Thu May 14 14:29:15 2020 -0700| [f3068be15b361698429ac205ebc728398b4a3cbb] | committer: Michael Niedermayer avformat/utils: Use av_sat_add64() when updating start_time by skip_samples. Avoids overflow from fuzzed skip_samples values. Signed-off

Re: [FFmpeg-devel] [PATCH 1/5] Use av_sat_add64() when updating start_time by skip_samples.

Bump now that the saturated math operations have landed. Thanks! - dale On Thu, May 14, 2020 at 3:31 PM Dale Curtis wrote: > Avoids overflow from fuzzed skip_samples values. > > Signed-off-by: Dale Curtis > --- > libavformat/utils.c | 4 ++-- > 1 file changed, 2 insertio

Re: [FFmpeg-devel] [PATCH 2/5] [oggparsetheora] Use av_sat_sub64() when updating pts by duration.

Bump now that the saturated math operations have landed. Thanks! - dale On Thu, May 14, 2020 at 3:31 PM Dale Curtis wrote: > Signed-off-by: Dale Curtis > --- > libavformat/oggparsetheora.c | 2 +- > 1 file changed, 1 insertion(+)

Re: [FFmpeg-devel] [PATCH 4/5] [utils, mathematics] Fix overflow in compute_pkt_fields().

Bump now that the saturated math operations have landed. Thanks! - dale On Thu, May 14, 2020 at 3:31 PM Dale Curtis wrote: > Fixes one issue in the function itself and one in the dependent > function av_add_stable() which wasn't checking for NaN. > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 3/5] [mov] Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

Bump now that the saturated math operations have landed. Thanks! - dale On Thu, May 14, 2020 at 3:31 PM Dale Curtis wrote: > > Signed-off-by: Dale Curtis > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion

[FFmpeg-cvslog] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

ffmpeg | branch: master | Dale Curtis | Fri May 1 10:20:43 2020 -0700| [fda1c74539d7b0680f34ca765c2c0055d8f2bb3e] | committer: Michael Niedermayer Use gcc/clang builtins for av_sat_(add|sub)_64_c if available. Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer > h

Re: [FFmpeg-devel] [PATCH] Don't adjust start time for MP3 files; packets are not adjusted.

On Wed, May 27, 2020 at 8:29 AM Michael Niedermayer wrote: > what id like to point out here is that the audio stream no > longer starts at the same time as the video > also the duration from adding the durations before is > exact but not afterwards > I'm not sure about the duration issue, I'd

Re: [FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

On Wed, May 27, 2020 at 11:10 AM Michael Niedermayer wrote: > so the builtin does better and both locally do better than clang on the web > tool > Ah, sorry I forgot godbolt is compiling without any options, if you type -O9 in the compiler options fields you get: clang:

[FFmpeg-cvslog] lavf/mp3dec: don't adjust start time; packets are not adjusted.

ffmpeg | branch: master | Dale Curtis | Thu Apr 23 16:18:18 2020 -0700| [460132c9980f8a1f501a1f69477bca49e1641233] | committer: Anton Khirnov lavf/mp3dec: don't adjust start time; packets are not adjusted. 7546ac2fee4 made it so that the start_time for mp3 files is adjusted for skip_samples

Re: [FFmpeg-devel] [PATCH] Don't adjust start time for MP3 files; packets are not adjusted.

On Wed, May 20, 2020 at 5:22 AM Anton Khirnov wrote: > > Looks reasonable, will push. > Thanks! I don't see this in the commit log. Did it end up getting pushed? - dale ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

On Fri, May 22, 2020 at 1:34 PM Michael Niedermayer wrote: > > does this produce faster / better code ? > that is do compilers actually fail to optimize this from plain > clean C code ? > Here's the difference: clang trunk: https://godbolt.org/z/6SHmEo gcc trunk: https://godbolt.org/z/iKb9jZ I

Re: [FFmpeg-devel] [PATCH] [libavformat] Avoid integer overflow on start_time with skip_samples.

This patch can be abandoned in favor of the other one which uses av_sat_add64(). - dale On Thu, Apr 30, 2020 at 3:20 PM Dale Curtis wrote: > I've sent a follow up patch set implementing saturating operations if > that's something folks are interested in. > > - dale > > On

Re: [FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

On Thu, May 21, 2020 at 12:37 AM Michael Niedermayer wrote: > gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 > used with ccache on a x86-64 > Huh, I guess there's no early abort for conditionals in a preprocessor statement with __has_builtin for some reason. I've added a AV_HAS_BUILTIN macro to

Re: [FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

On Wed, May 20, 2020 at 1:17 AM Michael Niedermayer wrote: > > In file included from ./libavutil/avutil.h:296:0, > from ./libavutil/log.h:25, > from ./libavutil/thread.h:34, > from libavdevice/alldevices.c:22: > ./libavutil/common.h: In function

[FFmpeg-cvslog] avformat/mov: Free temp buffer upon negative sample_size error.

ffmpeg | branch: release/4.2 | Dale Curtis | Mon May 18 15:35:35 2020 -0700| [7c01f2770131f3e80d1e365f334c26b908178ad4] | committer: Michael Niedermayer avformat/mov: Free temp buffer upon negative sample_size error. 2d8d554f15a7a27cfeca81467cc9341a86f784e2 added a new error condition

[FFmpeg-cvslog] avformat/mov: Free temp buffer upon negative sample_size error.

ffmpeg | branch: master | Dale Curtis | Mon May 18 15:35:35 2020 -0700| [cd0771c38c06ef397466123c6c85521835f98bfd] | committer: Michael Niedermayer avformat/mov: Free temp buffer upon negative sample_size error. 2d8d554f15a7a27cfeca81467cc9341a86f784e2 added a new error condition

Re: [FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

On Mon, May 18, 2020 at 3:24 PM Dale Curtis wrote: > On Mon, May 18, 2020 at 2:22 PM Michael Niedermayer > wrote: > >> >> > 38cfdcfc9d4fa1c1239dc01a766e369b20a0232a sat_math_builtin_v5.patch >> > > Latest upload is sat_math_builtin_v6.patch -- is that not

[FFmpeg-devel] [PATCH] [mov] Free temp buffer upon negative sample_size error.

2d8d554f15a7a27cfeca81467cc9341a86f784e2 added a new error condition to mov_read_stsz() but forgot to free a temporary buffer when it occurs. Signed-off-by: Dale Curtis --- libavformat/mov.c | 1 + 1 file changed, 1 insertion(+) free_temp_v0.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

. > > From 8ac3c2cea0d00c4aec2d1c6278462e6b0f1015b3 Mon Sep 17 00:00:00 2001 > > From: Dale Curtis > > Date: Fri, 1 May 2020 10:20:43 -0700 > > Subject: [PATCH] Use gcc/clang builtins for av_sat_(add|sub)_64_c if > > available. > > doesnt apply cleanly > > Applying: Use gcc

Re: [FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

The C versions of these functions have landed. Michael, did you intend to land this one too? - dale On Thu, May 14, 2020 at 12:47 PM Dale Curtis wrote: > Rebased. > > On Mon, May 4, 2020 at 11:47 AM James Almer wrote: > >> On 5/4/2020 3:40 PM, Dale Curtis wrote: >> >

[FFmpeg-cvslog] avutil/common: Add saturated add/sub operations for int64_t.

ffmpeg | branch: master | Dale Curtis | Thu Apr 30 15:16:31 2020 -0700| [a7e1af3cb10b7c914622deff3435bc20eb65] | committer: Michael Niedermayer avutil/common: Add saturated add/sub operations for int64_t. Many places are using their own custom code for handling overflow around timestamps

[FFmpeg-cvslog] avformat/mov: Don't allow negative sample sizes.

ffmpeg | branch: master | Dale Curtis | Thu May 14 15:31:55 2020 -0700| [2d8d554f15a7a27cfeca81467cc9341a86f784e2] | committer: Michael Niedermayer avformat/mov: Don't allow negative sample sizes. Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer > http://git.videolan.

Re: Thread safety around setting kAudioDevicePropertyBufferFrameSize?

On Fri, May 15, 2020 at 12:15 PM Ed Wynne wrote: > > On May 15, 2020, at 3:00 PM, Dale Curtis wrote: > Our callbacks already handle changes in the buffer size properly. The > issue is instead that CoreAudio itself is crashing unfortunately. > > > Right, I was talking abou

Re: Thread safety around setting kAudioDevicePropertyBufferFrameSize?

On Fri, May 15, 2020 at 11:47 AM Ed Wynne wrote: > On May 15, 2020, at 2:26 PM, Dale Curtis wrote: > On Thu, May 14, 2020 at 1:31 PM Ed Wynne wrote: > >> On May 14, 2020, at 3:21 PM, Dale Curtis via Coreaudio-api < >> coreaudio-api@lists.apple.com> wrote: >> Ca

Re: Thread safety around setting kAudioDevicePropertyBufferFrameSize?

On Thu, May 14, 2020 at 1:31 PM Ed Wynne wrote: > > > On May 14, 2020, at 3:21 PM, Dale Curtis via Coreaudio-api < > coreaudio-api@lists.apple.com> wrote: > > Can someone from the CoreAudio team clarify when it's safe to > call AudioUnitSetProperty() on kAudioDe

[FFmpeg-devel] [PATCH 4/5] [utils, mathematics] Fix overflow in compute_pkt_fields().

Fixes one issue in the function itself and one in the dependent function av_add_stable() which wasn't checking for NaN. Signed-off-by: Dale Curtis --- libavformat/utils.c | 2 +- libavutil/mathematics.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) From

[FFmpeg-devel] [PATCH 3/5] [mov] Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

Signed-off-by: Dale Curtis --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From e4b963f890ae37e2a06276a3067daab75013c8f9 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Thu, 14 May 2020 14:38:07 -0700 Subject: [PATCH 3/5] [mov] Check if DTS is AV_NOPTS_VALUE

[FFmpeg-devel] [PATCH 5/5] [mov] Don't allow negative sample sizes.

Signed-off-by: Dale Curtis --- libavformat/mov.c | 4 1 file changed, 4 insertions(+) From 3cd1ecb83c4b100bef99d9cd23d0066f0ad3cc5c Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Thu, 14 May 2020 14:57:08 -0700 Subject: [PATCH 5/5] [mov] Don't allow negative sample sizes. Signed-off

[FFmpeg-devel] [PATCH 2/5] [oggparsetheora] Use av_sat_sub64() when updating pts by duration.

Signed-off-by: Dale Curtis --- libavformat/oggparsetheora.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From 6ae2834612ddc47e4ce40c87a9cc7e76e402bbdc Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Thu, 14 May 2020 14:33:55 -0700 Subject: [PATCH 2/5] [oggparsetheora] Use av_sat_sub64

[FFmpeg-devel] [PATCH 1/5] Use av_sat_add64() when updating start_time by skip_samples.

Avoids overflow from fuzzed skip_samples values. Signed-off-by: Dale Curtis --- libavformat/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) From 7482aaef44fa4c6c43efd16b2ed8eb474b1283b0 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Thu, 14 May 2020 14:29:15 -0700 Subject

Re: [FFmpeg-devel] [PATCH] [libavutil] Add saturated add/sub operations for int64_t.

On Thu, May 14, 2020 at 11:47 AM Michael Niedermayer wrote: > On Fri, May 01, 2020 at 11:42:43AM -0700, Dale Curtis wrote: > > On Fri, May 1, 2020 at 10:57 AM Carl Eugen Hoyos > wrote: > > > > > Could you confirm that you attached the wrong patch? > > > &g

Re: [FFmpeg-devel] [PATCH] Don't adjust start time for MP3 files; packets are not adjusted.

Bump again for this one too. Thanks. The Arch Linux distro is awaiting resolution of this issue. - dale On Mon, May 4, 2020 at 11:10 AM Dale Curtis wrote: > Any comments on this? Thanks. > > - dale > > On Thu, Apr 30, 2020 at 12:42 PM Dale Curtis > wrote: > >>

Thread safety around setting kAudioDevicePropertyBufferFrameSize?

In Chromium, we may have a variety of audio streams running with different buffering size needs (e.g., normal audio playback vs WebRTC vs WebAudio). Since buffer sizes are shared among all active audio units for the same device, we try to ensure we lower and raise as needed to save as much power

Re: [FFmpeg-devel] [PATCH] [libavutil] Add saturated add/sub operations for int64_t.

On Wed, May 13, 2020 at 3:55 PM Michael Niedermayer wrote: > On Fri, May 08, 2020 at 05:21:06PM -0700, Dale Curtis wrote: > > On Wed, May 6, 2020 at 7:03 AM Michael Niedermayer > > > wrote: > > > > > On Mon, May 04, 2020 at 04:06:56PM -0700, Dale Curtis wrote:

Re: [FFmpeg-devel] [PATCH] [libavutil] Add saturated add/sub operations for int64_t.

On Fri, May 8, 2020 at 5:21 PM Dale Curtis wrote: > On Wed, May 6, 2020 at 7:03 AM Michael Niedermayer > wrote: > >> On Mon, May 04, 2020 at 04:06:56PM -0700, Dale Curtis wrote: >> > On Mon, May 4, 2020 at 3:39 PM Michael Niedermayer >> >> > wrote: &g

Re: [FFmpeg-devel] [PATCH] [libavutil] Add saturated add/sub operations for int64_t.

On Wed, May 6, 2020 at 7:03 AM Michael Niedermayer wrote: > On Mon, May 04, 2020 at 04:06:56PM -0700, Dale Curtis wrote: > > On Mon, May 4, 2020 at 3:39 PM Michael Niedermayer > > > wrote: > > > > > On Mon, May 04, 2020 at 02:19:47PM -0700, Dale Curtis wrote: &g

Re: [FFmpeg-devel] [PATCH] [libavutil] Add saturated add/sub operations for int64_t.

On Mon, May 4, 2020 at 3:39 PM Michael Niedermayer wrote: > On Mon, May 04, 2020 at 02:19:47PM -0700, Dale Curtis wrote: > > On Mon, May 4, 2020 at 1:48 PM Michael Niedermayer > > [...] > You snipped out the example I provided, but did you have an opinion on which approach lo

Re: [FFmpeg-devel] [PATCH] [libavutil] Add saturated add/sub operations for int64_t.

On Mon, May 4, 2020 at 1:48 PM Michael Niedermayer wrote: > this could be done, but iam unsure this API is optimal > > Maybe its best to show an example, why iam unsure about the API > Thanks, but maybe a more concrete case to look at would be the patch I sent for fixing skip samples: "Avoid

Re: [FFmpeg-devel] [PATCH] Don't adjust start time for MP3 files; packets are not adjusted.

Any comments on this? Thanks. - dale On Thu, Apr 30, 2020 at 12:42 PM Dale Curtis wrote: > Ping for this patch. Thanks > > - dale > > On Thu, Apr 23, 2020 at 4:33 PM Dale Curtis > wrote: > >> This is a patch Chromium has carried for a while, we forgot to send it &g

Re: [FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

On Mon, May 4, 2020 at 11:19 AM James Almer wrote: > On 5/4/2020 3:09 PM, Dale Curtis wrote: > > Bump. I have 5 integer overflow fuzzing issues awaiting our resolution of > > this discussion. Thanks. > > > > - dale > > What's the first version of clang with

  1   2   3   4   5   >